qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>, John Snow <jsnow@redhat.com>,
	Eduardo Habkost <ehabkost@redhat.com>,
	Cleber Rosa <crosa@redhat.com>
Subject: [PATCH 4/7] python/machine: move more variable initializations to _pre_launch
Date: Thu, 18 Nov 2021 15:46:17 -0500	[thread overview]
Message-ID: <20211118204620.1897674-5-jsnow@redhat.com> (raw)
In-Reply-To: <20211118204620.1897674-1-jsnow@redhat.com>

No need to clear them only to set them later.

Signed-off-by: John Snow <jsnow@redhat.com>
---
 python/qemu/machine/machine.py | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py
index ad529fd92a..f92e73de40 100644
--- a/python/qemu/machine/machine.py
+++ b/python/qemu/machine/machine.py
@@ -327,6 +327,14 @@ def _pre_launch(self) -> None:
         self._qemu_log_path = os.path.join(self.log_dir, self._name + ".log")
         self._qemu_log_file = open(self._qemu_log_path, 'wb')
 
+        self._iolog = None
+        self._qemu_full_args = tuple(chain(
+            self._wrapper,
+            [self._binary],
+            self._base_args,
+            self._args
+        ))
+
     def _post_launch(self) -> None:
         if self._qmp_connection:
             self._qmp.accept(self._qmp_timer)
@@ -390,8 +398,6 @@ def launch(self) -> None:
         if self._launched:
             raise QEMUMachineError('VM already launched')
 
-        self._iolog = None
-        self._qemu_full_args = ()
         try:
             self._launch()
             self._launched = True
@@ -410,12 +416,6 @@ def _launch(self) -> None:
         Launch the VM and establish a QMP connection
         """
         self._pre_launch()
-        self._qemu_full_args = tuple(
-            chain(self._wrapper,
-                  [self._binary],
-                  self._base_args,
-                  self._args)
-        )
         LOG.debug('VM launch command: %r', ' '.join(self._qemu_full_args))
 
         # Cleaning up of this subprocess is guaranteed by _do_shutdown.
-- 
2.31.1



  parent reply	other threads:[~2021-11-18 20:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-18 20:46 [PATCH 0/7] python: More fixes for 6.2 John Snow
2021-11-18 20:46 ` [PATCH 1/7] python/machine: add @sock_dir property John Snow
2021-11-19 12:21   ` Willian Rampazzo
2021-11-18 20:46 ` [PATCH 2/7] python/machine: remove _remove_monitor_sockfile property John Snow
2021-11-19 12:22   ` Willian Rampazzo
2021-11-18 20:46 ` [PATCH 3/7] python/machine: add instance disambiguator to default nickname John Snow
2021-11-19  8:54   ` Philippe Mathieu-Daudé
2021-11-19 12:24   ` Willian Rampazzo
2021-11-18 20:46 ` John Snow [this message]
2021-11-19 12:26   ` [PATCH 4/7] python/machine: move more variable initializations to _pre_launch Willian Rampazzo
2021-11-18 20:46 ` [PATCH 5/7] python/machine: handle "fast" QEMU terminations John Snow
2021-11-19 16:09   ` Willian Rampazzo
2021-11-18 20:46 ` [PATCH 6/7] scripts/device-crash-test: Use a QMP timeout John Snow
2021-11-18 20:46 ` [PATCH 7/7] python/aqmp: fix send_fd_scm for python 3.6.x John Snow
2021-11-19 16:18   ` Willian Rampazzo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211118204620.1897674-5-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=crosa@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).