qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>, John Snow <jsnow@redhat.com>,
	Eduardo Habkost <ehabkost@redhat.com>,
	Cleber Rosa <crosa@redhat.com>
Subject: [PATCH 6/7] scripts/device-crash-test: Use a QMP timeout
Date: Thu, 18 Nov 2021 15:46:19 -0500	[thread overview]
Message-ID: <20211118204620.1897674-7-jsnow@redhat.com> (raw)
In-Reply-To: <20211118204620.1897674-1-jsnow@redhat.com>

Despite all the previous fixes, it's still possible for
device-crash-test to wedge itself in the case that QEMU terminates *so
quickly* that it doesn't even begin a connection attempt to our QMP
client. Python will just joyfully wait ad infinitum for a connection
that will now never arrive.

The real fix is to use asyncio to simultaneously poll both the health of
the launched process AND the connection attempt. That's quite a bit more
invasive than just setting a connection timeout, though.

Do the very simplest thing for now.

Signed-off-by: John Snow <jsnow@redhat.com>
---
 scripts/device-crash-test | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/device-crash-test b/scripts/device-crash-test
index 1c73dac93e..7fbd99158b 100755
--- a/scripts/device-crash-test
+++ b/scripts/device-crash-test
@@ -353,7 +353,7 @@ def checkOneCase(args, testcase):
             '-device', qemuOptsEscape(device)]
     cmdline = ' '.join([binary] + args)
     dbg("will launch QEMU: %s", cmdline)
-    vm = QEMUMachine(binary=binary, args=args)
+    vm = QEMUMachine(binary=binary, args=args, qmp_timer=15)
 
     exc = None
     exc_traceback = None
-- 
2.31.1



  parent reply	other threads:[~2021-11-18 20:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-18 20:46 [PATCH 0/7] python: More fixes for 6.2 John Snow
2021-11-18 20:46 ` [PATCH 1/7] python/machine: add @sock_dir property John Snow
2021-11-19 12:21   ` Willian Rampazzo
2021-11-18 20:46 ` [PATCH 2/7] python/machine: remove _remove_monitor_sockfile property John Snow
2021-11-19 12:22   ` Willian Rampazzo
2021-11-18 20:46 ` [PATCH 3/7] python/machine: add instance disambiguator to default nickname John Snow
2021-11-19  8:54   ` Philippe Mathieu-Daudé
2021-11-19 12:24   ` Willian Rampazzo
2021-11-18 20:46 ` [PATCH 4/7] python/machine: move more variable initializations to _pre_launch John Snow
2021-11-19 12:26   ` Willian Rampazzo
2021-11-18 20:46 ` [PATCH 5/7] python/machine: handle "fast" QEMU terminations John Snow
2021-11-19 16:09   ` Willian Rampazzo
2021-11-18 20:46 ` John Snow [this message]
2021-11-18 20:46 ` [PATCH 7/7] python/aqmp: fix send_fd_scm for python 3.6.x John Snow
2021-11-19 16:18   ` Willian Rampazzo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211118204620.1897674-7-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=crosa@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).