From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-block@nongnu.org, "John Snow" <jsnow@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Hanna Reitz" <hreitz@redhat.com>,
"Vladimir Sementsov-Ogievskiy" <vsementsov@virtuozzo.com>,
kvm@vger.kernel.org, "Michael Roth" <michael.roth@amd.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Taylor Simpson" <tsimpson@quicinc.com>,
"Eric Blake" <eblake@redhat.com>
Subject: [PATCH-for-6.2? v2 3/3] qga: Spell QEMU all caps
Date: Fri, 19 Nov 2021 10:17:01 +0100 [thread overview]
Message-ID: <20211119091701.277973-4-philmd@redhat.com> (raw)
In-Reply-To: <20211119091701.277973-1-philmd@redhat.com>
QEMU should be written all caps.
Normally checkpatch.pl warns when it is not (see commit
9964d8f9422: "checkpatch: Add QEMU specific rule").
Replace Qemu -> QEMU, update the error message to use the
more descriptive "Guest Agent" name instead of "GA".
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
qga/installer/qemu-ga.wxs | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs
index 0950e8c6bec..c02e47fc036 100644
--- a/qga/installer/qemu-ga.wxs
+++ b/qga/installer/qemu-ga.wxs
@@ -40,14 +40,14 @@
<?endif?>
<Product
- Name="QEMU guest agent"
+ Name="QEMU Guest Agent"
Id="*"
UpgradeCode="{EB6B8302-C06E-4BEC-ADAC-932C68A3A98D}"
Manufacturer="$(env.QEMU_GA_MANUFACTURER)"
Version="$(env.QEMU_GA_VERSION)"
Language="1033">
<?if $(var.Arch) = 32 ?>
- <Condition Message="Error: 32-bit version of Qemu GA can not be installed on 64-bit Windows.">NOT VersionNT64</Condition>
+ <Condition Message="Error: 32-bit version of QEMU Guest Agent can not be installed on 64-bit Windows.">NOT VersionNT64</Condition>
<?endif?>
<Package
Manufacturer="$(env.QEMU_GA_MANUFACTURER)"
@@ -64,7 +64,7 @@
<Directory Id="TARGETDIR" Name="SourceDir">
<Directory Id="$(var.GaProgramFilesFolder)" Name="QEMU Guest Agent">
- <Directory Id="qemu_ga_directory" Name="Qemu-ga">
+ <Directory Id="qemu_ga_directory" Name="QEMU-GA">
<Component Id="qemu_ga" Guid="{908B7199-DE2A-4DC6-A8D0-27A5AE444FEA}">
<File Id="qemu_ga.exe" Name="qemu-ga.exe" Source="$(env.BUILD_DIR)/qga/qemu-ga.exe" KeyPath="yes" DiskId="1"/>
<ServiceInstall
--
2.31.1
next prev parent reply other threads:[~2021-11-19 9:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 9:16 [PATCH-for-6.2? v2 0/3] misc: Spell QEMU all caps Philippe Mathieu-Daudé
2021-11-19 9:16 ` [PATCH-for-6.2? v2 1/3] docs: " Philippe Mathieu-Daudé
2021-11-19 9:17 ` [PATCH-for-6.2? v2 2/3] misc: " Philippe Mathieu-Daudé
2021-11-19 15:43 ` Taylor Simpson
2021-11-19 9:17 ` Philippe Mathieu-Daudé [this message]
2021-12-15 10:31 ` [PATCH-for-6.2? v2 0/3] " Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211119091701.277973-4-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=armbru@redhat.com \
--cc=crosa@redhat.com \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=michael.roth@amd.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=tsimpson@quicinc.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).