[PULL for-6.2 0/2] ppc queue

[PULL for-6.2 0/2] ppc queue

[Cédric Le Goater]

The following changes since commit 67f9968ce3f0847ffddb6ee2837a3641acd92abf:

  Update version for v6.2.0-rc1 release (2021-11-16 21:07:31 +0100)

are available in the Git repository at:

  https://github.com/legoater/qemu/ tags/pull-ppc-20211119

for you to fetch changes up to a443d55c3f7cafa3d5dfb7fe2b5c3cd9d671b61d:

  tests/tcg/ppc64le: Fix compile flags for byte_reverse (2021-11-17 19:10:44 +0100)

----------------------------------------------------------------
ppc 6.2 queue:

* fix pmu vmstate
* Fix compile of byte_reverse on new compilers

----------------------------------------------------------------
Laurent Vivier (1):
      pmu: fix pmu vmstate subsection list

Richard Henderson (1):
      tests/tcg/ppc64le: Fix compile flags for byte_reverse

 hw/misc/macio/pmu.c               |  1 +
 tests/tcg/ppc64le/Makefile.target | 12 +++---------
 2 files changed, 4 insertions(+), 9 deletions(-)

[PULL for-6.2 1/2] pmu: fix pmu vmstate subsection list

[Cédric Le Goater]

From: Laurent Vivier <lvivier@redhat.com>

The subsection is not closed by a NULL marker so this can trigger
a segfault when the pmu vmstate is saved.

This can be easily shown with:

  $ ./qemu-system-ppc64  -dump-vmstate vmstate.json
  Segmentation fault (core dumped)

Fixes: d811d61fbc6c ("mac_newworld: add PMU device")
Cc: mark.cave-ayland@ilande.co.uk
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 hw/misc/macio/pmu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/misc/macio/pmu.c b/hw/misc/macio/pmu.c
index 4ad4f50e08c3..eb39c64694aa 100644
--- a/hw/misc/macio/pmu.c
+++ b/hw/misc/macio/pmu.c
@@ -718,6 +718,7 @@ static const VMStateDescription vmstate_pmu = {
     },
     .subsections = (const VMStateDescription * []) {
         &vmstate_pmu_adb,
+        NULL
     }
 };
 
-- 
2.31.1

[PULL for-6.2 2/2] tests/tcg/ppc64le: Fix compile flags for byte_reverse

[Cédric Le Goater]

From: Richard Henderson <richard.henderson@linaro.org>

With a host compiler new enough to recognize power10 insns,
CROSS_CC_HAS_POWER10 is true, but we do not supply the -cpu
option to the compiler, resulting in

/tmp/ccAVdYJd.s: Assembler messages:
/tmp/ccAVdYJd.s:49: Error: unrecognized opcode: `brh'
/tmp/ccAVdYJd.s:78: Error: unrecognized opcode: `brw'
/tmp/ccAVdYJd.s:107: Error: unrecognized opcode: `brd'
make[2]: *** [byte_reverse] Error 1

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 tests/tcg/ppc64le/Makefile.target | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/tests/tcg/ppc64le/Makefile.target b/tests/tcg/ppc64le/Makefile.target
index 5e65b1590dba..ba2fde5ff1c3 100644
--- a/tests/tcg/ppc64le/Makefile.target
+++ b/tests/tcg/ppc64le/Makefile.target
@@ -9,18 +9,12 @@ PPC64LE_TESTS=bcdsub
 endif
 bcdsub: CFLAGS += -mpower8-vector
 
-PPC64LE_TESTS += byte_reverse
 ifneq ($(DOCKER_IMAGE)$(CROSS_CC_HAS_POWER10),)
+PPC64LE_TESTS += byte_reverse
+endif
+byte_reverse: CFLAGS += -mcpu=power10
 run-byte_reverse: QEMU_OPTS+=-cpu POWER10
 run-plugin-byte_reverse-with-%: QEMU_OPTS+=-cpu POWER10
-else
-byte_reverse:
-	$(call skip-test, "BUILD of $@", "missing compiler support")
-run-byte_reverse:
-	$(call skip-test, "RUN of byte_reverse", "not built")
-run-plugin-byte_reverse-with-%:
-	$(call skip-test, "RUN of byte_reverse ($*)", "not built")
-endif
 
 PPC64LE_TESTS += signal_save_restore_xer
 
-- 
2.31.1

Re: [PULL for-6.2 0/2] ppc queue

[Richard Henderson]

On 11/19/21 12:55 PM, Cédric Le Goater wrote:
> The following changes since commit 67f9968ce3f0847ffddb6ee2837a3641acd92abf:
> 
>    Update version for v6.2.0-rc1 release (2021-11-16 21:07:31 +0100)
> 
> are available in the Git repository at:
> 
>    https://github.com/legoater/qemu/ tags/pull-ppc-20211119
> 
> for you to fetch changes up to a443d55c3f7cafa3d5dfb7fe2b5c3cd9d671b61d:
> 
>    tests/tcg/ppc64le: Fix compile flags for byte_reverse (2021-11-17 19:10:44 +0100)
> 
> ----------------------------------------------------------------
> ppc 6.2 queue:
> 
> * fix pmu vmstate
> * Fix compile of byte_reverse on new compilers
> 
> ----------------------------------------------------------------
> Laurent Vivier (1):
>        pmu: fix pmu vmstate subsection list
> 
> Richard Henderson (1):
>        tests/tcg/ppc64le: Fix compile flags for byte_reverse
> 
>   hw/misc/macio/pmu.c               |  1 +
>   tests/tcg/ppc64le/Makefile.target | 12 +++---------
>   2 files changed, 4 insertions(+), 9 deletions(-)

Applied, thanks.

r~

[PULL for-6.2 0/2] ppc queue

[Cédric Le Goater]

The following changes since commit 67f9968ce3f0847ffddb6ee2837a3641acd92abf:

  Update version for v6.2.0-rc1 release (2021-11-16 21:07:31 +0100)

are available in the Git repository at:

  https://github.com/legoater/qemu/ tags/pull-ppc-20211119

for you to fetch changes up to a443d55c3f7cafa3d5dfb7fe2b5c3cd9d671b61d:

  tests/tcg/ppc64le: Fix compile flags for byte_reverse (2021-11-17 19:10:44 +0100)

----------------------------------------------------------------
ppc 6.2 queue:

* fix pmu vmstate
* Fix compile of byte_reverse on new compilers

----------------------------------------------------------------
Laurent Vivier (1):
      pmu: fix pmu vmstate subsection list

Richard Henderson (1):
      tests/tcg/ppc64le: Fix compile flags for byte_reverse

 hw/misc/macio/pmu.c               |  1 +
 tests/tcg/ppc64le/Makefile.target | 12 +++---------
 2 files changed, 4 insertions(+), 9 deletions(-)

Re: [PULL for-6.2 0/2] ppc queue

[Cédric Le Goater]

Oops forget this email. I got the directory wrong on my command line.

Sorry for the noise.

C.

On 11/26/21 12:51, Cédric Le Goater wrote:
> The following changes since commit 67f9968ce3f0847ffddb6ee2837a3641acd92abf:
> 
>    Update version for v6.2.0-rc1 release (2021-11-16 21:07:31 +0100)
> 
> are available in the Git repository at:
> 
>    https://github.com/legoater/qemu/ tags/pull-ppc-20211119
> 
> for you to fetch changes up to a443d55c3f7cafa3d5dfb7fe2b5c3cd9d671b61d:
> 
>    tests/tcg/ppc64le: Fix compile flags for byte_reverse (2021-11-17 19:10:44 +0100)
> 
> ----------------------------------------------------------------
> ppc 6.2 queue:
> 
> * fix pmu vmstate
> * Fix compile of byte_reverse on new compilers
> 
> ----------------------------------------------------------------
> Laurent Vivier (1):
>        pmu: fix pmu vmstate subsection list
> 
> Richard Henderson (1):
>        tests/tcg/ppc64le: Fix compile flags for byte_reverse
> 
>   hw/misc/macio/pmu.c               |  1 +
>   tests/tcg/ppc64le/Makefile.target | 12 +++---------
>   2 files changed, 4 insertions(+), 9 deletions(-)
>