From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>
Subject: [PULL 3/7] esp: ensure that async_len is reset to 0 during esp_hard_reset()
Date: Fri, 19 Nov 2021 15:45:35 +0100 [thread overview]
Message-ID: <20211119144539.285740-4-pbonzini@redhat.com> (raw)
In-Reply-To: <20211119144539.285740-1-pbonzini@redhat.com>
From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
If a reset command is sent after data has been transferred into the SCSI buffer
ensure that async_len is reset to 0. Otherwise a subsequent TI command assumes
the SCSI buffer contains data to be transferred to the device causing it to
dereference the stale async_buf pointer.
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Fixes: https://gitlab.com/qemu-project/qemu/-/issues/724
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20211118100327.29061-2-mark.cave-ayland@ilande.co.uk>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/scsi/esp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c
index 84f935b549..58d0edbd56 100644
--- a/hw/scsi/esp.c
+++ b/hw/scsi/esp.c
@@ -894,6 +894,7 @@ void esp_hard_reset(ESPState *s)
memset(s->wregs, 0, ESP_REGS);
s->tchi_written = 0;
s->ti_size = 0;
+ s->async_len = 0;
fifo8_reset(&s->fifo);
fifo8_reset(&s->cmdfifo);
s->dma = 0;
--
2.33.1
next prev parent reply other threads:[~2021-11-19 14:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 14:45 [PULL 0/7] Misc bugfixes for 2021-11-19 Paolo Bonzini
2021-11-19 14:45 ` [PULL 1/7] meson: fix botched compile check conversions Paolo Bonzini
2021-11-19 14:45 ` [PULL 2/7] nvmm: Fix support for stable version Paolo Bonzini
2021-11-19 14:45 ` Paolo Bonzini [this message]
2021-11-19 14:45 ` [PULL 4/7] qtest/am53c974-test: add test for reset before transfer Paolo Bonzini
2021-11-19 14:45 ` [PULL 5/7] docs: Spell QEMU all caps Paolo Bonzini
2021-11-19 14:45 ` [PULL 6/7] meson.build: Support ncurses on MacOS and OpenBSD Paolo Bonzini
2021-11-19 14:45 ` [PULL 7/7] chardev/wctable: don't free the instance in wctablet_chr_finalize Paolo Bonzini
2021-11-19 18:14 ` [PULL 0/7] Misc bugfixes for 2021-11-19 Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211119144539.285740-4-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).