From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Eduardo Habkost <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Vivek Kasireddy <vivek.kasireddy@intel.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Dongwon Kim <dongwon.kim@intel.com>
Subject: [PULL 3/8] ui/gtk: graphic_hw_gl_flushed after closing dmabuf->fence_fd
Date: Mon, 22 Nov 2021 13:40:10 +0100 [thread overview]
Message-ID: <20211122124015.909318-4-kraxel@redhat.com> (raw)
In-Reply-To: <20211122124015.909318-1-kraxel@redhat.com>
From: Dongwon Kim <dongwon.kim@intel.com>
The dmabuf often becomes invalid right after unblocking pipeline
and graphic_hw_gl_flushed in case a new scanout blob is submitted
because the dmabuf associated with the current guest scanout is
freed after swapping.
So both graphic_hw_gl_block and graphic_hw_gl_flushed should be
executed after closing fence_fd for the current dmabuf.
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Vivek Kasireddy <vivek.kasireddy@intel.com>
Signed-off-by: Dongwon Kim <dongwon.kim@intel.com>
Message-Id: <20211121172237.14937-1-dongwon.kim@intel.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
ui/gtk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/gtk.c b/ui/gtk.c
index dc4a1491f0ce..428f02f2dfe1 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -589,11 +589,11 @@ void gd_hw_gl_flushed(void *vcon)
VirtualConsole *vc = vcon;
QemuDmaBuf *dmabuf = vc->gfx.guest_fb.dmabuf;
- graphic_hw_gl_block(vc->gfx.dcl.con, false);
- graphic_hw_gl_flushed(vc->gfx.dcl.con);
qemu_set_fd_handler(dmabuf->fence_fd, NULL, NULL, NULL);
close(dmabuf->fence_fd);
dmabuf->fence_fd = -1;
+ graphic_hw_gl_block(vc->gfx.dcl.con, false);
+ graphic_hw_gl_flushed(vc->gfx.dcl.con);
}
/** DisplayState Callbacks (opengl version) **/
--
2.33.1
next prev parent reply other threads:[~2021-11-22 12:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 12:40 [PULL 0/8] Fixes 20211122 patches Gerd Hoffmann
2021-11-22 12:40 ` [PULL 1/8] ui: fix incorrect scaling on highdpi with gtk/opengl Gerd Hoffmann
2021-11-22 12:40 ` [PULL 2/8] ui: fix incorrect pointer position on highdpi with gtk Gerd Hoffmann
2021-11-22 12:40 ` Gerd Hoffmann [this message]
2021-11-22 12:40 ` [PULL 4/8] ui/vnc-clipboard: fix adding notifier twice Gerd Hoffmann
2021-11-22 12:40 ` [PULL 5/8] migration: fix dump-vmstate with modules Gerd Hoffmann
2021-11-22 12:40 ` [PULL 6/8] hw/i386/microvm: Reduce annoying debug message in dt_setup_microvm() Gerd Hoffmann
2021-11-22 12:40 ` [PULL 7/8] microvm: add missing g_free() call Gerd Hoffmann
2021-11-22 12:40 ` [PULL 8/8] microvm: check g_file_set_contents() return value Gerd Hoffmann
2021-11-22 15:35 ` [PULL 0/8] Fixes 20211122 patches Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211122124015.909318-4-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=dongwon.kim@intel.com \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=vivek.kasireddy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).