qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Laurent Vivier" <lvivier@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PULL 5/8] migration: fix dump-vmstate with modules
Date: Mon, 22 Nov 2021 13:40:12 +0100	[thread overview]
Message-ID: <20211122124015.909318-6-kraxel@redhat.com> (raw)
In-Reply-To: <20211122124015.909318-1-kraxel@redhat.com>

From: Laurent Vivier <lvivier@redhat.com>

To work correctly -dump-vmstate and vmstate-static-checker.py need to
dump all the supported vmstates.

But as some devices can be modules, they are not loaded at startup and not
dumped. Fix that by loading all available modules before dumping the
machine vmstate.

Fixes: 7ab6e7fcce97 ("qdev: device module support")
Cc: kraxel@redhat.com
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20211116072840.132731-1-lvivier@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 softmmu/vl.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/softmmu/vl.c b/softmmu/vl.c
index 1159a64bce4e..620a1f1367e2 100644
--- a/softmmu/vl.c
+++ b/softmmu/vl.c
@@ -3766,6 +3766,7 @@ void qemu_init(int argc, char **argv, char **envp)
 
     if (vmstate_dump_file) {
         /* dump and exit */
+        module_load_qom_all();
         dump_vmstate_json_to_file(vmstate_dump_file);
         exit(0);
     }
-- 
2.33.1



  parent reply	other threads:[~2021-11-22 12:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-22 12:40 [PULL 0/8] Fixes 20211122 patches Gerd Hoffmann
2021-11-22 12:40 ` [PULL 1/8] ui: fix incorrect scaling on highdpi with gtk/opengl Gerd Hoffmann
2021-11-22 12:40 ` [PULL 2/8] ui: fix incorrect pointer position on highdpi with gtk Gerd Hoffmann
2021-11-22 12:40 ` [PULL 3/8] ui/gtk: graphic_hw_gl_flushed after closing dmabuf->fence_fd Gerd Hoffmann
2021-11-22 12:40 ` [PULL 4/8] ui/vnc-clipboard: fix adding notifier twice Gerd Hoffmann
2021-11-22 12:40 ` Gerd Hoffmann [this message]
2021-11-22 12:40 ` [PULL 6/8] hw/i386/microvm: Reduce annoying debug message in dt_setup_microvm() Gerd Hoffmann
2021-11-22 12:40 ` [PULL 7/8] microvm: add missing g_free() call Gerd Hoffmann
2021-11-22 12:40 ` [PULL 8/8] microvm: check g_file_set_contents() return value Gerd Hoffmann
2021-11-22 15:35 ` [PULL 0/8] Fixes 20211122 patches Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211122124015.909318-6-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).