* [PATCH for-6.2] qapi/machine.json: Fix incorrect description for die-id
@ 2021-11-22 3:26 Yanan Wang via
2021-11-22 14:12 ` Eric Blake
0 siblings, 1 reply; 2+ messages in thread
From: Yanan Wang via @ 2021-11-22 3:26 UTC (permalink / raw)
To: qemu-devel, qemu-arm
Cc: Markus Armbruster, Eric Blake, Eduardo Habkost,
Philippe Mathieu-Daudé, Paolo Bonzini, wanghaibin.wang,
Yanan Wang
In terms of scope, die-id should mean "the die number within
socket the CPU belongs to" instead of "the die number within
node/board the CPU belongs to". Fix it to avoid confusing
the Doc reader.
Fixes: 176d2cda0d ("i386/cpu: Consolidate die-id validity in smp context")
Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
---
qapi/machine.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi/machine.json b/qapi/machine.json
index 067e3f5378..f1839acf20 100644
--- a/qapi/machine.json
+++ b/qapi/machine.json
@@ -867,7 +867,7 @@
#
# @node-id: NUMA node ID the CPU belongs to
# @socket-id: socket number within node/board the CPU belongs to
-# @die-id: die number within node/board the CPU belongs to (Since 4.1)
+# @die-id: die number within socket the CPU belongs to (since 4.1)
# @core-id: core number within die the CPU belongs to
# @thread-id: thread number within core the CPU belongs to
#
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH for-6.2] qapi/machine.json: Fix incorrect description for die-id
2021-11-22 3:26 [PATCH for-6.2] qapi/machine.json: Fix incorrect description for die-id Yanan Wang via
@ 2021-11-22 14:12 ` Eric Blake
0 siblings, 0 replies; 2+ messages in thread
From: Eric Blake @ 2021-11-22 14:12 UTC (permalink / raw)
To: Yanan Wang
Cc: Eduardo Habkost, qemu-devel, Markus Armbruster, qemu-arm,
wanghaibin.wang, Paolo Bonzini, Philippe Mathieu-Daudé
On Mon, Nov 22, 2021 at 11:26:51AM +0800, Yanan Wang wrote:
> In terms of scope, die-id should mean "the die number within
> socket the CPU belongs to" instead of "the die number within
> node/board the CPU belongs to". Fix it to avoid confusing
> the Doc reader.
>
> Fixes: 176d2cda0d ("i386/cpu: Consolidate die-id validity in smp context")
> Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
> ---
> qapi/machine.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/qapi/machine.json b/qapi/machine.json
> index 067e3f5378..f1839acf20 100644
> --- a/qapi/machine.json
> +++ b/qapi/machine.json
> @@ -867,7 +867,7 @@
> #
> # @node-id: NUMA node ID the CPU belongs to
> # @socket-id: socket number within node/board the CPU belongs to
> -# @die-id: die number within node/board the CPU belongs to (Since 4.1)
> +# @die-id: die number within socket the CPU belongs to (since 4.1)
> # @core-id: core number within die the CPU belongs to
> # @thread-id: thread number within core the CPU belongs to
> #
> --
> 2.19.1
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-22 14:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-22 3:26 [PATCH for-6.2] qapi/machine.json: Fix incorrect description for die-id Yanan Wang via
2021-11-22 14:12 ` Eric Blake
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).