From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v1] virtio-mem: Don't skip alignment checks when warning about block size
Date: Mon, 22 Nov 2021 18:53:23 -0500 [thread overview]
Message-ID: <20211122185320-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <3c54b0ab-85b6-bb86-93f6-ecfd6c63f346@redhat.com>
On Mon, Nov 22, 2021 at 01:01:51PM +0100, David Hildenbrand wrote:
> On 12.10.21 09:27, Michael S. Tsirkin wrote:
> > On Mon, Oct 11, 2021 at 07:33:05PM +0200, David Hildenbrand wrote:
> >> If we warn about the block size being smaller than the default, we skip
> >> some alignment checks.
> >>
> >> This can currently only fail on x86-64, when specifying a block size of
> >> 1 MiB, however, we detect the THP size of 2 MiB.
> >>
> >> Fixes: 228957fea3a9 ("virtio-mem: Probe THP size to determine default block size")
> >> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> >> Signed-off-by: David Hildenbrand <david@redhat.com>
> >
> > Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
>
> Thanks Michael, will you send this for the v6.2 release?
>
>
> --
> Thanks,
>
> David / dhildenb
sure
next prev parent reply other threads:[~2021-11-22 23:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 17:33 [PATCH v1] virtio-mem: Don't skip alignment checks when warning about block size David Hildenbrand
2021-10-12 7:27 ` Michael S. Tsirkin
2021-11-22 12:01 ` David Hildenbrand
2021-11-22 23:53 ` Michael S. Tsirkin [this message]
2021-12-17 14:54 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211122185320-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).