qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Willian Rampazzo" <willianr@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH v4 01/18] ui: avoid compiler warnings from unused clipboard info variable
Date: Wed, 24 Nov 2021 13:01:33 +0000	[thread overview]
Message-ID: <20211124130150.268230-2-berrange@redhat.com> (raw)
In-Reply-To: <20211124130150.268230-1-berrange@redhat.com>

With latest clang 13.0.0 we get

../ui/clipboard.c:47:34: error: variable 'old' set but not used [-Werror,-Wunused-but-set-variable]
    g_autoptr(QemuClipboardInfo) old = NULL;
                                 ^

The compiler can't tell that we only declared this variable in
order to get the side effect of free'ing it when out of scope.

This pattern is a little dubious for a use of g_autoptr, so
rewrite the code to avoid it.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 ui/clipboard.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/ui/clipboard.c b/ui/clipboard.c
index d7b008d62a..7672058e84 100644
--- a/ui/clipboard.c
+++ b/ui/clipboard.c
@@ -44,12 +44,11 @@ void qemu_clipboard_peer_release(QemuClipboardPeer *peer,
 
 void qemu_clipboard_update(QemuClipboardInfo *info)
 {
-    g_autoptr(QemuClipboardInfo) old = NULL;
     assert(info->selection < QEMU_CLIPBOARD_SELECTION__COUNT);
 
     notifier_list_notify(&clipboard_notifiers, info);
 
-    old = cbinfo[info->selection];
+    qemu_clipboard_info_unref(cbinfo[info->selection]);
     cbinfo[info->selection] = qemu_clipboard_info_ref(info);
 }
 
-- 
2.33.1



  reply	other threads:[~2021-11-24 13:04 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-24 13:01 [PATCH v4 00/18] tests/docker: start using libvirt-ci's "lcitool" for dockerfiles Daniel P. Berrangé
2021-11-24 13:01 ` Daniel P. Berrangé [this message]
2021-11-24 13:33   ` [PATCH v4 01/18] ui: avoid compiler warnings from unused clipboard info variable Philippe Mathieu-Daudé
2021-12-15 10:22     ` Philippe Mathieu-Daudé
2021-11-24 13:01 ` [PATCH v4 02/18] spice: Update QXLInterface for spice >= 0.15.0 Daniel P. Berrangé
2021-11-24 13:34   ` Philippe Mathieu-Daudé
2021-11-24 13:01 ` [PATCH v4 03/18] meson: require liburing >= 0.3 Daniel P. Berrangé
2021-12-15 11:27   ` Philippe Mathieu-Daudé
2021-12-15 11:56     ` Philippe Mathieu-Daudé
2021-12-15 13:25     ` Stefan Hajnoczi
2021-12-15 13:47     ` Stefano Garzarella
2021-12-15 16:21   ` Li Zhang
2021-11-24 13:01 ` [PATCH v4 04/18] ui: avoid warnings about directdb on Alpine / musl libc Daniel P. Berrangé
2021-11-24 13:32   ` Thomas Huth
2021-11-24 13:42     ` Daniel P. Berrangé
2021-12-15 11:59       ` Philippe Mathieu-Daudé
2021-11-24 13:01 ` [PATCH v4 05/18] ci: explicitly skip I/O tests on alpine Daniel P. Berrangé
2021-11-24 13:36   ` Thomas Huth
2021-11-24 13:38     ` Philippe Mathieu-Daudé
2021-11-24 13:46     ` Daniel P. Berrangé
2021-12-15 12:02       ` Philippe Mathieu-Daudé
2021-11-24 13:01 ` [PATCH v4 06/18] tests/docker: switch fedora image to release 35 Daniel P. Berrangé
2021-12-15 11:28   ` Philippe Mathieu-Daudé
2021-11-24 13:01 ` [PATCH v4 07/18] tests: integrate lcitool for generating build env manifests Daniel P. Berrangé
2021-12-15 11:45   ` Philippe Mathieu-Daudé
2021-11-24 13:01 ` [PATCH v4 08/18] tests/docker: auto-generate centos8.docker with lcitool Daniel P. Berrangé
2021-11-24 13:01 ` [PATCH v4 09/18] tests/docker: auto-generate fedora.docker " Daniel P. Berrangé
2021-11-24 13:01 ` [PATCH v4 10/18] tests/docker: auto-generate ubuntu1804.docker " Daniel P. Berrangé
2021-11-24 13:01 ` [PATCH v4 11/18] tests/docker: auto-generate ubuntu2004.docker " Daniel P. Berrangé
2021-11-24 13:01 ` [PATCH v4 12/18] tests/docker: auto-generate opensuse-leap.docker " Daniel P. Berrangé
2021-11-24 13:01 ` [PATCH v4 13/18] tests/docker: remove ubuntu.docker container Daniel P. Berrangé
2021-11-24 13:01 ` [PATCH v4 14/18] .gitlab-ci.d/cirrus: auto-generate variables with lcitool Daniel P. Berrangé
2021-12-15 11:36   ` Philippe Mathieu-Daudé
2021-11-24 13:01 ` [PATCH v4 15/18] tests/docker: updates to alpine package list Daniel P. Berrangé
2021-12-15 11:31   ` Philippe Mathieu-Daudé
2021-12-15 11:43     ` Daniel P. Berrangé
2021-12-15 11:47       ` Philippe Mathieu-Daudé
2021-11-24 13:01 ` [PATCH v4 16/18] tests/docker: fix sorting of alpine image package lists Daniel P. Berrangé
2021-11-24 13:39   ` Philippe Mathieu-Daudé
2021-11-24 13:01 ` [PATCH v4 17/18] tests/docker: fully expand the alpine package list Daniel P. Berrangé
2021-12-15 11:32   ` Philippe Mathieu-Daudé
2021-11-24 13:01 ` [PATCH v4 18/18] tests/docker: auto-generate alpine.docker with lcitool Daniel P. Berrangé
2021-11-24 13:42   ` Philippe Mathieu-Daudé
2021-12-15 12:57 ` [PATCH v4 00/18] tests/docker: start using libvirt-ci's "lcitool" for dockerfiles Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211124130150.268230-2-berrange@redhat.com \
    --to=berrange@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=f4bug@amsat.org \
    --cc=fam@euphon.net \
    --cc=kraxel@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    --cc=willianr@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).