qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: mst@redhat.com, david@redhat.com
Cc: mpe@ellerman.id.au, Jason Wang <jasowang@redhat.com>,
	qemu-devel@nongnu.org
Subject: [PATCH 1/2] virito-balloon: process all in sgs for free_page_vq
Date: Thu, 25 Nov 2021 10:20:45 +0800	[thread overview]
Message-ID: <20211125022046.10433-1-jasowang@redhat.com> (raw)

We only process the first in sg which may lead to the bitmap of the
pages belongs to following sgs were not cleared. This may result more
pages to be migrated. Fixing this by process all in sgs for
free_page_vq.

Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 hw/virtio/virtio-balloon.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
index c6962fcbfe..17de2558cb 100644
--- a/hw/virtio/virtio-balloon.c
+++ b/hw/virtio/virtio-balloon.c
@@ -510,6 +510,7 @@ static bool get_free_page_hints(VirtIOBalloon *dev)
     VirtIODevice *vdev = VIRTIO_DEVICE(dev);
     VirtQueue *vq = dev->free_page_vq;
     bool ret = true;
+    int i;
 
     while (dev->block_iothread) {
         qemu_cond_wait(&dev->free_page_cond, &dev->free_page_lock);
@@ -544,8 +545,10 @@ static bool get_free_page_hints(VirtIOBalloon *dev)
     }
 
     if (elem->in_num && dev->free_page_hint_status == FREE_PAGE_HINT_S_START) {
-        qemu_guest_free_page_hint(elem->in_sg[0].iov_base,
-                                  elem->in_sg[0].iov_len);
+        for (i = 0; i < elem->in_num; i++) {
+            qemu_guest_free_page_hint(elem->in_sg[i].iov_base,
+                                      elem->in_sg[i].iov_len);
+        }
     }
 
 out:
-- 
2.25.1



             reply	other threads:[~2021-11-25  2:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-25  2:20 Jason Wang [this message]
2021-11-25  2:20 ` [PATCH 2/2] virtio-balloon: correct used length Jason Wang
2021-11-25 16:14   ` Michael S. Tsirkin
2021-11-26  2:45     ` Jason Wang
2021-11-26  7:36       ` Michael S. Tsirkin
2021-11-29  2:48         ` Jason Wang
2021-11-25  8:28 ` [PATCH 1/2] virito-balloon: process all in sgs for free_page_vq David Hildenbrand
2021-11-25 16:09   ` Michael S. Tsirkin
2021-11-25 16:11     ` David Hildenbrand
2021-11-26  1:21       ` Wang, Wei W
2021-11-26  1:42         ` Michael S. Tsirkin
2021-11-26  2:31         ` Jason Wang
2021-11-26  2:40           ` Wang, Wei W
2021-11-26  2:43             ` Jason Wang
2021-11-25  8:34 ` Philippe Mathieu-Daudé
2021-11-25 16:10   ` Michael S. Tsirkin
2021-11-26  2:42     ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211125022046.10433-1-jasowang@redhat.com \
    --to=jasowang@redhat.com \
    --cc=david@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).