qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Jason Wang <jasowang@redhat.com>,
	David Hildenbrand <david@redhat.com>
Subject: [PULL 4/7] virtio-balloon: process all in sgs for free_page_vq
Date: Mon, 29 Nov 2021 08:51:18 -0500	[thread overview]
Message-ID: <20211129135053.560225-5-mst@redhat.com> (raw)
In-Reply-To: <20211129135053.560225-1-mst@redhat.com>

From: Jason Wang <jasowang@redhat.com>

We only process the first in sg which may lead to the bitmap of the
pages belongs to following sgs were not cleared. This may result more
pages to be migrated. Fixing this by process all in sgs for
free_page_vq.

Acked-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Message-Id: <20211129030841.3611-1-jasowang@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 hw/virtio/virtio-balloon.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
index c6962fcbfe..17de2558cb 100644
--- a/hw/virtio/virtio-balloon.c
+++ b/hw/virtio/virtio-balloon.c
@@ -510,6 +510,7 @@ static bool get_free_page_hints(VirtIOBalloon *dev)
     VirtIODevice *vdev = VIRTIO_DEVICE(dev);
     VirtQueue *vq = dev->free_page_vq;
     bool ret = true;
+    int i;
 
     while (dev->block_iothread) {
         qemu_cond_wait(&dev->free_page_cond, &dev->free_page_lock);
@@ -544,8 +545,10 @@ static bool get_free_page_hints(VirtIOBalloon *dev)
     }
 
     if (elem->in_num && dev->free_page_hint_status == FREE_PAGE_HINT_S_START) {
-        qemu_guest_free_page_hint(elem->in_sg[0].iov_base,
-                                  elem->in_sg[0].iov_len);
+        for (i = 0; i < elem->in_num; i++) {
+            qemu_guest_free_page_hint(elem->in_sg[i].iov_base,
+                                      elem->in_sg[i].iov_len);
+        }
     }
 
 out:
-- 
MST



  parent reply	other threads:[~2021-11-29 14:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-29 13:51 [PULL 0/7] virtio,pci,pc: bugfixes Michael S. Tsirkin
2021-11-29 13:51 ` [PULL 1/7] virtio-mmio : fix the crash in the vm shutdown Michael S. Tsirkin
2021-11-29 13:51 ` [PULL 2/7] failover: fix unplug pending detection Michael S. Tsirkin
2021-11-29 13:51 ` [PULL 3/7] vdpa: Add dummy receive callback Michael S. Tsirkin
2021-11-29 13:51 ` Michael S. Tsirkin [this message]
2021-11-29 13:51 ` [PULL 5/7] virtio-balloon: correct used length Michael S. Tsirkin
2021-11-29 13:51 ` [PULL 6/7] intel-iommu: ignore leaf SNP bit in scalable mode Michael S. Tsirkin
2021-11-29 13:51 ` [PULL 7/7] Fix bad overflow check in hw/pci/pcie.c Michael S. Tsirkin
2021-11-29 16:45 ` [PULL 0/7] virtio,pci,pc: bugfixes Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211129135053.560225-5-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=david@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).