From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Taylor Simpson <tsimpson@quicinc.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Sergio Lopez <slp@redhat.com>
Subject: [PATCH for-7.0 2/4] target/hexagon/cpu.h: don't include qemu-common.h
Date: Mon, 29 Nov 2021 20:05:08 +0000 [thread overview]
Message-ID: <20211129200510.1233037-3-peter.maydell@linaro.org> (raw)
In-Reply-To: <20211129200510.1233037-1-peter.maydell@linaro.org>
The qemu-common.h header is not supposed to be included from any
other header files, only from .c files (as documented in a comment at
the start of it).
Move the include to linux-user/hexagon/cpu_loop.c, which needs it for
the declaration of cpu_exec_step_atomic().
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
target/hexagon/cpu.h | 1 -
linux-user/hexagon/cpu_loop.c | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/hexagon/cpu.h b/target/hexagon/cpu.h
index de121d950f2..58a0d3870bb 100644
--- a/target/hexagon/cpu.h
+++ b/target/hexagon/cpu.h
@@ -23,7 +23,6 @@ typedef struct CPUHexagonState CPUHexagonState;
#include "fpu/softfloat-types.h"
-#include "qemu-common.h"
#include "exec/cpu-defs.h"
#include "hex_regs.h"
#include "mmvec/mmvec.h"
diff --git a/linux-user/hexagon/cpu_loop.c b/linux-user/hexagon/cpu_loop.c
index 6b24cbaba93..e47f8348d56 100644
--- a/linux-user/hexagon/cpu_loop.c
+++ b/linux-user/hexagon/cpu_loop.c
@@ -19,6 +19,7 @@
*/
#include "qemu/osdep.h"
+#include "qemu-common.h"
#include "qemu.h"
#include "user-internals.h"
#include "cpu_loop-common.h"
--
2.25.1
next prev parent reply other threads:[~2021-11-29 20:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 20:05 [PATCH for-7.0 0/4] qemu-common.h include cleanup Peter Maydell
2021-11-29 20:05 ` [PATCH for-7.0 1/4] include/hw/i386: Don't include qemu-common.h in .h files Peter Maydell
2021-11-29 20:05 ` Peter Maydell [this message]
2021-12-07 16:55 ` [PATCH for-7.0 2/4] target/hexagon/cpu.h: don't include qemu-common.h Taylor Simpson
2021-11-29 20:05 ` [PATCH for-7.0 3/4] target/rx/cpu.h: Don't " Peter Maydell
2021-12-01 12:26 ` Yoshinori Sato
2021-11-29 20:05 ` [PATCH for-7.0 4/4] hw/arm: Don't include qemu-common.h unnecessarily Peter Maydell
2021-11-29 20:48 ` [PATCH for-7.0 0/4] qemu-common.h include cleanup Peter Maydell
2021-11-30 10:02 ` Markus Armbruster
2021-11-30 8:40 ` Richard Henderson
2021-12-01 13:05 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211129200510.1233037-3-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=slp@redhat.com \
--cc=tsimpson@quicinc.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).