From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: damien.hedde@greensocs.com, berrange@redhat.com,
mark.burton@greensocs.com, edgar.iglesias@gmail.co,
mirela.grujic@greensocs.com, marcandre.lureau@redhat.com,
pbonzini@redhat.com, jsnow@redhat.com
Subject: [PATCH RFC 11/11] vl: Enter main loop in phase @machine-initialized
Date: Thu, 2 Dec 2021 08:04:50 +0100 [thread overview]
Message-ID: <20211202070450.264743-12-armbru@redhat.com> (raw)
In-Reply-To: <20211202070450.264743-1-armbru@redhat.com>
The previous commit demonstrated how you can interleave QMP-over-CLI
with startup. We want the same for real QMP.
QMP-over-CLI starts in phase @no-machine, and may advance the phase.
We then advance to phase @machine-ready, and enter the main loop, and
real QMP becomes available.
If we skip the phase advance, real QMP becomes exactly as expressive
as QMP-over-CLI. Except the main loop crashes.
If we skip to phase @machine-created, it doesn't crash, but it doesn't
give me a QMP monitor either. Same for phase @accel-created.
Skipping to @machine-initialized works, and suffices to let me
demonstrate cold plug via QMP:
$ qemu-system-x86_64
{"QMP": {"version": {"qemu": {"micro": 92, "minor": 1, "major": 6}, "package": "v6.2.0-rc2-39-g8c7f07732b"}, "capabilities": ["oob"]}}
{"execute": "qmp_capabilities", "arguments": {"enable": ["oob"]}}
{"return": {}}
{"execute": "device_add", "arguments": {"driver": "isa-serial"}}
{"return": {}}
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
softmmu/vl.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/softmmu/vl.c b/softmmu/vl.c
index 9406368338..01f87aec07 100644
--- a/softmmu/vl.c
+++ b/softmmu/vl.c
@@ -1038,7 +1038,12 @@ void qemu_init(int argc, char **argv, char **envp)
}
}
- qemu_until_phase(PHASE_MACHINE_READY);
+ /*
+ * FIXME need to force phase, because staying in PHASE_NO_MACHINE
+ * crashes, and going only to PHASE_MACHINE_CREATED or
+ * PHASE_ACCEL_CREATED gives no monitor.
+ */
+ qemu_until_phase(PHASE_MACHINE_INITIALIZED);
}
void qemu_until_phase(MachineInitPhase phase)
--
2.31.1
next prev parent reply other threads:[~2021-12-02 7:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 7:04 [PATCH RFC 00/11] vl: Explore redesign of startup Markus Armbruster
2021-12-02 7:04 ` [PATCH RFC 01/11] vl: Cut off the CLI with an axe Markus Armbruster
2021-12-02 7:04 ` [PATCH RFC 02/11] vl: Drop x-exit-preconfig Markus Armbruster
2021-12-02 7:04 ` [PATCH RFC 03/11] vl: Hardcode a QMP monitor on stdio for now Markus Armbruster
2021-12-02 7:04 ` [PATCH RFC 04/11] vl: Hardcode a VGA device " Markus Armbruster
2021-12-02 7:04 ` [PATCH RFC 05/11] vl: Demonstrate (bad) CLI wrapped around QMP Markus Armbruster
2021-12-02 7:04 ` [PATCH RFC 06/11] vl: Factor qemu_until_phase() out of qemu_init() Markus Armbruster
2021-12-02 7:04 ` [PATCH RFC 07/11] vl: Implement qemu_until_phase() running from arbitrary phase Markus Armbruster
2021-12-02 7:04 ` [PATCH RFC 08/11] vl: Implement qemu_until_phase() running to " Markus Armbruster
2021-12-02 7:04 ` [PATCH RFC 09/11] vl: New QMP command until-phase Markus Armbruster
2021-12-02 7:04 ` [PATCH RFC 10/11] vl: Disregard lack of 'allow-preconfig': true Markus Armbruster
2021-12-02 7:04 ` Markus Armbruster [this message]
2021-12-02 10:26 ` [PATCH RFC 00/11] vl: Explore redesign of startup Markus Armbruster
2021-12-07 16:52 ` Damien Hedde
2021-12-08 7:07 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211202070450.264743-12-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=damien.hedde@greensocs.com \
--cc=edgar.iglesias@gmail.co \
--cc=jsnow@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mark.burton@greensocs.com \
--cc=mirela.grujic@greensocs.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).