From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: damien.hedde@greensocs.com, berrange@redhat.com,
mark.burton@greensocs.com, edgar.iglesias@gmail.co,
mirela.grujic@greensocs.com, marcandre.lureau@redhat.com,
pbonzini@redhat.com, jsnow@redhat.com
Subject: [PATCH RFC 03/11] vl: Hardcode a QMP monitor on stdio for now
Date: Thu, 2 Dec 2021 08:04:42 +0100 [thread overview]
Message-ID: <20211202070450.264743-4-armbru@redhat.com> (raw)
In-Reply-To: <20211202070450.264743-1-armbru@redhat.com>
We bootstrap QMP with the CLI, but the CLI is (temporarily) gone.
Hardcode a QMP monitor on stdio until we get it back.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
softmmu/vl.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/softmmu/vl.c b/softmmu/vl.c
index 39c67b91c4..b14db0f47f 100644
--- a/softmmu/vl.c
+++ b/softmmu/vl.c
@@ -129,6 +129,9 @@
#include "config-host.h"
+#include "qapi/qapi-commands-char.h"
+#include "qapi/qapi-types-control.h"
+
static const char *incoming;
static const char *accelerators;
static ram_addr_t maxram_size;
@@ -617,6 +620,14 @@ static void qemu_create_early_backends(void)
/* spice must initialize before audio as it changes the default auiodev */
/* spice must initialize before chardevs (for spicevmc and spiceport) */
qemu_spice.init();
+
+ /* HACK: hardcoded monitor chardev */
+ qmp_chardev_add("compat_monitor0", &(ChardevBackend){
+ .type = CHARDEV_BACKEND_KIND_STDIO,
+ .u.stdio = {
+ .data = &(ChardevStdio){},
+ },
+ }, &error_abort);
}
@@ -628,6 +639,11 @@ static void qemu_create_late_backends(void)
exit(1);
}
+ /* HACK: hardcoded monitor */
+ monitor_init(&(MonitorOptions){
+ .chardev = (char *)"compat_monitor0",
+ }, false, &error_abort);
+
/* now chardevs have been created we may have semihosting to connect */
qemu_semihosting_connect_chardevs();
qemu_semihosting_console_init();
--
2.31.1
next prev parent reply other threads:[~2021-12-02 7:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 7:04 [PATCH RFC 00/11] vl: Explore redesign of startup Markus Armbruster
2021-12-02 7:04 ` [PATCH RFC 01/11] vl: Cut off the CLI with an axe Markus Armbruster
2021-12-02 7:04 ` [PATCH RFC 02/11] vl: Drop x-exit-preconfig Markus Armbruster
2021-12-02 7:04 ` Markus Armbruster [this message]
2021-12-02 7:04 ` [PATCH RFC 04/11] vl: Hardcode a VGA device for now Markus Armbruster
2021-12-02 7:04 ` [PATCH RFC 05/11] vl: Demonstrate (bad) CLI wrapped around QMP Markus Armbruster
2021-12-02 7:04 ` [PATCH RFC 06/11] vl: Factor qemu_until_phase() out of qemu_init() Markus Armbruster
2021-12-02 7:04 ` [PATCH RFC 07/11] vl: Implement qemu_until_phase() running from arbitrary phase Markus Armbruster
2021-12-02 7:04 ` [PATCH RFC 08/11] vl: Implement qemu_until_phase() running to " Markus Armbruster
2021-12-02 7:04 ` [PATCH RFC 09/11] vl: New QMP command until-phase Markus Armbruster
2021-12-02 7:04 ` [PATCH RFC 10/11] vl: Disregard lack of 'allow-preconfig': true Markus Armbruster
2021-12-02 7:04 ` [PATCH RFC 11/11] vl: Enter main loop in phase @machine-initialized Markus Armbruster
2021-12-02 10:26 ` [PATCH RFC 00/11] vl: Explore redesign of startup Markus Armbruster
2021-12-07 16:52 ` Damien Hedde
2021-12-08 7:07 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211202070450.264743-4-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=damien.hedde@greensocs.com \
--cc=edgar.iglesias@gmail.co \
--cc=jsnow@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mark.burton@greensocs.com \
--cc=mirela.grujic@greensocs.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).