From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: damien.hedde@greensocs.com, berrange@redhat.com,
mark.burton@greensocs.com, edgar.iglesias@gmail.co,
mirela.grujic@greensocs.com, marcandre.lureau@redhat.com,
pbonzini@redhat.com, jsnow@redhat.com
Subject: [PATCH RFC 07/11] vl: Implement qemu_until_phase() running from arbitrary phase
Date: Thu, 2 Dec 2021 08:04:46 +0100 [thread overview]
Message-ID: <20211202070450.264743-8-armbru@redhat.com> (raw)
In-Reply-To: <20211202070450.264743-1-armbru@redhat.com>
A later patch will want to use qemu_until_phase() to advance from one
arbitrary phase to another. Implement advancing from arbitrary phase
to PHASE_MACHINE_READY.
Indentation is intentionally off to minimize diffs. It's RFC :)
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
softmmu/vl.c | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/softmmu/vl.c b/softmmu/vl.c
index e340475986..b7f15d9f86 100644
--- a/softmmu/vl.c
+++ b/softmmu/vl.c
@@ -1043,7 +1043,8 @@ void qemu_until_phase(void)
MachineClass *machine_class;
FILE *vmstate_dump_file = NULL;
- assert(phase_get() == PHASE_NO_MACHINE);
+ switch (phase_get()) {
+ case PHASE_NO_MACHINE:
qemu_process_early_options();
@@ -1077,6 +1078,9 @@ void qemu_until_phase(void)
qemu_apply_machine_options(NULL);
phase_advance(PHASE_MACHINE_CREATED);
+ /* fall through */
+ case PHASE_MACHINE_CREATED:
+
/*
* Note: uses machine properties such as kernel-irqchip, must run
* after qemu_apply_machine_options.
@@ -1084,6 +1088,9 @@ void qemu_until_phase(void)
configure_accelerators("FIXME");
phase_advance(PHASE_ACCEL_CREATED);
+ /* fall through */
+ case PHASE_ACCEL_CREATED:
+
/*
* Beware, QOM objects created before this point miss global and
* compat properties.
@@ -1128,7 +1135,13 @@ void qemu_until_phase(void)
}
qemu_init_board();
+ assert(phase_get() == PHASE_MACHINE_INITIALIZED);
+
+ /* fall through */
+ case PHASE_MACHINE_INITIALIZED:
+
qemu_machine_creation_done();
+ assert(phase_get() == PHASE_MACHINE_READY);
if (replay_mode != REPLAY_MODE_NONE) {
replay_vmstate_init();
@@ -1151,4 +1164,8 @@ void qemu_until_phase(void)
accel_setup_post(current_machine);
os_setup_post();
resume_mux_open();
+
+ case PHASE_MACHINE_READY:
+ break;
+ }
}
--
2.31.1
next prev parent reply other threads:[~2021-12-02 7:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 7:04 [PATCH RFC 00/11] vl: Explore redesign of startup Markus Armbruster
2021-12-02 7:04 ` [PATCH RFC 01/11] vl: Cut off the CLI with an axe Markus Armbruster
2021-12-02 7:04 ` [PATCH RFC 02/11] vl: Drop x-exit-preconfig Markus Armbruster
2021-12-02 7:04 ` [PATCH RFC 03/11] vl: Hardcode a QMP monitor on stdio for now Markus Armbruster
2021-12-02 7:04 ` [PATCH RFC 04/11] vl: Hardcode a VGA device " Markus Armbruster
2021-12-02 7:04 ` [PATCH RFC 05/11] vl: Demonstrate (bad) CLI wrapped around QMP Markus Armbruster
2021-12-02 7:04 ` [PATCH RFC 06/11] vl: Factor qemu_until_phase() out of qemu_init() Markus Armbruster
2021-12-02 7:04 ` Markus Armbruster [this message]
2021-12-02 7:04 ` [PATCH RFC 08/11] vl: Implement qemu_until_phase() running to arbitrary phase Markus Armbruster
2021-12-02 7:04 ` [PATCH RFC 09/11] vl: New QMP command until-phase Markus Armbruster
2021-12-02 7:04 ` [PATCH RFC 10/11] vl: Disregard lack of 'allow-preconfig': true Markus Armbruster
2021-12-02 7:04 ` [PATCH RFC 11/11] vl: Enter main loop in phase @machine-initialized Markus Armbruster
2021-12-02 10:26 ` [PATCH RFC 00/11] vl: Explore redesign of startup Markus Armbruster
2021-12-07 16:52 ` Damien Hedde
2021-12-08 7:07 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211202070450.264743-8-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=damien.hedde@greensocs.com \
--cc=edgar.iglesias@gmail.co \
--cc=jsnow@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mark.burton@greensocs.com \
--cc=mirela.grujic@greensocs.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).