From: Matthew Rosato <mjrosato@linux.ibm.com>
To: thuth@redhat.com, qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Cc: farman@linux.ibm.com, pmorel@linux.ibm.com, david@redhat.com,
cohuck@redhat.com, richard.henderson@linaro.org,
pasic@linux.ibm.com, borntraeger@linux.ibm.com
Subject: [PATCH 2/4] s390x/pci: don't use hard-coded dma range in reg_ioat
Date: Thu, 2 Dec 2021 11:41:08 -0500 [thread overview]
Message-ID: <20211202164110.326947-3-mjrosato@linux.ibm.com> (raw)
In-Reply-To: <20211202164110.326947-1-mjrosato@linux.ibm.com>
Instead use the values from clp info, they will either be the hard-coded
values or what came from the host driver via vfio.
Fixes: 9670ee752727 ("s390x/pci: use a PCI Function structure")
Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>
---
hw/s390x/s390-pci-inst.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c
index 1c8ad91175..11b7f6bfa1 100644
--- a/hw/s390x/s390-pci-inst.c
+++ b/hw/s390x/s390-pci-inst.c
@@ -916,9 +916,10 @@ int pci_dereg_irqs(S390PCIBusDevice *pbdev)
return 0;
}
-static int reg_ioat(CPUS390XState *env, S390PCIIOMMU *iommu, ZpciFib fib,
+static int reg_ioat(CPUS390XState *env, S390PCIBusDevice *pbdev, ZpciFib fib,
uintptr_t ra)
{
+ S390PCIIOMMU *iommu = pbdev->iommu;
uint64_t pba = ldq_p(&fib.pba);
uint64_t pal = ldq_p(&fib.pal);
uint64_t g_iota = ldq_p(&fib.iota);
@@ -927,7 +928,7 @@ static int reg_ioat(CPUS390XState *env, S390PCIIOMMU *iommu, ZpciFib fib,
pba &= ~0xfff;
pal |= 0xfff;
- if (pba > pal || pba < ZPCI_SDMA_ADDR || pal > ZPCI_EDMA_ADDR) {
+ if (pba > pal || pba < pbdev->zpci_fn.sdma || pal > pbdev->zpci_fn.edma) {
s390_program_interrupt(env, PGM_OPERAND, ra);
return -EINVAL;
}
@@ -1125,7 +1126,7 @@ int mpcifc_service_call(S390CPU *cpu, uint8_t r1, uint64_t fiba, uint8_t ar,
} else if (pbdev->iommu->enabled) {
cc = ZPCI_PCI_LS_ERR;
s390_set_status_code(env, r1, ZPCI_MOD_ST_SEQUENCE);
- } else if (reg_ioat(env, pbdev->iommu, fib, ra)) {
+ } else if (reg_ioat(env, pbdev, fib, ra)) {
cc = ZPCI_PCI_LS_ERR;
s390_set_status_code(env, r1, ZPCI_MOD_ST_INSUF_RES);
}
@@ -1150,7 +1151,7 @@ int mpcifc_service_call(S390CPU *cpu, uint8_t r1, uint64_t fiba, uint8_t ar,
s390_set_status_code(env, r1, ZPCI_MOD_ST_SEQUENCE);
} else {
pci_dereg_ioat(pbdev->iommu);
- if (reg_ioat(env, pbdev->iommu, fib, ra)) {
+ if (reg_ioat(env, pbdev, fib, ra)) {
cc = ZPCI_PCI_LS_ERR;
s390_set_status_code(env, r1, ZPCI_MOD_ST_INSUF_RES);
}
--
2.27.0
next prev parent reply other threads:[~2021-12-02 16:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 16:41 [PATCH 0/4] s390x/pci: some small fixes Matthew Rosato
2021-12-02 16:41 ` [PATCH 1/4] s390x/pci: use a reserved ID for the default PCI group Matthew Rosato
2021-12-02 16:43 ` David Hildenbrand
2021-12-02 17:11 ` Matthew Rosato
2021-12-02 21:55 ` David Hildenbrand
2021-12-02 23:06 ` Halil Pasic
2021-12-03 2:25 ` Matthew Rosato
2021-12-03 9:07 ` Pierre Morel
2021-12-03 18:21 ` David Hildenbrand
2021-12-02 21:27 ` Eric Farman
2021-12-03 9:24 ` Pierre Morel
2021-12-02 16:41 ` Matthew Rosato [this message]
2021-12-02 21:27 ` [PATCH 2/4] s390x/pci: don't use hard-coded dma range in reg_ioat Eric Farman
2021-12-03 9:17 ` Pierre Morel
2021-12-02 16:41 ` [PATCH 3/4] s390x/pci: use the passthrough measurement update interval Matthew Rosato
2021-12-02 21:30 ` Eric Farman
2021-12-03 9:17 ` Pierre Morel
2021-12-02 16:41 ` [PATCH 4/4] s390x/pci: add supported DT information to clp response Matthew Rosato
2021-12-02 21:40 ` Eric Farman
2021-12-03 9:33 ` Pierre Morel
2021-12-03 12:03 ` Matthew Rosato
2021-12-03 12:06 ` Matthew Rosato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211202164110.326947-3-mjrosato@linux.ibm.com \
--to=mjrosato@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=farman@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).