* [PATCH for-7.0] hw/i386/pc: Add missing property descriptions
@ 2021-12-06 13:42 Thomas Huth
2022-01-05 8:19 ` Thomas Huth
2022-01-06 8:10 ` Igor Mammedov
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Huth @ 2021-12-06 13:42 UTC (permalink / raw)
To: qemu-devel, Paolo Bonzini
Cc: Eduardo Habkost, Richard Henderson, Michael S. Tsirkin
When running "qemu-system-x86_64 -M pc,help" I noticed that some
properties were still missing their description. Add them now so
that users get at least a slightly better idea what they are all
about.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/i386/pc.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index a2ef40ecbc..837f2bff4e 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1734,15 +1734,23 @@ static void pc_machine_class_init(ObjectClass *oc, void *data)
object_class_property_add_bool(oc, PC_MACHINE_SMBUS,
pc_machine_get_smbus, pc_machine_set_smbus);
+ object_class_property_set_description(oc, PC_MACHINE_SMBUS,
+ "Enable/disable system management bus");
object_class_property_add_bool(oc, PC_MACHINE_SATA,
pc_machine_get_sata, pc_machine_set_sata);
+ object_class_property_set_description(oc, PC_MACHINE_SATA,
+ "Enable/disable Serial ATA bus");
object_class_property_add_bool(oc, PC_MACHINE_PIT,
pc_machine_get_pit, pc_machine_set_pit);
+ object_class_property_set_description(oc, PC_MACHINE_PIT,
+ "Enable/disable Intel 8254 programmable interval timer emulation");
object_class_property_add_bool(oc, "hpet",
pc_machine_get_hpet, pc_machine_set_hpet);
+ object_class_property_set_description(oc, "hpet",
+ "Enable/disable high precision event timer emulation");
object_class_property_add_bool(oc, "default-bus-bypass-iommu",
pc_machine_get_default_bus_bypass_iommu,
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH for-7.0] hw/i386/pc: Add missing property descriptions
2021-12-06 13:42 [PATCH for-7.0] hw/i386/pc: Add missing property descriptions Thomas Huth
@ 2022-01-05 8:19 ` Thomas Huth
2022-01-06 8:10 ` Igor Mammedov
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2022-01-05 8:19 UTC (permalink / raw)
To: qemu-devel, Paolo Bonzini
Cc: Eduardo Habkost, Richard Henderson, Michael S. Tsirkin
On 06/12/2021 14.42, Thomas Huth wrote:
> When running "qemu-system-x86_64 -M pc,help" I noticed that some
> properties were still missing their description. Add them now so
> that users get at least a slightly better idea what they are all
> about.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/i386/pc.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index a2ef40ecbc..837f2bff4e 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -1734,15 +1734,23 @@ static void pc_machine_class_init(ObjectClass *oc, void *data)
>
> object_class_property_add_bool(oc, PC_MACHINE_SMBUS,
> pc_machine_get_smbus, pc_machine_set_smbus);
> + object_class_property_set_description(oc, PC_MACHINE_SMBUS,
> + "Enable/disable system management bus");
>
> object_class_property_add_bool(oc, PC_MACHINE_SATA,
> pc_machine_get_sata, pc_machine_set_sata);
> + object_class_property_set_description(oc, PC_MACHINE_SATA,
> + "Enable/disable Serial ATA bus");
>
> object_class_property_add_bool(oc, PC_MACHINE_PIT,
> pc_machine_get_pit, pc_machine_set_pit);
> + object_class_property_set_description(oc, PC_MACHINE_PIT,
> + "Enable/disable Intel 8254 programmable interval timer emulation");
>
> object_class_property_add_bool(oc, "hpet",
> pc_machine_get_hpet, pc_machine_set_hpet);
> + object_class_property_set_description(oc, "hpet",
> + "Enable/disable high precision event timer emulation");
>
> object_class_property_add_bool(oc, "default-bus-bypass-iommu",
> pc_machine_get_default_bus_bypass_iommu,
Friendly happy new year ping!
Thomas
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH for-7.0] hw/i386/pc: Add missing property descriptions
2021-12-06 13:42 [PATCH for-7.0] hw/i386/pc: Add missing property descriptions Thomas Huth
2022-01-05 8:19 ` Thomas Huth
@ 2022-01-06 8:10 ` Igor Mammedov
1 sibling, 0 replies; 3+ messages in thread
From: Igor Mammedov @ 2022-01-06 8:10 UTC (permalink / raw)
To: Thomas Huth
Cc: Eduardo Habkost, Paolo Bonzini, Richard Henderson, qemu-devel,
Michael S. Tsirkin
On Mon, 6 Dec 2021 14:42:55 +0100
Thomas Huth <thuth@redhat.com> wrote:
> When running "qemu-system-x86_64 -M pc,help" I noticed that some
> properties were still missing their description. Add them now so
> that users get at least a slightly better idea what they are all
> about.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> hw/i386/pc.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index a2ef40ecbc..837f2bff4e 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -1734,15 +1734,23 @@ static void pc_machine_class_init(ObjectClass *oc, void *data)
>
> object_class_property_add_bool(oc, PC_MACHINE_SMBUS,
> pc_machine_get_smbus, pc_machine_set_smbus);
> + object_class_property_set_description(oc, PC_MACHINE_SMBUS,
> + "Enable/disable system management bus");
>
> object_class_property_add_bool(oc, PC_MACHINE_SATA,
> pc_machine_get_sata, pc_machine_set_sata);
> + object_class_property_set_description(oc, PC_MACHINE_SATA,
> + "Enable/disable Serial ATA bus");
>
> object_class_property_add_bool(oc, PC_MACHINE_PIT,
> pc_machine_get_pit, pc_machine_set_pit);
> + object_class_property_set_description(oc, PC_MACHINE_PIT,
> + "Enable/disable Intel 8254 programmable interval timer emulation");
>
> object_class_property_add_bool(oc, "hpet",
> pc_machine_get_hpet, pc_machine_set_hpet);
> + object_class_property_set_description(oc, "hpet",
> + "Enable/disable high precision event timer emulation");
>
> object_class_property_add_bool(oc, "default-bus-bypass-iommu",
> pc_machine_get_default_bus_bypass_iommu,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-06 8:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-06 13:42 [PATCH for-7.0] hw/i386/pc: Add missing property descriptions Thomas Huth
2022-01-05 8:19 ` Thomas Huth
2022-01-06 8:10 ` Igor Mammedov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).