qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: Juan Quintela <quintela@redhat.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	peterx@redhat.com,
	Leonardo Bras Soares Passos <lsoaresp@redhat.com>
Subject: [PATCH 6/7] migration: Dump sub-cmd name in loadvm_process_command tp
Date: Tue,  7 Dec 2021 19:50:15 +0800	[thread overview]
Message-ID: <20211207115016.73195-7-peterx@redhat.com> (raw)
In-Reply-To: <20211207115016.73195-1-peterx@redhat.com>

It'll be easier to read the name rather than index of sub-cmd when debugging.

Signed-off-by: Peter Xu <peterx@redhat.com>
---
 migration/savevm.c     | 2 +-
 migration/trace-events | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/migration/savevm.c b/migration/savevm.c
index d59e976d50..17b8e25e00 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -2271,7 +2271,7 @@ static int loadvm_process_command(QEMUFile *f)
         return qemu_file_get_error(f);
     }
 
-    trace_loadvm_process_command(cmd, len);
+    trace_loadvm_process_command(mig_cmd_args[cmd].name, len);
     if (cmd >= MIG_CMD_MAX || cmd == MIG_CMD_INVALID) {
         error_report("MIG_CMD 0x%x unknown (len 0x%x)", cmd, len);
         return -EINVAL;
diff --git a/migration/trace-events b/migration/trace-events
index b48d873b8a..d63a5915f5 100644
--- a/migration/trace-events
+++ b/migration/trace-events
@@ -22,7 +22,7 @@ loadvm_postcopy_handle_resume(void) ""
 loadvm_postcopy_ram_handle_discard(void) ""
 loadvm_postcopy_ram_handle_discard_end(void) ""
 loadvm_postcopy_ram_handle_discard_header(const char *ramid, uint16_t len) "%s: %ud"
-loadvm_process_command(uint16_t com, uint16_t len) "com=0x%x len=%d"
+loadvm_process_command(const char *s, uint16_t len) "com=%s len=%d"
 loadvm_process_command_ping(uint32_t val) "0x%x"
 postcopy_ram_listen_thread_exit(void) ""
 postcopy_ram_listen_thread_start(void) ""
-- 
2.32.0



  parent reply	other threads:[~2021-12-07 11:54 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-07 11:50 [PATCH 0/7] migration: Postcopy cleanup on ram disgard Peter Xu
2021-12-07 11:50 ` [PATCH 1/7] migration: Drop dead code of ram_debug_dump_bitmap() Peter Xu
2021-12-08 16:05   ` Dr. David Alan Gilbert
2022-01-26 21:02   ` Juan Quintela
2021-12-07 11:50 ` [PATCH 2/7] migration: Don't return for postcopy_chunk_hostpages() Peter Xu
2021-12-08 16:28   ` Dr. David Alan Gilbert
2022-01-26 21:03   ` Juan Quintela
2021-12-07 11:50 ` [PATCH 3/7] migration: Drop postcopy_chunk_hostpages() Peter Xu
2021-12-08 16:55   ` Dr. David Alan Gilbert
2022-01-26 21:14   ` Juan Quintela
2021-12-07 11:50 ` [PATCH 4/7] migration: Do chunk page in postcopy_each_ram_send_discard() Peter Xu
2021-12-08 17:39   ` Dr. David Alan Gilbert
2022-01-26 21:15   ` Juan Quintela
2021-12-07 11:50 ` [PATCH 5/7] migration: Drop return code for disgard ram process Peter Xu
2021-12-08 18:12   ` Dr. David Alan Gilbert
2022-01-26 21:17   ` Juan Quintela
2021-12-07 11:50 ` Peter Xu [this message]
2021-12-08 18:41   ` [PATCH 6/7] migration: Dump sub-cmd name in loadvm_process_command tp Dr. David Alan Gilbert
2021-12-09  1:44     ` Peter Xu
2021-12-07 11:50 ` [PATCH 7/7] migration: Finer grained tracepoints for POSTCOPY_LISTEN Peter Xu
2021-12-08 19:46   ` Dr. David Alan Gilbert
2021-12-09  1:54     ` Peter Xu
2021-12-09  9:04       ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211207115016.73195-7-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=lsoaresp@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).