From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: Juan Quintela <quintela@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
peterx@redhat.com,
Leonardo Bras Soares Passos <lsoaresp@redhat.com>
Subject: [PATCH 7/7] migration: Finer grained tracepoints for POSTCOPY_LISTEN
Date: Tue, 7 Dec 2021 19:50:16 +0800 [thread overview]
Message-ID: <20211207115016.73195-8-peterx@redhat.com> (raw)
In-Reply-To: <20211207115016.73195-1-peterx@redhat.com>
The enablement of postcopy listening has a few steps, add a few tracepoints to
be there ready for some basic measurements for them.
Signed-off-by: Peter Xu <peterx@redhat.com>
---
migration/savevm.c | 5 ++++-
migration/trace-events | 2 +-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/migration/savevm.c b/migration/savevm.c
index 17b8e25e00..5b3f31eab2 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -1946,7 +1946,7 @@ static void *postcopy_ram_listen_thread(void *opaque)
static int loadvm_postcopy_handle_listen(MigrationIncomingState *mis)
{
PostcopyState ps = postcopy_state_set(POSTCOPY_INCOMING_LISTENING);
- trace_loadvm_postcopy_handle_listen();
+ trace_loadvm_postcopy_handle_listen(1);
Error *local_err = NULL;
if (ps != POSTCOPY_INCOMING_ADVISE && ps != POSTCOPY_INCOMING_DISCARD) {
@@ -1962,6 +1962,7 @@ static int loadvm_postcopy_handle_listen(MigrationIncomingState *mis)
postcopy_ram_prepare_discard(mis);
}
}
+ trace_loadvm_postcopy_handle_listen(2);
/*
* Sensitise RAM - can now generate requests for blocks that don't exist
@@ -1974,6 +1975,7 @@ static int loadvm_postcopy_handle_listen(MigrationIncomingState *mis)
return -1;
}
}
+ trace_loadvm_postcopy_handle_listen(3);
if (postcopy_notify(POSTCOPY_NOTIFY_INBOUND_LISTEN, &local_err)) {
error_report_err(local_err);
@@ -1988,6 +1990,7 @@ static int loadvm_postcopy_handle_listen(MigrationIncomingState *mis)
QEMU_THREAD_DETACHED);
qemu_sem_wait(&mis->listen_thread_sem);
qemu_sem_destroy(&mis->listen_thread_sem);
+ trace_loadvm_postcopy_handle_listen(4);
return 0;
}
diff --git a/migration/trace-events b/migration/trace-events
index d63a5915f5..1aa6937dc1 100644
--- a/migration/trace-events
+++ b/migration/trace-events
@@ -14,7 +14,7 @@ loadvm_handle_cmd_packaged_main(int ret) "%d"
loadvm_handle_cmd_packaged_received(int ret) "%d"
loadvm_handle_recv_bitmap(char *s) "%s"
loadvm_postcopy_handle_advise(void) ""
-loadvm_postcopy_handle_listen(void) ""
+loadvm_postcopy_handle_listen(int i) "%d"
loadvm_postcopy_handle_run(void) ""
loadvm_postcopy_handle_run_cpu_sync(void) ""
loadvm_postcopy_handle_run_vmstart(void) ""
--
2.32.0
next prev parent reply other threads:[~2021-12-07 11:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 11:50 [PATCH 0/7] migration: Postcopy cleanup on ram disgard Peter Xu
2021-12-07 11:50 ` [PATCH 1/7] migration: Drop dead code of ram_debug_dump_bitmap() Peter Xu
2021-12-08 16:05 ` Dr. David Alan Gilbert
2022-01-26 21:02 ` Juan Quintela
2021-12-07 11:50 ` [PATCH 2/7] migration: Don't return for postcopy_chunk_hostpages() Peter Xu
2021-12-08 16:28 ` Dr. David Alan Gilbert
2022-01-26 21:03 ` Juan Quintela
2021-12-07 11:50 ` [PATCH 3/7] migration: Drop postcopy_chunk_hostpages() Peter Xu
2021-12-08 16:55 ` Dr. David Alan Gilbert
2022-01-26 21:14 ` Juan Quintela
2021-12-07 11:50 ` [PATCH 4/7] migration: Do chunk page in postcopy_each_ram_send_discard() Peter Xu
2021-12-08 17:39 ` Dr. David Alan Gilbert
2022-01-26 21:15 ` Juan Quintela
2021-12-07 11:50 ` [PATCH 5/7] migration: Drop return code for disgard ram process Peter Xu
2021-12-08 18:12 ` Dr. David Alan Gilbert
2022-01-26 21:17 ` Juan Quintela
2021-12-07 11:50 ` [PATCH 6/7] migration: Dump sub-cmd name in loadvm_process_command tp Peter Xu
2021-12-08 18:41 ` Dr. David Alan Gilbert
2021-12-09 1:44 ` Peter Xu
2021-12-07 11:50 ` Peter Xu [this message]
2021-12-08 19:46 ` [PATCH 7/7] migration: Finer grained tracepoints for POSTCOPY_LISTEN Dr. David Alan Gilbert
2021-12-09 1:54 ` Peter Xu
2021-12-09 9:04 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211207115016.73195-8-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lsoaresp@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).