* [PATCH v2] COLO: Move some trace code behind qemu_mutex_unlock_iothread()
@ 2021-12-14 17:19 Rao, Lei
2021-12-14 8:23 ` Juan Quintela
0 siblings, 1 reply; 2+ messages in thread
From: Rao, Lei @ 2021-12-14 17:19 UTC (permalink / raw)
To: chen.zhang, quintela, dgilbert; +Cc: Rao, Lei, qemu-devel
There is no need to put some trace code in the critical section.
So, moving it behind qemu_mutex_unlock_iothread() can reduce the
lock time.
Signed-off-by: Lei Rao <lei.rao@intel.com>
---
migration/colo.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/migration/colo.c b/migration/colo.c
index 2415325262..3ccacb29c8 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -683,8 +683,8 @@ static void colo_incoming_process_checkpoint(MigrationIncomingState *mis,
qemu_mutex_lock_iothread();
vm_stop_force_state(RUN_STATE_COLO);
- trace_colo_vm_state_change("run", "stop");
qemu_mutex_unlock_iothread();
+ trace_colo_vm_state_change("run", "stop");
/* FIXME: This is unnecessary for periodic checkpoint mode */
colo_send_message(mis->to_src_file, COLO_MESSAGE_CHECKPOINT_REPLY,
@@ -786,8 +786,8 @@ static void colo_incoming_process_checkpoint(MigrationIncomingState *mis,
vmstate_loading = false;
vm_start();
- trace_colo_vm_state_change("stop", "run");
qemu_mutex_unlock_iothread();
+ trace_colo_vm_state_change("stop", "run");
if (failover_get_state() == FAILOVER_STATUS_RELAUNCH) {
return;
@@ -870,8 +870,8 @@ void *colo_process_incoming_thread(void *opaque)
abort();
#endif
vm_start();
- trace_colo_vm_state_change("stop", "run");
qemu_mutex_unlock_iothread();
+ trace_colo_vm_state_change("stop", "run");
colo_send_message(mis->to_src_file, COLO_MESSAGE_CHECKPOINT_READY,
&local_err);
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] COLO: Move some trace code behind qemu_mutex_unlock_iothread()
2021-12-14 17:19 [PATCH v2] COLO: Move some trace code behind qemu_mutex_unlock_iothread() Rao, Lei
@ 2021-12-14 8:23 ` Juan Quintela
0 siblings, 0 replies; 2+ messages in thread
From: Juan Quintela @ 2021-12-14 8:23 UTC (permalink / raw)
To: Rao, Lei; +Cc: chen.zhang, dgilbert, qemu-devel
"Rao, Lei" <lei.rao@intel.com> wrote:
> There is no need to put some trace code in the critical section.
> So, moving it behind qemu_mutex_unlock_iothread() can reduce the
> lock time.
>
> Signed-off-by: Lei Rao <lei.rao@intel.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
queued for 7.0
> ---
> migration/colo.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/migration/colo.c b/migration/colo.c
> index 2415325262..3ccacb29c8 100644
> --- a/migration/colo.c
> +++ b/migration/colo.c
> @@ -683,8 +683,8 @@ static void colo_incoming_process_checkpoint(MigrationIncomingState *mis,
>
> qemu_mutex_lock_iothread();
> vm_stop_force_state(RUN_STATE_COLO);
> - trace_colo_vm_state_change("run", "stop");
> qemu_mutex_unlock_iothread();
> + trace_colo_vm_state_change("run", "stop");
>
> /* FIXME: This is unnecessary for periodic checkpoint mode */
> colo_send_message(mis->to_src_file, COLO_MESSAGE_CHECKPOINT_REPLY,
> @@ -786,8 +786,8 @@ static void colo_incoming_process_checkpoint(MigrationIncomingState *mis,
>
> vmstate_loading = false;
> vm_start();
> - trace_colo_vm_state_change("stop", "run");
> qemu_mutex_unlock_iothread();
> + trace_colo_vm_state_change("stop", "run");
>
> if (failover_get_state() == FAILOVER_STATUS_RELAUNCH) {
> return;
> @@ -870,8 +870,8 @@ void *colo_process_incoming_thread(void *opaque)
> abort();
> #endif
> vm_start();
> - trace_colo_vm_state_change("stop", "run");
> qemu_mutex_unlock_iothread();
> + trace_colo_vm_state_change("stop", "run");
>
> colo_send_message(mis->to_src_file, COLO_MESSAGE_CHECKPOINT_READY,
> &local_err);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-14 8:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-14 17:19 [PATCH v2] COLO: Move some trace code behind qemu_mutex_unlock_iothread() Rao, Lei
2021-12-14 8:23 ` Juan Quintela
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).