From: "Cédric Le Goater" <clg@kaod.org>
To: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Cédric Le Goater" <clg@kaod.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [PULL 065/102] ppc/ppc405: Drop flag parameter in ppc405_set_bootinfo()
Date: Wed, 15 Dec 2021 18:03:20 +0100 [thread overview]
Message-ID: <20211215170357.321643-53-clg@kaod.org> (raw)
In-Reply-To: <20211215170357.321643-1-clg@kaod.org>
It was introduced in commit b8d3f5d12642 ("Add flags to support
PowerPC 405 bootinfos variations.") but since its value has always
been set to '1'.
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20211206103712.1866296-6-clg@kaod.org>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
hw/ppc/ppc405.h | 3 +--
hw/ppc/ppc405_boards.c | 2 +-
hw/ppc/ppc405_uc.c | 8 +++-----
3 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/hw/ppc/ppc405.h b/hw/ppc/ppc405.h
index c58f739886a6..4cb77aca5690 100644
--- a/hw/ppc/ppc405.h
+++ b/hw/ppc/ppc405.h
@@ -56,8 +56,7 @@ struct ppc4xx_bd_info_t {
};
/* PowerPC 405 core */
-ram_addr_t ppc405_set_bootinfo (CPUPPCState *env, ppc4xx_bd_info_t *bd,
- uint32_t flags);
+ram_addr_t ppc405_set_bootinfo(CPUPPCState *env, ppc4xx_bd_info_t *bd);
void ppc4xx_plb_init(CPUPPCState *env);
void ppc405_ebc_init(CPUPPCState *env);
diff --git a/hw/ppc/ppc405_boards.c b/hw/ppc/ppc405_boards.c
index f1623aa622a6..2ac38c86a643 100644
--- a/hw/ppc/ppc405_boards.c
+++ b/hw/ppc/ppc405_boards.c
@@ -261,7 +261,7 @@ static void ref405ep_init(MachineState *machine)
bd.bi_plb_busfreq = 33333333;
bd.bi_pci_busfreq = 33333333;
bd.bi_opbfreq = 33333333;
- bdloc = ppc405_set_bootinfo(env, &bd, 0x00000001);
+ bdloc = ppc405_set_bootinfo(env, &bd);
env->gpr[3] = bdloc;
kernel_base = KERNEL_LOAD_ADDR;
/* now we can load the kernel */
diff --git a/hw/ppc/ppc405_uc.c b/hw/ppc/ppc405_uc.c
index e14d61e9b899..6806d6be31d5 100644
--- a/hw/ppc/ppc405_uc.c
+++ b/hw/ppc/ppc405_uc.c
@@ -41,8 +41,7 @@
#include "qapi/error.h"
#include "trace.h"
-ram_addr_t ppc405_set_bootinfo (CPUPPCState *env, ppc4xx_bd_info_t *bd,
- uint32_t flags)
+ram_addr_t ppc405_set_bootinfo(CPUPPCState *env, ppc4xx_bd_info_t *bd)
{
CPUState *cs = env_cpu(env);
ram_addr_t bdloc;
@@ -81,9 +80,8 @@ ram_addr_t ppc405_set_bootinfo (CPUPPCState *env, ppc4xx_bd_info_t *bd,
stb_phys(cs->as, bdloc + 0x64 + i, bd->bi_pci_enetaddr[i]);
}
n = 0x6A;
- if (flags & 0x00000001) {
- for (i = 0; i < 6; i++)
- stb_phys(cs->as, bdloc + n++, bd->bi_pci_enetaddr2[i]);
+ for (i = 0; i < 6; i++) {
+ stb_phys(cs->as, bdloc + n++, bd->bi_pci_enetaddr2[i]);
}
stl_be_phys(cs->as, bdloc + n, bd->bi_opbfreq);
n += 4;
--
2.31.1
next prev parent reply other threads:[~2021-12-15 18:15 UTC|newest]
Thread overview: 111+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 16:57 [PULL 000/102] ppc queue Cédric Le Goater
2021-12-15 16:57 ` [PULL 001/102] pseries: Update SLOF firmware image Cédric Le Goater
2021-12-15 16:57 ` [PULL 002/102] hw/ppc/mac.h: Remove MAX_CPUS macro Cédric Le Goater
2021-12-15 16:57 ` [PULL 003/102] target/ppc: Fixed call to deferred exception Cédric Le Goater
2021-12-15 16:57 ` [PULL 004/102] test/tcg/ppc64le: test mtfsf Cédric Le Goater
2021-12-15 16:57 ` [PULL 005/102] target/ppc: ppc_store_fpscr doesn't update bits 0 to 28 and 52 Cédric Le Goater
2021-12-15 16:57 ` [PULL 006/102] target/ppc: Implement Vector Expand Mask Cédric Le Goater
2021-12-15 16:57 ` [PULL 007/102] target/ppc: Implement Vector Extract Mask Cédric Le Goater
2021-12-15 16:57 ` [PULL 008/102] target/ppc: Implement Vector Mask Move insns Cédric Le Goater
2021-12-15 16:57 ` [PULL 009/102] ivshmem.c: change endianness to LITTLE_ENDIAN Cédric Le Goater
2021-12-15 16:57 ` [PULL 010/102] ivshmem-test.c: enable test_ivshmem_server for ppc64 arch Cédric Le Goater
2021-12-15 16:57 ` [PULL 011/102] pci-host: Allow extended config space access for PowerNV PHB4 model Cédric Le Goater
2021-12-15 16:57 ` [PULL 012/102] docs: Minor updates on the powernv documentation Cédric Le Goater
2021-12-15 16:57 ` [PULL 013/102] ppc/pnv.c: add a friendly warning when accel=kvm is used Cédric Le Goater
2021-12-15 17:02 ` Cédric Le Goater
2021-12-15 17:02 ` [PULL 014/102] docs/system/ppc/powernv.rst: document KVM support status Cédric Le Goater
2021-12-15 17:02 ` [PULL 015/102] ppc/pnv.c: fix "system-id" FDT when -uuid is set Cédric Le Goater
2021-12-15 17:02 ` [PULL 016/102] docs: Introducing pseries documentation Cédric Le Goater
2021-12-15 17:02 ` [PULL 017/102] docs: rSTify ppc-spapr-hcalls.txt Cédric Le Goater
2021-12-15 17:02 ` [PULL 018/102] docs: Rename ppc-spapr-hcalls.txt to ppc-spapr-hcalls.rst Cédric Le Goater
2021-12-15 17:02 ` [PULL 019/102] Link new ppc-spapr-hcalls.rst file to pseries.rst Cédric Le Goater
2021-12-15 17:02 ` [PULL 020/102] softfloat: Extend float_exception_flags to 16 bits Cédric Le Goater
2021-12-15 17:02 ` [PULL 021/102] softfloat: Add flag specific to Inf - Inf Cédric Le Goater
2021-12-15 17:02 ` [PULL 022/102] softfloat: Add flag specific to Inf * 0 Cédric Le Goater
2021-12-15 17:02 ` [PULL 023/102] softfloat: Add flags specific to Inf / Inf and 0 / 0 Cédric Le Goater
2021-12-15 17:02 ` [PULL 024/102] softfloat: Add flag specific to sqrt(-x) Cédric Le Goater
2021-12-15 17:02 ` [PULL 025/102] softfloat: Add flag specific to convert non-nan to int Cédric Le Goater
2021-12-15 17:02 ` [PULL 026/102] softfloat: Add flag specific to signaling nans Cédric Le Goater
2021-12-15 17:02 ` [PULL 027/102] target/ppc: Update float_invalid_op_addsub for new flags Cédric Le Goater
2021-12-15 17:02 ` [PULL 028/102] target/ppc: Update float_invalid_op_mul " Cédric Le Goater
2021-12-15 17:02 ` [PULL 029/102] target/ppc: Update float_invalid_op_div " Cédric Le Goater
2021-12-15 17:02 ` [PULL 030/102] target/ppc: Move float_check_status from FPU_FCTI to translate Cédric Le Goater
2021-12-15 17:02 ` [PULL 031/102] target/ppc: Update float_invalid_cvt for new flags Cédric Le Goater
2021-12-15 17:02 ` [PULL 032/102] target/ppc: Fix VXCVI return value Cédric Le Goater
2021-12-15 17:02 ` [PULL 033/102] target/ppc: Remove inline from do_fri Cédric Le Goater
2021-12-15 17:02 ` [PULL 034/102] target/ppc: Use FloatRoundMode in do_fri Cédric Le Goater
2021-12-15 17:02 ` [PULL 035/102] target/ppc: Tidy inexact handling " Cédric Le Goater
2021-12-15 17:02 ` [PULL 036/102] target/ppc: Clean up do_fri Cédric Le Goater
2021-12-15 17:02 ` [PULL 037/102] target/ppc: Update fmadd for new flags Cédric Le Goater
2021-12-15 17:02 ` [PULL 038/102] target/ppc: Split out do_fmadd Cédric Le Goater
2021-12-15 17:02 ` [PULL 039/102] target/ppc: Do not call do_float_check_status from do_fmadd Cédric Le Goater
2021-12-15 17:02 ` [PULL 040/102] target/ppc: Split out do_frsp Cédric Le Goater
2021-12-15 17:02 ` [PULL 041/102] target/ppc: Update do_frsp for new flags Cédric Le Goater
2021-12-15 17:02 ` [PULL 042/102] target/ppc: Use helper_todouble in do_frsp Cédric Le Goater
2021-12-15 17:02 ` [PULL 043/102] target/ppc: Update sqrt for new flags Cédric Le Goater
2021-12-15 17:02 ` [PULL 044/102] target/ppc: Update xsrqpi and xsrqpxp to " Cédric Le Goater
2021-12-15 17:03 ` [PULL 045/102] target/ppc: Update fre " Cédric Le Goater
2021-12-15 17:03 ` [PULL 046/102] softfloat: Add float64r32 arithmetic routines Cédric Le Goater
2021-12-15 17:03 ` [PULL 047/102] target/ppc: Add helpers for fmadds et al Cédric Le Goater
2021-12-15 17:03 ` [PULL 048/102] target/ppc: Add helper for fsqrts Cédric Le Goater
2021-12-15 17:03 ` [PULL 049/102] target/ppc: Add helpers for fadds, fsubs, fdivs Cédric Le Goater
2021-12-15 17:03 ` [PULL 050/102] target/ppc: Add helper for fmuls Cédric Le Goater
2021-12-15 17:03 ` [PULL 051/102] target/ppc: Add helper for frsqrtes Cédric Le Goater
2021-12-15 17:03 ` [PULL 052/102] target/ppc: Update fres to new flags and float64r32 Cédric Le Goater
2021-12-15 17:03 ` [PULL 053/102] target/ppc: Use helper_todouble/tosingle in helper_xststdcsp Cédric Le Goater
2021-12-15 17:03 ` [PULL 054/102] target/ppc: Disable software TLB for the 7450 family Cédric Le Goater
2021-12-15 17:03 ` [PULL 055/102] target/ppc: Disable unused facilities in the e600 CPU Cédric Le Goater
2021-12-15 17:03 ` [PULL 056/102] target/ppc: Remove the software TLB model of 7450 CPUs Cédric Le Goater
2021-12-15 17:03 ` [PULL 057/102] target/ppc: Fix MPCxxx FPU interrupt address Cédric Le Goater
2021-12-15 17:03 ` [PULL 058/102] target/ppc: Remove 603e exception model Cédric Le Goater
2021-12-15 17:03 ` [PULL 059/102] target/ppc: Set 601v exception model id Cédric Le Goater
2021-12-15 17:03 ` [PULL 060/102] target/ppc: remove 401/403 CPUs Cédric Le Goater
2021-12-15 17:03 ` [PULL 061/102] ppc/ppc405: Change kernel load address Cédric Le Goater
2021-12-15 17:03 ` [PULL 062/102] ppc: Mark the 'taihu' machine as deprecated Cédric Le Goater
2021-12-15 17:03 ` [PULL 063/102] ppc: Add trace-events for DCR accesses Cédric Le Goater
2021-12-15 17:03 ` [PULL 064/102] ppc/ppc405: Convert printfs to trace-events Cédric Le Goater
2021-12-15 17:03 ` Cédric Le Goater [this message]
2021-12-15 17:03 ` [PULL 066/102] ppc/ppc405: Change ppc405ep_init() return value Cédric Le Goater
2021-12-15 17:03 ` [PULL 067/102] ppc/ppc405: Add some address space definitions Cédric Le Goater
2021-12-15 17:03 ` [PULL 068/102] ppc/ppc405: Remove flash support Cédric Le Goater
2021-12-15 17:03 ` [PULL 069/102] ppc/ppc405: Rework FW load Cédric Le Goater
2021-12-15 17:03 ` [PULL 070/102] ppc/ppc405: Introduce ppc405_set_default_bootinfo() Cédric Le Goater
2021-12-15 17:03 ` [PULL 071/102] ppc/ppc405: Fix boot from kernel Cédric Le Goater
2021-12-15 17:03 ` [PULL 072/102] ppc/ppc405: Change default PLL values at reset Cédric Le Goater
2021-12-15 17:03 ` [PULL 073/102] ppc/ppc405: Fix bi_pci_enetaddr2 field in U-Boot board information Cédric Le Goater
2021-12-15 17:03 ` [PULL 074/102] ppc/ppc405: Add update of bi_procfreq field Cédric Le Goater
2021-12-15 17:03 ` [PULL 075/102] target/ppc: Fix xs{max, min}[cj]dp to use VSX registers Cédric Le Goater
2021-12-15 17:03 ` [PULL 076/102] target/ppc: Move xs{max,min}[cj]dp to decodetree Cédric Le Goater
2021-12-15 17:03 ` [PULL 077/102] target/ppc: fix xscvqpdp register access Cédric Le Goater
2021-12-15 17:03 ` [PULL 078/102] target/ppc: move xscvqpdp to decodetree Cédric Le Goater
2021-12-15 17:03 ` [PULL 079/102] target/ppc: Fix e6500 boot Cédric Le Goater
2021-12-15 17:03 ` [PULL 080/102] Revert "target/ppc: Move SPR_DSISR setting to powerpc_excp" Cédric Le Goater
2021-12-15 17:03 ` [PULL 081/102] target/ppc: do not silence SNaN in xscvspdpn Cédric Le Goater
2021-12-15 17:03 ` [PULL 082/102] target/ppc: introduce PMUEventType and PMU overflow timers Cédric Le Goater
2021-12-15 17:03 ` [PULL 083/102] target/ppc: PMU basic cycle count for pseries TCG Cédric Le Goater
2021-12-15 17:03 ` [PULL 084/102] target/ppc: PMU: update counters on PMCs r/w Cédric Le Goater
2021-12-15 17:03 ` [PULL 085/102] target/ppc: PMU: update counters on MMCR1 write Cédric Le Goater
2021-12-15 17:03 ` [PULL 086/102] target/ppc: enable PMU counter overflow with cycle events Cédric Le Goater
2021-12-15 17:03 ` [PULL 087/102] target/ppc: enable PMU instruction count Cédric Le Goater
2021-12-15 17:03 ` [PULL 088/102] target/ppc/power8-pmu.c: add PM_RUN_INST_CMPL (0xFA) event Cédric Le Goater
2021-12-15 17:03 ` [PULL 089/102] PPC64/TCG: Implement 'rfebb' instruction Cédric Le Goater
2021-12-15 17:03 ` [PULL 090/102] ppc/pnv: Introduce a "chip" property under PHB3 Cédric Le Goater
2021-12-15 17:03 ` [PULL 091/102] ppc/pnv: Use the chip class to check the index of PHB3 devices Cédric Le Goater
2021-12-15 17:03 ` [PULL 092/102] ppc/pnv: Drop the "num-phbs" property Cédric Le Goater
2021-12-15 17:03 ` [PULL 093/102] ppc/pnv: Move mapping of the PHB3 CQ regions under pnv_pbcq_realize() Cédric Le Goater
2021-12-15 17:03 ` [PULL 094/102] ppc/pnv: Use QOM hierarchy to scan PHB3 devices Cédric Le Goater
2021-12-15 17:03 ` [PULL 095/102] ppc/pnv: Introduce a num_pecs class attribute for PHB4 PEC devices Cédric Le Goater
2021-12-15 17:03 ` [PULL 096/102] ppc/pnv: Introduce version and device_id class atributes for PHB4 devices Cédric Le Goater
2021-12-15 17:03 ` [PULL 097/102] ppc/pnv: Introduce a "chip" property under the PHB4 model Cédric Le Goater
2021-12-15 17:03 ` [PULL 098/102] ppc/pnv: Introduce a num_stack class attribute Cédric Le Goater
2021-12-15 17:03 ` [PULL 099/102] ppc/pnv: Compute the PHB index from the PHB4 PEC model Cédric Le Goater
2021-12-15 17:03 ` [PULL 100/102] ppc/pnv: Remove "system-memory" property from PHB4 PEC Cédric Le Goater
2021-12-15 17:03 ` [PULL 101/102] ppc/pnv: Move realize of PEC stacks under the PEC model Cédric Le Goater
2021-12-15 17:03 ` [PULL 102/102] ppc/pnv: Use QOM hierarchy to scan PEC PHB4 devices Cédric Le Goater
2021-12-16 3:53 ` [PULL 000/102] ppc queue Richard Henderson
2021-12-16 6:18 ` Cédric Le Goater
2021-12-16 7:02 ` Cédric Le Goater
2021-12-16 12:21 ` Richard Henderson
2021-12-16 17:51 ` Cédric Le Goater
2021-12-16 18:18 ` Richard Henderson
2021-12-16 19:18 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211215170357.321643-53-clg@kaod.org \
--to=clg@kaod.org \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).