From: Raphael Norwitz <raphael.norwitz@nutanix.com>
To: "stefanha@redhat.com" <stefanha@redhat.com>,
"marcandre.lureau@redhat.com" <marcandre.lureau@redhat.com>,
"mst@redhat.com" <mst@redhat.com>,
"david@redhat.com" <david@redhat.com>
Cc: "raphael.s.norwitz@gmail.com" <raphael.s.norwitz@gmail.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Raphael Norwitz <raphael.norwitz@nutanix.com>
Subject: [RFC 1/5] libvhost-user: Add vu_rem_mem_reg input validation
Date: Wed, 15 Dec 2021 22:29:48 +0000 [thread overview]
Message-ID: <20211215222939.24738-2-raphael.norwitz@nutanix.com> (raw)
In-Reply-To: <20211215222939.24738-1-raphael.norwitz@nutanix.com>
Signed-off-by: Raphael Norwitz <raphael.norwitz@nutanix.com>
---
subprojects/libvhost-user/libvhost-user.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/subprojects/libvhost-user/libvhost-user.c b/subprojects/libvhost-user/libvhost-user.c
index 787f4d2d4f..573212a83b 100644
--- a/subprojects/libvhost-user/libvhost-user.c
+++ b/subprojects/libvhost-user/libvhost-user.c
@@ -801,6 +801,12 @@ vu_rem_mem_reg(VuDev *dev, VhostUserMsg *vmsg) {
VuDevRegion shadow_regions[VHOST_USER_MAX_RAM_SLOTS] = {};
VhostUserMemoryRegion m = vmsg->payload.memreg.region, *msg_region = &m;
+ if (vmsg->fd_num != 1 ||
+ vmsg->size != sizeof(vmsg->payload.memreg)) {
+ vu_panic(dev, "VHOST_USER_REM_MEM_REG received multiple regions");
+ return true;
+ }
+
DPRINT("Removing region:\n");
DPRINT(" guest_phys_addr: 0x%016"PRIx64"\n",
msg_region->guest_phys_addr);
--
2.20.1
next prev parent reply other threads:[~2021-12-15 22:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 22:29 [RFC 0/5] Clean up error handling in libvhost-user memory mapping Raphael Norwitz
2021-12-15 22:29 ` Raphael Norwitz [this message]
2022-01-05 11:00 ` [RFC 1/5] libvhost-user: Add vu_rem_mem_reg input validation Stefan Hajnoczi
2022-01-06 5:13 ` Raphael Norwitz
2021-12-15 22:29 ` [RFC 2/5] libvhost-user: Add vu_add_mem_reg " Raphael Norwitz
2022-01-05 11:02 ` Stefan Hajnoczi
2021-12-15 22:29 ` [RFC 3/5] libvhost-user: Simplify VHOST_USER_REM_MEM_REG Raphael Norwitz
2022-01-05 11:04 ` Stefan Hajnoczi
2021-12-15 22:29 ` [RFC 4/5] libvhost-user: prevent over-running max RAM slots Raphael Norwitz
2022-01-05 11:06 ` Stefan Hajnoczi
2021-12-15 22:29 ` [RFC 5/5] libvhost-user: handle removal of identical regions Raphael Norwitz
2022-01-05 11:18 ` Stefan Hajnoczi
2022-01-06 5:36 ` Raphael Norwitz
2022-01-04 15:46 ` [RFC 0/5] Clean up error handling in libvhost-user memory mapping Raphael Norwitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211215222939.24738-2-raphael.norwitz@nutanix.com \
--to=raphael.norwitz@nutanix.com \
--cc=david@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=raphael.s.norwitz@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).