From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1128C433EF for ; Fri, 17 Dec 2021 14:09:45 +0000 (UTC) Received: from localhost ([::1]:54292 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1myDvc-0002oZ-Oc for qemu-devel@archiver.kernel.org; Fri, 17 Dec 2021 09:09:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56638) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myDkg-00060w-8g; Fri, 17 Dec 2021 08:58:28 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:5928) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myDke-00022q-Df; Fri, 17 Dec 2021 08:58:25 -0500 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1BHDl6nq001490; Fri, 17 Dec 2021 13:58:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=pp1; bh=/ZVsOXU08DXL7kixcc8XhBjKUALBL3BSBeVVTDwRy+o=; b=o1UMP0f/17+ZaKb8Qw/CBy4PtKwITAOIieKTYsVjFdT1kCRGUCLX+Xhlb5sh6swf5xg+ VleHHKS4D3jfdGIoxCI4FP49jxZOtU5ZfVtoB5vaPxaOIisfrRaK3BRcMVmSQOREU3BL PmKPlHym/Oolbgh27st1KIiKN8cb7duZz9fCyegYlG3qjHRQFluLblHC/aUnZVu0uxaa TFpFt1wVgLZWUl1Jk2gebSPa/VtmvlzI4Vm9FWc5X/7OsHEJIce9CVunOeuGeBWp5wfa 9egfM+wPnIjH+MDcDcOPQiw/3NGSlkT3S6QGoyU5rnG60SkpLfPB2DVV9PTQWp225gcg dA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3d0j1vku4m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Dec 2021 13:58:20 +0000 Received: from m0098393.ppops.net (m0098393.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 1BHDi2qm001385; Fri, 17 Dec 2021 13:58:19 GMT Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 3d0j1vku3y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Dec 2021 13:58:19 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 1BHDRVbK010792; Fri, 17 Dec 2021 13:58:17 GMT Received: from b06avi18626390.portsmouth.uk.ibm.com (b06avi18626390.portsmouth.uk.ibm.com [9.149.26.192]) by ppma03ams.nl.ibm.com with ESMTP id 3cy7jrj01p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Dec 2021 13:58:17 +0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 1BHDoAQx41025846 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 17 Dec 2021 13:50:10 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 56C8B11C04C; Fri, 17 Dec 2021 13:58:14 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D607A11C054; Fri, 17 Dec 2021 13:58:13 +0000 (GMT) Received: from li-e979b1cc-23ba-11b2-a85c-dfd230f6cf82 (unknown [9.171.63.32]) by d06av25.portsmouth.uk.ibm.com (Postfix) with SMTP; Fri, 17 Dec 2021 13:58:13 +0000 (GMT) Date: Fri, 17 Dec 2021 14:58:11 +0100 From: Halil Pasic To: Nico Boehr Subject: Re: [PATCH qemu] s390x/css: fix PMCW invalid mask Message-ID: <20211217145811.71dd0a70.pasic@linux.ibm.com> In-Reply-To: <20211216131657.1057978-1-nrb@linux.ibm.com> References: <20211216131657.1057978-1-nrb@linux.ibm.com> Organization: IBM X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: gDZKRYKXDD4W5HaCGcafpI-0bFQhOFo4 X-Proofpoint-ORIG-GUID: B7S-jEZbzTWLHVVT9VBZIVGMob--nVIg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2021-12-17_05,2021-12-16_01,2021-12-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxlogscore=999 clxscore=1011 suspectscore=0 spamscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 mlxscore=0 impostorscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2112170076 Received-SPF: pass client-ip=148.163.156.1; envelope-from=pasic@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, frankja@linux.ibm.com, pmorel@linux.ibm.com, cohuck@redhat.com, qemu-devel@nongnu.org, Halil Pasic , borntraeger@de.ibm.com, qemu-s390x@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 16 Dec 2021 14:16:57 +0100 Nico Boehr wrote: > Previously, we required bits 5, 6 and 7 to be zero (0x07 == 0b111). But, > as per the principles of operation, bit 5 is ignored in MSCH and bits 0, > 1, 6 and 7 need to be zero. On a second thought, don't we have to make sure then that bit 5 is ignored? static void copy_pmcw_from_guest(PMCW *dest, const PMCW *src) { int i; dest->intparm = be32_to_cpu(src->intparm); dest->flags = be16_to_cpu(src->flags); dest->devno = be16_to_cpu(src->devno); Here we seem to grab flags as a whole, but actually we would have to mask of bit 5. I can spin a patch myself, provided we agree on that this needs to be fixed, but, it would probably be better to have the two changes in one patch. Regards, Halil > > As both PMCW_FLAGS_MASK_INVALID and ioinst_schib_valid() are only used > by ioinst_handle_msch(), adjust the mask accordingly. > > Fixes: db1c8f53bfb1 ("s390: Channel I/O basic definitions.") > Signed-off-by: Nico Boehr > Reviewed-by: Pierre Morel > Reviewed-by: Halil Pasic > Reviewed-by: Janosch Frank