From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, "Michael Rolnik" <mrolnik@gmail.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Laurent Vivier" <laurent@vivier.eu>
Subject: [PULL 4/9] hw/avr: Realize AVRCPU qdev object using qdev_realize()
Date: Fri, 17 Dec 2021 21:10:14 +0100 [thread overview]
Message-ID: <20211217201019.1652798-5-laurent@vivier.eu> (raw)
In-Reply-To: <20211217201019.1652798-1-laurent@vivier.eu>
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
TYPE_AVR_CPU inherits TYPE_CPU, which itself inherits TYPE_DEVICE.
TYPE_DEVICE instances are realized using qdev_realize(), we don't
need to access QOM internal values.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Michael Rolnik <mrolnik@gmail.com>
Message-Id: <20211205224109.322152-1-f4bug@amsat.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/avr/atmega.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/avr/atmega.c b/hw/avr/atmega.c
index 0608e2d475ee..a34803e64272 100644
--- a/hw/avr/atmega.c
+++ b/hw/avr/atmega.c
@@ -233,7 +233,7 @@ static void atmega_realize(DeviceState *dev, Error **errp)
/* CPU */
object_initialize_child(OBJECT(dev), "cpu", &s->cpu, mc->cpu_type);
- object_property_set_bool(OBJECT(&s->cpu), "realized", true, &error_abort);
+ qdev_realize(DEVICE(&s->cpu), NULL, &error_abort);
cpudev = DEVICE(&s->cpu);
/* SRAM */
--
2.33.1
next prev parent reply other threads:[~2021-12-17 20:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 20:10 [PULL 0/9] Trivial branch for 7.0 patches Laurent Vivier
2021-12-17 20:10 ` [PULL 1/9] configure: Symlink binaries using .exe suffix with MinGW Laurent Vivier
2021-12-17 20:10 ` [PULL 2/9] target/i386/kvm: Replace use of __u32 type Laurent Vivier
2021-12-17 20:10 ` [PULL 3/9] qemu-keymap: Add license in generated files Laurent Vivier
2021-12-17 20:10 ` Laurent Vivier [this message]
2021-12-17 20:10 ` [PULL 5/9] hw/virtio/vhost: Fix typo in comment Laurent Vivier
2021-12-17 20:10 ` [PULL 6/9] docs/block-replication.txt: Fix replication top-id command demo Laurent Vivier
2021-12-17 20:10 ` [PULL 7/9] glib-compat: Introduce g_memdup2() wrapper Laurent Vivier
2021-12-17 20:10 ` [PULL 8/9] tests/qtest: Replace g_memdup() by g_memdup2() Laurent Vivier
2021-12-17 20:10 ` [PULL 9/9] checkpatch: Do not allow deprecated g_memdup() Laurent Vivier
2021-12-18 2:04 ` [PULL 0/9] Trivial branch for 7.0 patches Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211217201019.1652798-5-laurent@vivier.eu \
--to=laurent@vivier.eu \
--cc=f4bug@amsat.org \
--cc=mrolnik@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).