From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Zhang Chen <chen.zhang@intel.com>,
Laurent Vivier <laurent@vivier.eu>
Subject: [PULL 6/9] docs/block-replication.txt: Fix replication top-id command demo
Date: Fri, 17 Dec 2021 21:10:16 +0100 [thread overview]
Message-ID: <20211217201019.1652798-7-laurent@vivier.eu> (raw)
In-Reply-To: <20211217201019.1652798-1-laurent@vivier.eu>
From: Zhang Chen <chen.zhang@intel.com>
This demo not correct, the original childs1 can't pass the
the bdrv_is_root_node check in replcation_start().
Keep consistent with docs/COLO-FT.txt
Signed-off-by: Zhang Chen <chen.zhang@intel.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20211018085044.2788276-1-chen.zhang@intel.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
docs/block-replication.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/block-replication.txt b/docs/block-replication.txt
index b0f23761c6e7..e1b28a6cc117 100644
--- a/docs/block-replication.txt
+++ b/docs/block-replication.txt
@@ -179,7 +179,7 @@ Primary:
Secondary:
-drive if=none,driver=raw,file.filename=1.raw,id=colo1 \
- -drive if=none,id=childs1,driver=replication,mode=secondary,top-id=childs1
+ -drive if=none,id=childs1,driver=replication,mode=secondary,top-id=top-disk1
file.file.filename=active_disk.qcow2,\
file.driver=qcow2,\
file.backing.file.filename=hidden_disk.qcow2,\
--
2.33.1
next prev parent reply other threads:[~2021-12-17 20:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 20:10 [PULL 0/9] Trivial branch for 7.0 patches Laurent Vivier
2021-12-17 20:10 ` [PULL 1/9] configure: Symlink binaries using .exe suffix with MinGW Laurent Vivier
2021-12-17 20:10 ` [PULL 2/9] target/i386/kvm: Replace use of __u32 type Laurent Vivier
2021-12-17 20:10 ` [PULL 3/9] qemu-keymap: Add license in generated files Laurent Vivier
2021-12-17 20:10 ` [PULL 4/9] hw/avr: Realize AVRCPU qdev object using qdev_realize() Laurent Vivier
2021-12-17 20:10 ` [PULL 5/9] hw/virtio/vhost: Fix typo in comment Laurent Vivier
2021-12-17 20:10 ` Laurent Vivier [this message]
2021-12-17 20:10 ` [PULL 7/9] glib-compat: Introduce g_memdup2() wrapper Laurent Vivier
2021-12-17 20:10 ` [PULL 8/9] tests/qtest: Replace g_memdup() by g_memdup2() Laurent Vivier
2021-12-17 20:10 ` [PULL 9/9] checkpatch: Do not allow deprecated g_memdup() Laurent Vivier
2021-12-18 2:04 ` [PULL 0/9] Trivial branch for 7.0 patches Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211217201019.1652798-7-laurent@vivier.eu \
--to=laurent@vivier.eu \
--cc=chen.zhang@intel.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).