From: Patrick Venture <venture@google.com>
To: cminyard@mvista.com
Cc: qemu-devel@nongnu.org, Patrick Venture <venture@google.com>
Subject: [PATCH] hw/nvram: at24 return 0xff if 1 byte address
Date: Sun, 19 Dec 2021 16:32:40 -0800 [thread overview]
Message-ID: <20211220003240.1081986-1-venture@google.com> (raw)
The at24 eeproms are 2 byte devices that return 0xff when they are read
from with a partial (1-byte) address written. This distinction was
found comparing model behavior to real hardware testing.
Tested: `i2ctransfer -f -y 45 w1@85 0 r1` returns 0xff instead of next
byte
Signed-off-by: Patrick Venture <venture@google.com>
---
hw/nvram/eeprom_at24c.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/hw/nvram/eeprom_at24c.c b/hw/nvram/eeprom_at24c.c
index a9e3702b00..184fac9702 100644
--- a/hw/nvram/eeprom_at24c.c
+++ b/hw/nvram/eeprom_at24c.c
@@ -62,7 +62,9 @@ int at24c_eeprom_event(I2CSlave *s, enum i2c_event event)
case I2C_START_SEND:
case I2C_START_RECV:
case I2C_FINISH:
- ee->haveaddr = 0;
+ if (event != I2C_START_RECV) {
+ ee->haveaddr = 0;
+ }
DPRINTK("clear\n");
if (ee->blk && ee->changed) {
int len = blk_pwrite(ee->blk, 0, ee->mem, ee->rsize, 0);
@@ -86,6 +88,10 @@ uint8_t at24c_eeprom_recv(I2CSlave *s)
EEPROMState *ee = AT24C_EE(s);
uint8_t ret;
+ if (ee->haveaddr == 1) {
+ return 0xff;
+ }
+
ret = ee->mem[ee->cur];
ee->cur = (ee->cur + 1u) % ee->rsize;
--
2.34.1.173.g76aa8bc2d0-goog
next reply other threads:[~2021-12-20 0:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 0:32 Patrick Venture [this message]
2021-12-20 9:12 ` [PATCH] hw/nvram: at24 return 0xff if 1 byte address Philippe Mathieu-Daudé
2021-12-20 15:32 ` Patrick Venture
2021-12-20 16:43 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211220003240.1081986-1-venture@google.com \
--to=venture@google.com \
--cc=cminyard@mvista.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).