From: Hanna Reitz <hreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>,
qemu-devel@nongnu.org
Subject: [PATCH 0/3] qsd: Add --daemonize; and add job quit tests
Date: Wed, 22 Dec 2021 12:41:50 +0100 [thread overview]
Message-ID: <20211222114153.67721-1-hreitz@redhat.com> (raw)
Hi,
This series began as an attempt to write a reproducer for the following
case:
You have a mirror job in READY state with a target that’s slow. There
is still a lot of data to be written (because of active I/O in the
guest). You quit qemu, and you expect quitting to be reasonably
quick.
Old qemu used to still complete the job, which may take forever, new
qemu cancels the job, which is better.
That’s basically patch 3 in this series, which tests this behavior once
for mirror and once for active commit.
Problem is, how to simulate a slow target for this; if you use a
throttle node in the same qemu process that you’re trying to test, qemu
will just drain it when quitting, and so the supposedly slow target
becomes very fast.
So we need an external instance, and what better to use but the storage
daemon. I found that it would be nice if for this it had a --daemonize
option (well, it would be nice in general), and so the first two patches
implement that.
Hanna Reitz (3):
qsd: Add pre-init argument parsing pass
qsd: Add --daemonize
iotests/185: Add post-READY quit tests
docs/tools/qemu-storage-daemon.rst | 7 +
storage-daemon/qemu-storage-daemon.c | 188 +++++++++++++++++++++++++-
tests/qemu-iotests/185 | 190 ++++++++++++++++++++++++++-
tests/qemu-iotests/185.out | 48 +++++++
4 files changed, 430 insertions(+), 3 deletions(-)
--
2.33.1
next reply other threads:[~2021-12-22 11:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 11:41 Hanna Reitz [this message]
2021-12-22 11:41 ` [PATCH 1/3] qsd: Add pre-init argument parsing pass Hanna Reitz
2021-12-30 16:00 ` Vladimir Sementsov-Ogievskiy
2022-01-03 16:14 ` Hanna Reitz
2022-01-19 12:58 ` Markus Armbruster
2022-01-19 13:44 ` Hanna Reitz
2022-01-19 17:21 ` Kevin Wolf
2022-01-20 16:00 ` Markus Armbruster
2022-01-20 16:31 ` Hanna Reitz
2022-01-21 6:10 ` Markus Armbruster
2022-01-21 8:43 ` Hanna Reitz
2022-01-21 10:27 ` Markus Armbruster
2022-01-21 11:16 ` Hanna Reitz
2022-01-21 14:26 ` Markus Armbruster
2022-01-24 8:20 ` Hanna Reitz
2022-01-24 9:23 ` Markus Armbruster
2022-01-24 9:34 ` Hanna Reitz
2021-12-22 11:41 ` [PATCH 2/3] qsd: Add --daemonize Hanna Reitz
2021-12-30 16:12 ` Vladimir Sementsov-Ogievskiy
2022-01-03 17:15 ` Hanna Reitz
2021-12-22 11:41 ` [PATCH 3/3] iotests/185: Add post-READY quit tests Hanna Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211222114153.67721-1-hreitz@redhat.com \
--to=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).