From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: qemu-devel@nongnu.org
Cc: richard.henderson@linaro.org,
Daniel Henrique Barboza <danielhb413@gmail.com>,
qemu-ppc@nongnu.org, clg@kaod.org, david@gibson.dropbear.id.au
Subject: [PATCH v2 3/5] target/ppc/power8-pmu-insn-cnt: add PMCs1-4 insn count
Date: Thu, 23 Dec 2021 17:18:10 -0300 [thread overview]
Message-ID: <20211223201812.846495-4-danielhb413@gmail.com> (raw)
In-Reply-To: <20211223201812.846495-1-danielhb413@gmail.com>
Use inc_spr_if_cond() to count instructions of all other PMCs that are
capable of counting instructions (all PMCs but PMC6).
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---
target/ppc/power8-pmu-insn-cnt.c.inc | 62 ++++++++++++++++++++++++++++
1 file changed, 62 insertions(+)
diff --git a/target/ppc/power8-pmu-insn-cnt.c.inc b/target/ppc/power8-pmu-insn-cnt.c.inc
index 3cfb801c69..a5a0d42e71 100644
--- a/target/ppc/power8-pmu-insn-cnt.c.inc
+++ b/target/ppc/power8-pmu-insn-cnt.c.inc
@@ -11,6 +11,13 @@
*/
#if defined(TARGET_PPC64) && !defined(CONFIG_USER_ONLY)
+#define MMCR1_PMC1_INS_CNT 0x02000000
+#define MMCR1_PMC1_INS_CNT2 0xFE000000
+#define MMCR1_PMC2_INS_CNT 0x00020000
+#define MMCR1_PMC3_INS_CNT 0x00000200
+#define MMCR1_PMC4_INS_CNT 0x00000002
+#define MMCR1_PMC4_INS_LATCH_CNT 0x000000FA
+
/*
* This function increments a SPR 'spr' by 'inc_val' if a given
* register 'reg' has a bitmask 'mask' set (cond = TCG_COND_EQ) or
@@ -54,8 +61,63 @@ static void pmu_count_insns(DisasContext *ctx)
}
#if !defined(CONFIG_USER_ONLY)
+ TCGv t_mmcr0, t_mmcr1, t_ctrl;
+ TCGLabel *l_skip_pmc14;
+
inc_spr_if_cond(SPR_POWER_MMCR0, MMCR0_FC56, TCG_COND_NE,
SPR_POWER_PMC5, ctx->base.num_insns);
+
+ /*
+ * Skip PMC1-4 increment if:
+ * - MMCR0_FC14 is set OR
+ * - MMCR1 is cleared
+ */
+ l_skip_pmc14 = gen_new_label();
+
+ t_mmcr0 = tcg_temp_new();
+ gen_load_spr(t_mmcr0, SPR_POWER_MMCR0);
+ tcg_gen_andi_tl(t_mmcr0, t_mmcr0, MMCR0_FC14);
+ tcg_gen_brcondi_tl(TCG_COND_EQ, t_mmcr0, MMCR0_FC14, l_skip_pmc14);
+
+ t_mmcr1 = tcg_temp_new();
+ gen_load_spr(t_mmcr1, SPR_POWER_MMCR1);
+ tcg_gen_brcondi_tl(TCG_COND_EQ, t_mmcr1, 0x0, l_skip_pmc14);
+
+ /* PMC1 is incremented if PMC1SEL = 0x02 or 0xFE */
+ inc_spr_if_cond(SPR_POWER_MMCR1, MMCR1_PMC1_INS_CNT, TCG_COND_EQ,
+ SPR_POWER_PMC1, ctx->base.num_insns);
+ inc_spr_if_cond(SPR_POWER_MMCR1, MMCR1_PMC1_INS_CNT2, TCG_COND_EQ,
+ SPR_POWER_PMC1, ctx->base.num_insns);
+
+ /* PMC2 is incremented if PMC2SEL = 0x02 */
+ inc_spr_if_cond(SPR_POWER_MMCR1, MMCR1_PMC2_INS_CNT, TCG_COND_EQ,
+ SPR_POWER_PMC2, ctx->base.num_insns);
+
+ /* PMC3 is incremented if PMC3SEL = 0x02 */
+ inc_spr_if_cond(SPR_POWER_MMCR1, MMCR1_PMC3_INS_CNT, TCG_COND_EQ,
+ SPR_POWER_PMC3, ctx->base.num_insns);
+
+ /*
+ * PMC4 is incremented if PMC4SEL = 0x02 or 0xFA. 0xFA depends on the
+ * run latch (SPR_CTRL & CTRL_RUN). Check for the run latch before
+ * checking for PMC4SEL = 0xFA.
+ */
+ inc_spr_if_cond(SPR_POWER_MMCR1, MMCR1_PMC4_INS_CNT, TCG_COND_EQ,
+ SPR_POWER_PMC4, ctx->base.num_insns);
+
+ t_ctrl = tcg_temp_new();
+ gen_load_spr(t_ctrl, SPR_CTRL);
+ tcg_gen_andi_tl(t_ctrl, t_ctrl, CTRL_RUN);
+ tcg_gen_brcondi_tl(TCG_COND_NE, t_ctrl, CTRL_RUN, l_skip_pmc14);
+
+ inc_spr_if_cond(SPR_POWER_MMCR1, MMCR1_PMC4_INS_LATCH_CNT, TCG_COND_EQ,
+ SPR_POWER_PMC4, ctx->base.num_insns);
+
+ gen_set_label(l_skip_pmc14);
+
+ tcg_temp_free(t_mmcr0);
+ tcg_temp_free(t_mmcr1);
+ tcg_temp_free(t_ctrl);
#else
/*
* User mode can read (but not write) PMC5 and start/stop
--
2.33.1
next prev parent reply other threads:[~2021-12-23 20:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 20:18 [PATCH v2 0/5] Re-write PPC64 PMU instruction count using TCG Ops Daniel Henrique Barboza
2021-12-23 20:18 ` [PATCH v2 1/5] target/ppc: introduce power8-pmu-insn-cnt.c.inc Daniel Henrique Barboza
2021-12-23 20:18 ` [PATCH v2 2/5] target/ppc/power8-pmu-insn-cnt: introduce inc_spr_if_cond() Daniel Henrique Barboza
2021-12-23 21:14 ` Richard Henderson
2021-12-23 20:18 ` Daniel Henrique Barboza [this message]
2021-12-23 20:18 ` [PATCH v2 4/5] target/ppc/power8-pmu-insn-cnt: add pmu_check_overflow() Daniel Henrique Barboza
2021-12-23 20:18 ` [PATCH v2 5/5] target/ppc/power8-pmu.c: remove helper_insns_inc() Daniel Henrique Barboza
2022-01-03 6:46 ` [PATCH v2 0/5] Re-write PPC64 PMU instruction count using TCG Ops Cédric Le Goater
2022-01-03 18:14 ` Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211223201812.846495-4-danielhb413@gmail.com \
--to=danielhb413@gmail.com \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).