From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: dlenski@gmail.com, mst@redhat.com
Subject: [PATCH 0/4] Fix -acpitable regression
Date: Mon, 27 Dec 2021 14:31:16 -0500 [thread overview]
Message-ID: <20211227193120.1084176-1-imammedo@redhat.com> (raw)
Since 6.2 QEMU will assert when SLIC table is passed with
help of -acpitable. This series fixes the issue and adds a test
case for it.
PS: gitlab whining:
* the issue was reported and ivestigated via shiny gitlab issue tracker,
the problem is that all that discussion is buried there and is not stored
in qemu-devel mail list. So when gitlab is gone, so will be all the history
and one won't have (nicely and locally stored) mail archive to search in
a convenient way.
Also I'd notice the report earlier if it were forwarded to qemu-devel.
I wonder if there is a way to bridge issue tracker discussions to mail list?
* another issue is that gitlab hides user's emails, with a bit of detective work
one can find email if the user has committed a patch via gitlab, but that doesn't
work for every user. So I can't CC/properly credit reporter when posting formal
patch.
CC: dlenski@gmail.com
CC: mst@redhat.com
Igor Mammedov (4):
acpi: fix QEMU crash when started with SLIC table
tests: acpi: whitelist expected blobs before changing them
tests: acpi: add SLIC table test
tests: acpi: SLIC: update expected blobs
hw/acpi/core.c | 4 ++--
hw/i386/acpi-build.c | 2 ++
tests/data/acpi/q35/FACP.slic | Bin 0 -> 244 bytes
tests/data/acpi/q35/SLIC.slic | Bin 0 -> 36 bytes
tests/qtest/bios-tables-test.c | 15 +++++++++++++++
5 files changed, 19 insertions(+), 2 deletions(-)
create mode 100644 tests/data/acpi/q35/FACP.slic
create mode 100644 tests/data/acpi/q35/SLIC.slic
--
2.31.1
next reply other threads:[~2021-12-27 19:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-27 19:31 Igor Mammedov [this message]
2021-12-27 19:31 ` [PATCH 1/4] acpi: fix QEMU crash when started with SLIC table Igor Mammedov
2021-12-27 21:26 ` Philippe Mathieu-Daudé
2021-12-28 14:25 ` Denis Lisov
2021-12-30 22:30 ` Alexander Tsoy
2022-01-03 7:15 ` Igor Mammedov
2021-12-27 19:31 ` [PATCH 2/4] tests: acpi: whitelist expected blobs before changing them Igor Mammedov
2021-12-27 19:31 ` [PATCH 3/4] tests: acpi: add SLIC table test Igor Mammedov
2021-12-27 19:31 ` [PATCH 4/4] tests: acpi: SLIC: update expected blobs Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211227193120.1084176-1-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=dlenski@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).