qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, hreitz@redhat.com,
	richard.henderson@linaro.org, peter.maydell@linaro.org,
	vsementsov@virtuozzo.com, jsnow@redhat.com,
	"Emanuele Giuseppe Esposito" <eesposit@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: [PULL 1/6] job.c: add missing notifier initialization
Date: Wed, 29 Dec 2021 20:21:22 +0100	[thread overview]
Message-ID: <20211229192127.1772134-2-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20211229192127.1772134-1-vsementsov@virtuozzo.com>

From: Emanuele Giuseppe Esposito <eesposit@redhat.com>

It seems that on_idle list is not properly initialized like
the other notifiers.

Fixes: 34dc97b9a0e ("blockjob: Wake up BDS when job becomes idle")
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 job.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/job.c b/job.c
index dbfa67bb0a..54db80df66 100644
--- a/job.c
+++ b/job.c
@@ -352,6 +352,7 @@ void *job_create(const char *job_id, const JobDriver *driver, JobTxn *txn,
     notifier_list_init(&job->on_finalize_completed);
     notifier_list_init(&job->on_pending);
     notifier_list_init(&job->on_ready);
+    notifier_list_init(&job->on_idle);
 
     job_state_transition(job, JOB_STATUS_CREATED);
     aio_timer_init(qemu_get_aio_context(), &job->sleep_timer,
-- 
2.31.1



  reply	other threads:[~2021-12-29 19:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-29 19:21 [PULL 0/6] Block jobs patches Vladimir Sementsov-Ogievskiy
2021-12-29 19:21 ` Vladimir Sementsov-Ogievskiy [this message]
2021-12-29 19:21 ` [PULL 2/6] blockjob: implement and use block_job_get_aio_context Vladimir Sementsov-Ogievskiy
2021-12-29 19:21 ` [PULL 3/6] test-blockjob-txn: don't abuse job->blk Vladimir Sementsov-Ogievskiy
2021-12-29 19:21 ` [PULL 4/6] block/stream: add own blk Vladimir Sementsov-Ogievskiy
2021-12-29 19:21 ` [PULL 5/6] test-bdrv-drain: don't use BlockJob.blk Vladimir Sementsov-Ogievskiy
2021-12-29 19:21 ` [PULL 6/6] blockjob: drop BlockJob.blk field Vladimir Sementsov-Ogievskiy
2021-12-29 23:50 ` [PULL 0/6] Block jobs patches Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211229192127.1772134-2-vsementsov@virtuozzo.com \
    --to=vsementsov@virtuozzo.com \
    --cc=eesposit@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).