From: Zhang Chen <chen.zhang@intel.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Juan Quintela <quintela@redhat.com>,
qemu-dev <qemu-devel@nongnu.org>
Cc: Zhang Chen <chen.zhang@intel.com>
Subject: [PATCH 1/3] migration/migration.c: Add missed default error handler for migration state
Date: Fri, 31 Dec 2021 13:59:33 +0800 [thread overview]
Message-ID: <20211231055935.1878503-2-chen.zhang@intel.com> (raw)
In-Reply-To: <20211231055935.1878503-1-chen.zhang@intel.com>
In the migration_completion() no other status is expected, for
example MIGRATION_STATUS_CANCELLING, MIGRATION_STATUS_CANCELLED, etc.
Signed-off-by: Zhang Chen <chen.zhang@intel.com>
---
migration/migration.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/migration.c b/migration/migration.c
index 0652165610..2afa77da03 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -3205,7 +3205,7 @@ static void migration_completion(MigrationState *s)
qemu_mutex_unlock_iothread();
trace_migration_completion_postcopy_end_after_complete();
- } else if (s->state == MIGRATION_STATUS_CANCELLING) {
+ } else {
goto fail;
}
--
2.25.1
next prev parent reply other threads:[~2021-12-31 6:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-31 5:59 [PATCH 0/3] Some minor fixes for migration states Zhang Chen
2021-12-31 5:59 ` Zhang Chen [this message]
2022-01-19 17:52 ` [PATCH 1/3] migration/migration.c: Add missed default error handler for migration state Dr. David Alan Gilbert
2022-01-20 14:55 ` Zhang, Chen
2022-01-26 19:23 ` Juan Quintela
2021-12-31 5:59 ` [PATCH 2/3] migration/migration.c: Avoid COLO boot in postcopy migration Zhang Chen
2022-01-19 19:40 ` Dr. David Alan Gilbert
2022-01-20 14:53 ` Zhang, Chen
2022-01-26 19:30 ` Juan Quintela
2022-01-27 2:03 ` Zhang, Chen
2021-12-31 5:59 ` [PATCH 3/3] migration/migration.c: Remove the MIGRATION_STATUS_ACTIVE when migration finished Zhang Chen
2022-01-26 19:35 ` Juan Quintela
2022-01-19 14:45 ` [PATCH 0/3] Some minor fixes for migration states Zhang, Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211231055935.1878503-2-chen.zhang@intel.com \
--to=chen.zhang@intel.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).