* [PATCH v2] hw/vhost-user-blk: turn on VIRTIO_BLK_F_SIZE_MAX feature for virtio blk device
@ 2022-01-03 9:28 Andy Pei
2022-01-03 10:42 ` Michael S. Tsirkin
0 siblings, 1 reply; 2+ messages in thread
From: Andy Pei @ 2022-01-03 9:28 UTC (permalink / raw)
To: qemu-devel, qemu-block; +Cc: kwolf, mst, changpeng.liu, mreitz, raphael.norwitz
Turn on pre-defined feature VIRTIO_BLK_F_SIZE_MAX for virtio blk device to
avoid guest DMA request sizes which are too large for hardware spec.
Signed-off-by: Andy Pei <andy.pei@intel.com>
---
hw/block/vhost-user-blk.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/block/vhost-user-blk.c b/hw/block/vhost-user-blk.c
index ba13cb8..eb1264a 100644
--- a/hw/block/vhost-user-blk.c
+++ b/hw/block/vhost-user-blk.c
@@ -252,6 +252,7 @@ static uint64_t vhost_user_blk_get_features(VirtIODevice *vdev,
VHostUserBlk *s = VHOST_USER_BLK(vdev);
/* Turn on pre-defined features */
+ virtio_add_feature(&features, VIRTIO_BLK_F_SIZE_MAX);
virtio_add_feature(&features, VIRTIO_BLK_F_SEG_MAX);
virtio_add_feature(&features, VIRTIO_BLK_F_GEOMETRY);
virtio_add_feature(&features, VIRTIO_BLK_F_TOPOLOGY);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] hw/vhost-user-blk: turn on VIRTIO_BLK_F_SIZE_MAX feature for virtio blk device
2022-01-03 9:28 [PATCH v2] hw/vhost-user-blk: turn on VIRTIO_BLK_F_SIZE_MAX feature for virtio blk device Andy Pei
@ 2022-01-03 10:42 ` Michael S. Tsirkin
0 siblings, 0 replies; 2+ messages in thread
From: Michael S. Tsirkin @ 2022-01-03 10:42 UTC (permalink / raw)
To: Andy Pei
Cc: kwolf, qemu-block, qemu-devel, raphael.norwitz, mreitz,
changpeng.liu
On Mon, Jan 03, 2022 at 05:28:12PM +0800, Andy Pei wrote:
> Turn on pre-defined feature VIRTIO_BLK_F_SIZE_MAX for virtio blk device to
> avoid guest DMA request sizes which are too large for hardware spec.
>
> Signed-off-by: Andy Pei <andy.pei@intel.com>
> ---
Thanks!
Notes for future submissions:
- pls include acks sent on previous versions unless changes you made
are substantial enough to invalidate them
- pls include a changelog for those that reviewed previous versions
No need to repost this one though.
Thanks!
> hw/block/vhost-user-blk.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/block/vhost-user-blk.c b/hw/block/vhost-user-blk.c
> index ba13cb8..eb1264a 100644
> --- a/hw/block/vhost-user-blk.c
> +++ b/hw/block/vhost-user-blk.c
> @@ -252,6 +252,7 @@ static uint64_t vhost_user_blk_get_features(VirtIODevice *vdev,
> VHostUserBlk *s = VHOST_USER_BLK(vdev);
>
> /* Turn on pre-defined features */
> + virtio_add_feature(&features, VIRTIO_BLK_F_SIZE_MAX);
> virtio_add_feature(&features, VIRTIO_BLK_F_SEG_MAX);
> virtio_add_feature(&features, VIRTIO_BLK_F_GEOMETRY);
> virtio_add_feature(&features, VIRTIO_BLK_F_TOPOLOGY);
> --
> 1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-03 10:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-03 9:28 [PATCH v2] hw/vhost-user-blk: turn on VIRTIO_BLK_F_SIZE_MAX feature for virtio blk device Andy Pei
2022-01-03 10:42 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).