qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fabiano Rosas <farosas@linux.ibm.com>
To: qemu-devel@nongnu.org
Cc: richard.henderson@linaro.org, danielhb413@gmail.com,
	qemu-ppc@nongnu.org, clg@kaod.org, david@gibson.dropbear.id.au
Subject: [PATCH 8/9] target/ppc: powerpc_excp: Move AIL under a Book3s block
Date: Mon,  3 Jan 2022 19:07:45 -0300	[thread overview]
Message-ID: <20220103220746.3916246-9-farosas@linux.ibm.com> (raw)
In-Reply-To: <20220103220746.3916246-1-farosas@linux.ibm.com>

AIL only applies for Book3s CPUs, so move it along with ILE. This
moves ILE further down in the file because the AIL function can alter
vector so we cannot move it up.

Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
---
 target/ppc/excp_helper.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
index d7e087f2f6..a4787c3ae2 100644
--- a/target/ppc/excp_helper.c
+++ b/target/ppc/excp_helper.c
@@ -766,14 +766,6 @@ static inline void powerpc_excp(PowerPCCPU *cpu, int excp)
         }
     }
 
-    /*
-     * We preserve MSR_LE, but some CPUs can take interrupts in a
-     * different endianness.
-     */
-    if (excp_model >= POWERPC_EXCP_970) {
-        ppc_excp_toggle_ile(cpu, &new_msr);
-    }
-
 #if defined(TARGET_PPC64)
     if (excp_model == POWERPC_EXCP_BOOKE) {
         if (env->spr[SPR_BOOKE_EPCR] & EPCR_ICM) {
@@ -799,8 +791,16 @@ static inline void powerpc_excp(PowerPCCPU *cpu, int excp)
         env->spr[srr1] = msr;
     }
 
-    /* This can update new_msr and vector if AIL applies */
-    ppc_excp_apply_ail(cpu, excp_model, excp, msr, &new_msr, &vector);
+    if (excp_model >= POWERPC_EXCP_970) {
+        /*
+         * We preserve MSR_LE, but some CPUs can take interrupts in a
+         * different endianness.
+         */
+        ppc_excp_toggle_ile(cpu, &new_msr);
+
+        /* This can update new_msr and vector if AIL applies */
+        ppc_excp_apply_ail(cpu, excp_model, excp, msr, &new_msr, &vector);
+    }
 
     powerpc_set_excp_state(cpu, vector, new_msr);
 }
-- 
2.33.1



  parent reply	other threads:[~2022-01-03 22:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-03 22:07 [PATCH 0/9] target/ppc: powerpc_excp improvements (2/n) Fabiano Rosas
2022-01-03 22:07 ` [PATCH 1/9] target/ppc: powerpc_excp: Extract software TLB logging into a function Fabiano Rosas
2022-01-04  9:32   ` Cédric Le Goater
2022-01-03 22:07 ` [PATCH 2/9] target/ppc: powerpc_excp: Keep 60x soft MMU logs active Fabiano Rosas
2022-01-04  9:33   ` Cédric Le Goater
2022-01-03 22:07 ` [PATCH 3/9] target/ppc: powerpc_excp: Group unimplemented exceptions Fabiano Rosas
2022-01-04  9:39   ` Cédric Le Goater
2022-01-03 22:07 ` [PATCH 4/9] target/ppc: Add HV support to ppc_interrupts_little_endian Fabiano Rosas
2022-01-03 22:07 ` [PATCH 5/9] target/ppc: Use ppc_interrupts_little_endian in powerpc_excp Fabiano Rosas
2022-01-04 10:09   ` Cédric Le Goater
2022-01-04 14:11     ` Fabiano Rosas
2022-01-04 17:30       ` Cédric Le Goater
2022-01-03 22:07 ` [PATCH 6/9] target/ppc: powerpc_excp: Preserve MSR_LE bit Fabiano Rosas
2022-01-04 20:51   ` Fabiano Rosas
2022-01-03 22:07 ` [PATCH 7/9] target/ppc: powerpc_excp: Move ILE setting into a function Fabiano Rosas
2022-01-03 22:07 ` Fabiano Rosas [this message]
2022-01-03 22:07 ` [PATCH 9/9] target/ppc: Introduce a wrapper for powerpc_excp Fabiano Rosas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220103220746.3916246-9-farosas@linux.ibm.com \
    --to=farosas@linux.ibm.com \
    --cc=clg@kaod.org \
    --cc=danielhb413@gmail.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).