From: Igor Mammedov <imammedo@redhat.com>
To: Stefan Berger <stefanb@linux.ibm.com>
Cc: Ani Sinha <ani@anisinha.ca>,
marcandre.lureau@redhat.com,
"Michael S . Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, Shannon Zhao <shannon.zhaosl@gmail.com>
Subject: Re: [PATCH v4 2/3] acpi: tpm: Add missing device identification objects
Date: Tue, 4 Jan 2022 17:34:56 +0100 [thread overview]
Message-ID: <20220104173456.5aaa0ea9@redhat.com> (raw)
In-Reply-To: <1b32e29a-36fc-7275-e856-97a12585e0a3@linux.ibm.com>
On Tue, 4 Jan 2022 09:48:32 -0500
Stefan Berger <stefanb@linux.ibm.com> wrote:
> On 1/4/22 04:55, Igor Mammedov wrote:
> > On Wed, 22 Dec 2021 21:23:09 -0500
> > Stefan Berger <stefanb@linux.ibm.com> wrote:
> >
> >> Add missing device identification objects _STR and _UID. They will appear
> > why, does it break anything or it's just cosmetic?
>
> I don't know about whether any software needs these entries but it's
> driven by this:
>
> https://gitlab.com/qemu-project/qemu/-/issues/708
>
>
> >
> >> as files 'description' and 'uid' under Linux sysfs.
> >>
> >> Cc: Shannon Zhao <shannon.zhaosl@gmail.com>
> >> Cc: Michael S. Tsirkin <mst@redhat.com>
> >> Cc: Igor Mammedov <imammedo@redhat.com>
> >> Cc: Ani Sinha <ani@anisinha.ca>
> >> Fixes: https://gitlab.com/qemu-project/qemu/-/issues/708
> >> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
> >> Message-id: 20211110133559.3370990-3-stefanb@linux.ibm.com
> >> ---
> >> hw/arm/virt-acpi-build.c | 1 +
> >> hw/i386/acpi-build.c | 8 ++++++++
> >> 2 files changed, 9 insertions(+)
> >>
> >> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
> >> index d0f4867fdf..f2514ce77c 100644
> >> --- a/hw/arm/virt-acpi-build.c
> >> +++ b/hw/arm/virt-acpi-build.c
> >> @@ -229,6 +229,7 @@ static void acpi_dsdt_add_tpm(Aml *scope, VirtMachineState *vms)
> >>
> >> Aml *dev = aml_device("TPM0");
> >> aml_append(dev, aml_name_decl("_HID", aml_string("MSFT0101")));
> >> + aml_append(dev, aml_name_decl("_STR", aml_string("TPM 2.0 Device")));
> >> aml_append(dev, aml_name_decl("_UID", aml_int(0)));
> >>
> >> Aml *crs = aml_resource_template();
> >> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> >> index 8383b83ee3..2fb70847cb 100644
> >> --- a/hw/i386/acpi-build.c
> >> +++ b/hw/i386/acpi-build.c
> >> @@ -1812,11 +1812,15 @@ build_dsdt(GArray *table_data, BIOSLinker *linker,
> >> dev = aml_device("TPM");
> >> aml_append(dev, aml_name_decl("_HID",
> >> aml_string("MSFT0101")));
> >> + aml_append(dev,
> >> + aml_name_decl("_STR",
> >> + aml_string("TPM 2.0 Device")));
> >> } else {
> >> dev = aml_device("ISA.TPM");
> >> aml_append(dev, aml_name_decl("_HID",
> >> aml_eisaid("PNP0C31")));
> >> }
> >> + aml_append(dev, aml_name_decl("_UID", aml_int(1)));
> > why it's 1, and not 0 as in virt-arm?
>
> Marc-Andre and I looked at machines with hardware TPMs and that's what
> we found there as well, a '1'.
perhaps mention that in commit message
>
>
> >
> >>
> >> aml_append(dev, aml_name_decl("_STA", aml_int(0xF)));
> >> crs = aml_resource_template();
> >> @@ -1844,6 +1848,8 @@ build_dsdt(GArray *table_data, BIOSLinker *linker,
> >> if (TPM_IS_CRB(tpm)) {
> >> dev = aml_device("TPM");
> >> aml_append(dev, aml_name_decl("_HID", aml_string("MSFT0101")));
> >> + aml_append(dev, aml_name_decl("_STR",
> >> + aml_string("TPM 2.0 Device")));
> >> crs = aml_resource_template();
> >> aml_append(crs, aml_memory32_fixed(TPM_CRB_ADDR_BASE,
> >> TPM_CRB_ADDR_SIZE, AML_READ_WRITE));
> >> @@ -1851,6 +1857,8 @@ build_dsdt(GArray *table_data, BIOSLinker *linker,
> >>
> >> aml_append(dev, aml_name_decl("_STA", aml_int(0xf)));
> >>
> > no necessary ^^^ empty line
> fixed
> >
> >> + aml_append(dev, aml_name_decl("_UID", aml_int(1)));
> >> +
> >> tpm_build_ppi_acpi(tpm, dev);
> >>
> >> aml_append(sb_scope, dev);
>
next prev parent reply other threads:[~2022-01-04 16:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 2:23 [PATCH v4 0/3] tpm: Add missing ACPI device identification objects Stefan Berger
2021-12-23 2:23 ` [PATCH v4 1/3] tests: acpi: prepare for updated TPM related tables Stefan Berger
2021-12-23 7:15 ` Ani Sinha
2021-12-23 2:23 ` [PATCH v4 2/3] acpi: tpm: Add missing device identification objects Stefan Berger
2021-12-23 7:13 ` Ani Sinha
2021-12-27 1:34 ` Shannon Zhao
2022-01-04 9:55 ` Igor Mammedov
2022-01-04 14:48 ` Stefan Berger
2022-01-04 15:15 ` Ani Sinha
2022-01-04 15:40 ` Stefan Berger
2022-01-04 16:34 ` Igor Mammedov [this message]
2022-01-04 17:58 ` Stefan Berger
2021-12-23 2:23 ` [PATCH v4 3/3] tests: acpi: Add updated TPM related tables Stefan Berger
2021-12-23 7:14 ` Ani Sinha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220104173456.5aaa0ea9@redhat.com \
--to=imammedo@redhat.com \
--cc=ani@anisinha.ca \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
--cc=stefanb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).