From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC70FC433EF for ; Wed, 5 Jan 2022 20:17:51 +0000 (UTC) Received: from localhost ([::1]:41962 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5CjG-0003ZD-Q9 for qemu-devel@archiver.kernel.org; Wed, 05 Jan 2022 15:17:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41162) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5Chp-0002WN-GO for qemu-devel@nongnu.org; Wed, 05 Jan 2022 15:16:21 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:50078) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5Chi-0006Xz-QS for qemu-devel@nongnu.org; Wed, 05 Jan 2022 15:16:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1641413773; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Zt1q7W6nWIs0kq/LK4LG7msHEt3mXuTO1u6v3pe4adU=; b=FBn6VezuOes0g/5fiMQnu0eFY79YP1rFkjpvmP2d2EFTVqFoHq6xa0fjupTAZJAaNI100r tANqm8N3jlhDjP4qIHRmOpZdMeDSGlnURZrM30fuDFvXFdtip13DvzS555lco8m+0LjDiq cRNHtTYbzUv9LfIOb/LassX1MEjD2VY= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-103-qo2Afx8SNmq25nFye8Ek_Q-1; Wed, 05 Jan 2022 15:16:12 -0500 X-MC-Unique: qo2Afx8SNmq25nFye8Ek_Q-1 Received: by mail-ed1-f71.google.com with SMTP id m8-20020a056402510800b003f9d22c4d48so159357edd.21 for ; Wed, 05 Jan 2022 12:16:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Zt1q7W6nWIs0kq/LK4LG7msHEt3mXuTO1u6v3pe4adU=; b=gSozIbNOamLQy/BdjqBXrbiLfcWgsf/hNMz4gE1QR11vAEZi5TVLFLYHVVeHaGy3nQ wtN4AAZAgAsO93gCDjFlU/RD7M9ucHd7L76AwD0EZxsv0B20rlFF9RkgNRNtU/k2sHH9 FLRTDrmG3vdI8k0IPP2PHBa5izAWFT8+VpQGdt41d/vO3A9ktaOG/wFFLDK5HwzH9lGw 9DZTKo9PCSLDN03lxBfhGO2212POlpKlKsY2ZDCa+7BvQ+dbqpFA7coUKyEl9uBzemJX NWKaQDsvcUMryBDMG22hyfSSOEWvlJ53AA/AUFPLJKZrfR8SdtANmrDbtJ/mwOJ2XLwL 0idw== X-Gm-Message-State: AOAM530iDlI+imeIQoP5RLMufvU+y+8oD2JANCqY5pv+BU0yPSjKunfX FB3HMviFNLAwMMn9Mca2aSGww+lM9VrDyobL/nOIM/AUcy+FJQtizGrhT31dVVdt8nKBR1t8p1H ZNkYOc8ww0cPUn88= X-Received: by 2002:a05:6402:41a:: with SMTP id q26mr55136320edv.387.1641413771287; Wed, 05 Jan 2022 12:16:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJwz5tzqQ7Re9dYSdmhpNq2nzFLcW5DAoiOYESJC7BSkBJEEyJgyF0a78+ileqjrAse+gjok9A== X-Received: by 2002:a05:6402:41a:: with SMTP id q26mr55136285edv.387.1641413771011; Wed, 05 Jan 2022 12:16:11 -0800 (PST) Received: from redhat.com ([2.55.159.137]) by smtp.gmail.com with ESMTPSA id y12sm11173743edd.31.2022.01.05.12.16.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jan 2022 12:16:10 -0800 (PST) Date: Wed, 5 Jan 2022 15:16:06 -0500 From: "Michael S. Tsirkin" To: Steven Sistare Subject: Re: [PATCH V7 17/29] pci: export functions for cpr Message-ID: <20220105151427-mutt-send-email-mst@kernel.org> References: <1640199934-455149-1-git-send-email-steven.sistare@oracle.com> <1640199934-455149-18-git-send-email-steven.sistare@oracle.com> <20211222180611-mutt-send-email-mst@kernel.org> <02a093fe-b2be-2ecb-7ef7-a95c54443894@oracle.com> MIME-Version: 1.0 In-Reply-To: <02a093fe-b2be-2ecb-7ef7-a95c54443894@oracle.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=170.10.129.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.372, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Daniel P. Berrange" , Juan Quintela , Jason Zeng , Alex =?iso-8859-1?Q?Benn=E9e?= , qemu-devel@nongnu.org, Eric Blake , "Dr. David Alan Gilbert" , Zheng Chuan , Alex Williamson , Stefan Hajnoczi , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Paolo Bonzini , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Jan 05, 2022 at 12:22:25PM -0500, Steven Sistare wrote: > On 12/22/2021 6:07 PM, Michael S. Tsirkin wrote: > > On Wed, Dec 22, 2021 at 11:05:22AM -0800, Steve Sistare wrote: > >> Export msix_is_pending, msix_init_vector_notifiers, and pci_update_mappings > >> for use by cpr. No functional change. > >> > >> Signed-off-by: Steve Sistare > > > > With things like that, I prefer when the API is exported > > together with the patch that uses it. > > This was I can see why we are exporting these APIs. > > Esp wrt pci_update_mappings, it's designed as an > > internal API. > > Hi Michael, thanks very much for reviewing these patches. > > Serendipitously, I stopped calling pci_update_mappings from vfio code earlier > in the series. I will revert its scope. > > I would prefer to keep this patch separate from the use of these functions in > "vfio-pci cpr part 2 msi", to make the latter smaller and easier to understand. > How about if I say more in this commit message? : > > Export msix_is_pending and msix_init_vector_notifiers for use in vfio cpr. > Both are needed in the vfio-pci post-load function during cpr-load. > msix_is_pending is checked to enable the PBA memory region. > msix_init_vector_notifiers is called to register notifier callbacks, without > the other side effects of msix_set_vector_notifiers. > > - Steve Well the reason the side effects are there is to avoid losing events, no? I'd like to figure out a bit better why we don't need them, and when should users call msix_init_vector_notifiers versus msix_set_vector_notifiers. > >> --- > >> hw/pci/msix.c | 20 ++++++++++++++------ > >> hw/pci/pci.c | 3 +-- > >> include/hw/pci/msix.h | 5 +++++ > >> include/hw/pci/pci.h | 1 + > >> 4 files changed, 21 insertions(+), 8 deletions(-) > >> > >> diff --git a/hw/pci/msix.c b/hw/pci/msix.c > >> index ae9331c..73f4259 100644 > >> --- a/hw/pci/msix.c > >> +++ b/hw/pci/msix.c > >> @@ -64,7 +64,7 @@ static uint8_t *msix_pending_byte(PCIDevice *dev, int vector) > >> return dev->msix_pba + vector / 8; > >> } > >> > >> -static int msix_is_pending(PCIDevice *dev, int vector) > >> +int msix_is_pending(PCIDevice *dev, unsigned int vector) > >> { > >> return *msix_pending_byte(dev, vector) & msix_pending_mask(vector); > >> } > >> @@ -579,6 +579,17 @@ static void msix_unset_notifier_for_vector(PCIDevice *dev, unsigned int vector) > >> dev->msix_vector_release_notifier(dev, vector); > >> } > >> > >> +void msix_init_vector_notifiers(PCIDevice *dev, > >> + MSIVectorUseNotifier use_notifier, > >> + MSIVectorReleaseNotifier release_notifier, > >> + MSIVectorPollNotifier poll_notifier) > >> +{ > >> + assert(use_notifier && release_notifier); > >> + dev->msix_vector_use_notifier = use_notifier; > >> + dev->msix_vector_release_notifier = release_notifier; > >> + dev->msix_vector_poll_notifier = poll_notifier; > >> +} > >> + > >> int msix_set_vector_notifiers(PCIDevice *dev, > >> MSIVectorUseNotifier use_notifier, > >> MSIVectorReleaseNotifier release_notifier, > >> @@ -586,11 +597,8 @@ int msix_set_vector_notifiers(PCIDevice *dev, > >> { > >> int vector, ret; > >> > >> - assert(use_notifier && release_notifier); > >> - > >> - dev->msix_vector_use_notifier = use_notifier; > >> - dev->msix_vector_release_notifier = release_notifier; > >> - dev->msix_vector_poll_notifier = poll_notifier; > >> + msix_init_vector_notifiers(dev, use_notifier, release_notifier, > >> + poll_notifier); > >> > >> if ((dev->config[dev->msix_cap + MSIX_CONTROL_OFFSET] & > >> (MSIX_ENABLE_MASK | MSIX_MASKALL_MASK)) == MSIX_ENABLE_MASK) { > >> diff --git a/hw/pci/pci.c b/hw/pci/pci.c > >> index e5993c1..0fd21e1 100644 > >> --- a/hw/pci/pci.c > >> +++ b/hw/pci/pci.c > >> @@ -225,7 +225,6 @@ static const TypeInfo pcie_bus_info = { > >> }; > >> > >> static PCIBus *pci_find_bus_nr(PCIBus *bus, int bus_num); > >> -static void pci_update_mappings(PCIDevice *d); > >> static void pci_irq_handler(void *opaque, int irq_num, int level); > >> static void pci_add_option_rom(PCIDevice *pdev, bool is_default_rom, Error **); > >> static void pci_del_option_rom(PCIDevice *pdev); > >> @@ -1366,7 +1365,7 @@ static pcibus_t pci_bar_address(PCIDevice *d, > >> return new_addr; > >> } > >> > >> -static void pci_update_mappings(PCIDevice *d) > >> +void pci_update_mappings(PCIDevice *d) > >> { > >> PCIIORegion *r; > >> int i; > >> diff --git a/include/hw/pci/msix.h b/include/hw/pci/msix.h > >> index 4c4a60c..46606cf 100644 > >> --- a/include/hw/pci/msix.h > >> +++ b/include/hw/pci/msix.h > >> @@ -32,6 +32,7 @@ int msix_present(PCIDevice *dev); > >> bool msix_is_masked(PCIDevice *dev, unsigned vector); > >> void msix_set_pending(PCIDevice *dev, unsigned vector); > >> void msix_clr_pending(PCIDevice *dev, int vector); > >> +int msix_is_pending(PCIDevice *dev, unsigned vector); > >> > >> int msix_vector_use(PCIDevice *dev, unsigned vector); > >> void msix_vector_unuse(PCIDevice *dev, unsigned vector); > >> @@ -41,6 +42,10 @@ void msix_notify(PCIDevice *dev, unsigned vector); > >> > >> void msix_reset(PCIDevice *dev); > >> > >> +void msix_init_vector_notifiers(PCIDevice *dev, > >> + MSIVectorUseNotifier use_notifier, > >> + MSIVectorReleaseNotifier release_notifier, > >> + MSIVectorPollNotifier poll_notifier); > >> int msix_set_vector_notifiers(PCIDevice *dev, > >> MSIVectorUseNotifier use_notifier, > >> MSIVectorReleaseNotifier release_notifier, > >> diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h > >> index e7cdf2d..cc63dd4 100644 > >> --- a/include/hw/pci/pci.h > >> +++ b/include/hw/pci/pci.h > >> @@ -910,5 +910,6 @@ extern const VMStateDescription vmstate_pci_device; > >> > >> MSIMessage pci_get_msi_message(PCIDevice *dev, int vector); > >> void pci_set_power(PCIDevice *pci_dev, bool state); > >> +void pci_update_mappings(PCIDevice *d); > >> > >> #endif > >> -- > >> 1.8.3.1 > >