qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Eduardo Habkost <eduardo@habkost.net>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH for-7.0] hw/i386/pc: Add missing property descriptions
Date: Thu, 6 Jan 2022 09:10:17 +0100	[thread overview]
Message-ID: <20220106091017.6e7ce1af@redhat.com> (raw)
In-Reply-To: <20211206134255.94784-1-thuth@redhat.com>

On Mon,  6 Dec 2021 14:42:55 +0100
Thomas Huth <thuth@redhat.com> wrote:

> When running "qemu-system-x86_64 -M pc,help" I noticed that some
> properties were still missing their description. Add them now so
> that users get at least a slightly better idea what they are all
> about.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  hw/i386/pc.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index a2ef40ecbc..837f2bff4e 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -1734,15 +1734,23 @@ static void pc_machine_class_init(ObjectClass *oc, void *data)
>  
>      object_class_property_add_bool(oc, PC_MACHINE_SMBUS,
>          pc_machine_get_smbus, pc_machine_set_smbus);
> +    object_class_property_set_description(oc, PC_MACHINE_SMBUS,
> +        "Enable/disable system management bus");
>  
>      object_class_property_add_bool(oc, PC_MACHINE_SATA,
>          pc_machine_get_sata, pc_machine_set_sata);
> +    object_class_property_set_description(oc, PC_MACHINE_SATA,
> +        "Enable/disable Serial ATA bus");
>  
>      object_class_property_add_bool(oc, PC_MACHINE_PIT,
>          pc_machine_get_pit, pc_machine_set_pit);
> +    object_class_property_set_description(oc, PC_MACHINE_PIT,
> +        "Enable/disable Intel 8254 programmable interval timer emulation");
>  
>      object_class_property_add_bool(oc, "hpet",
>          pc_machine_get_hpet, pc_machine_set_hpet);
> +    object_class_property_set_description(oc, "hpet",
> +        "Enable/disable high precision event timer emulation");
>  
>      object_class_property_add_bool(oc, "default-bus-bypass-iommu",
>          pc_machine_get_default_bus_bypass_iommu,



      parent reply	other threads:[~2022-01-06  8:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-06 13:42 [PATCH for-7.0] hw/i386/pc: Add missing property descriptions Thomas Huth
2022-01-05  8:19 ` Thomas Huth
2022-01-06  8:10 ` Igor Mammedov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220106091017.6e7ce1af@redhat.com \
    --to=imammedo@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).