From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Alistair Francis <alistair.francis@wdc.com>
Cc: Yanan Wang <wangyanan55@huawei.com>,
qemu-trivial@nongnu.org, Andrew Jones <drjones@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH] softmmu/device_tree: Silence compiler warning with --enable-sanitizers
Date: Fri, 7 Jan 2022 14:38:44 +0100 [thread overview]
Message-ID: <20220107133844.145039-1-thuth@redhat.com> (raw)
If I configure my build with --enable-sanitizers, my GCC (v8.5.0)
complains:
.../softmmu/device_tree.c: In function ‘qemu_fdt_add_path’:
.../softmmu/device_tree.c:560:18: error: ‘retval’ may be used uninitialized
in this function [-Werror=maybe-uninitialized]
int namelen, retval;
^~~~~~
It's a false warning since the while loop is always executed at least
once (p has to be non-NULL, otherwise the derefence in the if-statement
earlier will crash). Thus let's switch to a do-while loop here instead
to make the compiler happy in all cases.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
softmmu/device_tree.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/softmmu/device_tree.c b/softmmu/device_tree.c
index 3965c834ca..9e96f5ecd5 100644
--- a/softmmu/device_tree.c
+++ b/softmmu/device_tree.c
@@ -564,7 +564,7 @@ int qemu_fdt_add_path(void *fdt, const char *path)
return -1;
}
- while (p) {
+ do {
name = p + 1;
p = strchr(name, '/');
namelen = p != NULL ? p - name : strlen(name);
@@ -584,7 +584,7 @@ int qemu_fdt_add_path(void *fdt, const char *path)
}
parent = retval;
- }
+ } while (p);
return retval;
}
--
2.27.0
next reply other threads:[~2022-01-07 13:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 13:38 Thomas Huth [this message]
2022-01-07 14:45 ` [PATCH] softmmu/device_tree: Silence compiler warning with --enable-sanitizers Andrew Jones
2022-01-07 14:47 ` Philippe Mathieu-Daudé
2022-01-07 20:18 ` Richard Henderson
2022-01-10 2:10 ` wangyanan (Y) via
2022-01-08 0:22 ` Alistair Francis
2022-01-10 2:03 ` wangyanan (Y) via
2022-01-10 6:39 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220107133844.145039-1-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=alistair.francis@wdc.com \
--cc=david@gibson.dropbear.id.au \
--cc=drjones@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).