From: Marc Zyngier <maz@kernel.org>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Andrew Jones <drjones@redhat.com>,
kvm@vger.kernel.org, Eric Auger <eric.auger@redhat.com>,
kernel-team@android.com, kvmarm@lists.cs.columbia.edu
Subject: [PATCH v4 6/6] hw/arm/virt: Drop superfluous checks against highmem
Date: Fri, 7 Jan 2022 16:33:24 +0000 [thread overview]
Message-ID: <20220107163324.2491209-7-maz@kernel.org> (raw)
In-Reply-To: <20220107163324.2491209-1-maz@kernel.org>
Now that the devices present in the extended memory map are checked
against the available PA space and disabled when they don't fit,
there is no need to keep the same checks against highmem, as
highmem really is a shortcut for the PA space being 32bit.
Signed-off-by: Marc Zyngier <maz@kernel.org>
---
hw/arm/virt-acpi-build.c | 2 --
hw/arm/virt.c | 5 +----
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index 505c61e88e..cdac009419 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -946,8 +946,6 @@ void virt_acpi_build(VirtMachineState *vms, AcpiBuildTables *tables)
acpi_add_table(table_offsets, tables_blob);
build_fadt_rev5(tables_blob, tables->linker, vms, dsdt);
- vms->highmem_redists &= vms->highmem;
-
acpi_add_table(table_offsets, tables_blob);
build_madt(tables_blob, tables->linker, vms);
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 70b4773b3e..641c6a9c31 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -2170,9 +2170,6 @@ static void machvirt_init(MachineState *machine)
virt_flash_fdt(vms, sysmem, secure_sysmem ?: sysmem);
- vms->highmem_mmio &= vms->highmem;
- vms->highmem_redists &= vms->highmem;
-
create_gic(vms, sysmem);
virt_cpu_post_init(vms, sysmem);
@@ -2191,7 +2188,7 @@ static void machvirt_init(MachineState *machine)
machine->ram_size, "mach-virt.tag");
}
- vms->highmem_ecam &= vms->highmem && (!firmware_loaded || aarch64);
+ vms->highmem_ecam &= (!firmware_loaded || aarch64);
create_rtc(vms);
--
2.30.2
next prev parent reply other threads:[~2022-01-07 16:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 16:33 [PATCH v4 0/6] target/arm: Reduced-IPA space and highmem fixes Marc Zyngier
2022-01-07 16:33 ` [PATCH v4 1/6] hw/arm/virt: Add a control for the the highmem PCIe MMIO Marc Zyngier
2022-01-07 16:33 ` [PATCH v4 2/6] hw/arm/virt: Add a control for the the highmem redistributors Marc Zyngier
2022-01-10 15:35 ` Eric Auger
2022-01-10 15:45 ` Marc Zyngier
2022-01-10 15:47 ` Peter Maydell
2022-01-10 16:02 ` Marc Zyngier
2022-01-10 15:48 ` Eric Auger
2022-01-07 16:33 ` [PATCH v4 3/6] hw/arm/virt: Honor highmem setting when computing the memory map Marc Zyngier
2022-01-10 15:30 ` Eric Auger
2022-01-07 16:33 ` [PATCH v4 4/6] hw/arm/virt: Use the PA range to compute " Marc Zyngier
2022-01-10 15:38 ` Eric Auger
2022-01-10 15:58 ` Marc Zyngier
2022-01-07 16:33 ` [PATCH v4 5/6] hw/arm/virt: Disable highmem devices that don't fit in the PA range Marc Zyngier
2022-01-10 17:12 ` Eric Auger
2022-01-10 18:51 ` Marc Zyngier
2022-01-07 16:33 ` Marc Zyngier [this message]
2022-01-10 17:14 ` [PATCH v4 6/6] hw/arm/virt: Drop superfluous checks against highmem Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220107163324.2491209-7-maz@kernel.org \
--to=maz@kernel.org \
--cc=drjones@redhat.com \
--cc=eric.auger@redhat.com \
--cc=kernel-team@android.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).