qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Frederic Barrat" <fbarrat@linux.ibm.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Cédric Le Goater" <clg@kaod.org>
Subject: [PULL v3 24/55] pcie_aer: Don't trigger a LSI if none are defined
Date: Fri, 7 Jan 2022 20:04:45 -0500	[thread overview]
Message-ID: <20220108003423.15830-25-mst@redhat.com> (raw)
In-Reply-To: <20220108003423.15830-1-mst@redhat.com>

From: Frederic Barrat <fbarrat@linux.ibm.com>

Skip triggering an LSI when the AER root error status is updated if no
LSI is defined for the device. We can have a root bridge with no LSI,
MSI and MSI-X defined, for example on POWER systems.

Signed-off-by: Frederic Barrat <fbarrat@linux.ibm.com>
Message-Id: <20211116170133.724751-4-fbarrat@linux.ibm.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
---
 hw/pci/pcie_aer.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/hw/pci/pcie_aer.c b/hw/pci/pcie_aer.c
index 27f9cc56af..e1a8a88c8c 100644
--- a/hw/pci/pcie_aer.c
+++ b/hw/pci/pcie_aer.c
@@ -774,7 +774,9 @@ void pcie_aer_root_write_config(PCIDevice *dev,
     uint32_t root_cmd = pci_get_long(aer_cap + PCI_ERR_ROOT_COMMAND);
     /* 6.2.4.1.2 Interrupt Generation */
     if (!msix_enabled(dev) && !msi_enabled(dev)) {
-        pci_set_irq(dev, !!(root_cmd & enabled_cmd));
+        if (pci_intx(dev) != -1) {
+            pci_set_irq(dev, !!(root_cmd & enabled_cmd));
+        }
         return;
     }
 
-- 
MST



  parent reply	other threads:[~2022-01-08  1:39 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-08  1:03 [PULL v3 00/55] virtio,pci,pc: features,fixes,cleanups Michael S. Tsirkin
2022-01-08  1:03 ` [PULL v3 01/55] virtio-mem: Don't skip alignment checks when warning about block size Michael S. Tsirkin
2022-01-08  1:03 ` [PULL v3 02/55] acpi: validate hotplug selector on access Michael S. Tsirkin
2022-01-08  1:03 ` [PULL v3 03/55] virtio: introduce macro IRTIO_CONFIG_IRQ_IDX Michael S. Tsirkin
2022-01-08  1:03 ` [PULL v3 04/55] virtio-pci: decouple notifier from interrupt process Michael S. Tsirkin
2022-01-08  1:03 ` [PULL v3 05/55] virtio-pci: decouple the single vector from the " Michael S. Tsirkin
2022-01-08  1:03 ` [PULL v3 06/55] vhost: introduce new VhostOps vhost_set_config_call Michael S. Tsirkin
2022-01-08  1:03 ` [PULL v3 07/55] vhost-vdpa: add support for config interrupt Michael S. Tsirkin
2022-01-08  1:03 ` [PULL v3 08/55] virtio: add support for configure interrupt Michael S. Tsirkin
2022-01-08  1:03 ` [PULL v3 09/55] vhost: " Michael S. Tsirkin
2022-01-08  1:04 ` [PULL v3 10/55] virtio-net: " Michael S. Tsirkin
2022-01-08  1:04 ` [PULL v3 11/55] virtio-mmio: " Michael S. Tsirkin
2022-01-08  1:04 ` [PULL v3 12/55] virtio-pci: " Michael S. Tsirkin
2022-01-09  6:17   ` Volker Rümelin
2022-01-09 16:11     ` Michael S. Tsirkin
2022-01-09 17:52       ` Volker Rümelin
2022-01-09 18:01         ` Michael S. Tsirkin
2022-01-09 18:54           ` Volker Rümelin
2022-01-09 20:19             ` Volker Rümelin
2022-01-09 13:33   ` Cédric Le Goater
2022-01-09 15:54     ` Michael S. Tsirkin
2022-01-08  1:04 ` [PULL v3 13/55] trace-events,pci: unify trace events format Michael S. Tsirkin
2022-01-08  1:04 ` [PULL v3 14/55] vhost-user-blk: reconnect on any error during realize Michael S. Tsirkin
2022-01-08  1:04 ` [PULL v3 15/55] chardev/char-socket: tcp_chr_recv: don't clobber errno Michael S. Tsirkin
2022-01-08  1:04 ` [PULL v3 16/55] chardev/char-socket: tcp_chr_sync_read: " Michael S. Tsirkin
2022-01-08  1:04 ` [PULL v3 17/55] vhost-backend: avoid overflow on memslots_limit Michael S. Tsirkin
2022-01-08  1:04 ` [PULL v3 18/55] vhost-backend: stick to -errno error return convention Michael S. Tsirkin
2022-01-08  1:04 ` [PULL v3 19/55] vhost-vdpa: " Michael S. Tsirkin
2022-01-08  1:04 ` [PULL v3 20/55] vhost-user: " Michael S. Tsirkin
2022-01-08  1:04 ` [PULL v3 21/55] vhost: " Michael S. Tsirkin
2022-01-08  1:04 ` [PULL v3 22/55] vhost-user-blk: propagate error return from generic vhost Michael S. Tsirkin
2022-01-08  1:04 ` [PULL v3 23/55] pci: Export the pci_intx() function Michael S. Tsirkin
2022-01-08  1:04 ` Michael S. Tsirkin [this message]
2022-01-08  1:04 ` [PULL v3 25/55] smbios: Rename SMBIOS_ENTRY_POINT_* enums Michael S. Tsirkin
2022-01-08  1:04 ` [PULL v3 26/55] hw/smbios: Use qapi for SmbiosEntryPointType Michael S. Tsirkin
2022-01-08  1:04 ` [PULL v3 27/55] hw/i386: expose a "smbios-entry-point-type" PC machine property Michael S. Tsirkin
2022-01-08  1:05 ` [PULL v3 28/55] hw/vhost-user-blk: turn on VIRTIO_BLK_F_SIZE_MAX feature for virtio blk device Michael S. Tsirkin
2022-01-08  1:05 ` [PULL v3 29/55] util/oslib-posix: Let touch_all_pages() return an error Michael S. Tsirkin
2022-01-08  1:05 ` [PULL v3 30/55] util/oslib-posix: Support MADV_POPULATE_WRITE for os_mem_prealloc() Michael S. Tsirkin
2022-01-08  1:05 ` [PULL v3 31/55] util/oslib-posix: Introduce and use MemsetContext for touch_all_pages() Michael S. Tsirkin
2022-01-08  1:05 ` [PULL v3 32/55] util/oslib-posix: Don't create too many threads with small memory or little pages Michael S. Tsirkin
2022-01-08  1:05 ` [PULL v3 33/55] util/oslib-posix: Avoid creating a single thread with MADV_POPULATE_WRITE Michael S. Tsirkin
2022-01-08  1:05 ` [PULL v3 34/55] util/oslib-posix: Support concurrent os_mem_prealloc() invocation Michael S. Tsirkin
2022-01-08  1:05 ` [PULL v3 35/55] util/oslib-posix: Forward SIGBUS to MCE handler under Linux Michael S. Tsirkin
2022-01-08  1:05 ` [PULL v3 36/55] virtio-mem: Support "prealloc=on" option Michael S. Tsirkin
2022-01-08  1:05 ` [PULL v3 37/55] virtio: signal after wrapping packed used_idx Michael S. Tsirkin
2022-01-08  1:05 ` [PULL v3 38/55] MAINTAINERS: Add a separate entry for acpi/VIOT tables Michael S. Tsirkin
2022-01-08  1:05 ` [PULL v3 39/55] linux-headers: sync VIRTIO_MEM_F_UNPLUGGED_INACCESSIBLE Michael S. Tsirkin
2022-01-08  1:05 ` [PULL v3 40/55] virtio-mem: Support VIRTIO_MEM_F_UNPLUGGED_INACCESSIBLE Michael S. Tsirkin
2022-01-08  1:05 ` [PULL v3 41/55] virtio-mem: Set "unplugged-inaccessible=auto" for the 7.0 machine on x86 Michael S. Tsirkin
2022-01-08  1:05 ` [PULL v3 42/55] intel-iommu: correctly check passthrough during translation Michael S. Tsirkin
2022-01-08  1:05 ` [PULL v3 43/55] acpi: fix QEMU crash when started with SLIC table Michael S. Tsirkin
2022-01-08  1:05 ` [PULL v3 44/55] tests: acpi: whitelist expected blobs before changing them Michael S. Tsirkin
2022-01-08  1:06 ` [PULL v3 45/55] tests: acpi: add SLIC table test Michael S. Tsirkin
2022-01-08  1:06 ` [PULL v3 46/55] tests: acpi: SLIC: update expected blobs Michael S. Tsirkin
2022-01-08  1:06 ` [PULL v3 47/55] acpihp: simplify acpi_pcihp_disable_root_bus Michael S. Tsirkin
2022-01-08  1:06 ` [PULL v3 48/55] hw/i386/pc: Add missing property descriptions Michael S. Tsirkin
2022-01-08  1:06 ` [PULL v3 49/55] docs: reSTify virtio-balloon-stats documentation and move to docs/interop Michael S. Tsirkin
2022-01-08  1:06 ` [PULL v3 50/55] hw/scsi/vhost-scsi: don't leak vqs on error Michael S. Tsirkin
2022-01-08  1:06 ` [PULL v3 51/55] hw/scsi/vhost-scsi: don't double close vhostfd " Michael S. Tsirkin
2022-01-08  1:06 ` [PULL v3 52/55] virtio/vhost-vsock: don't double close vhostfd, remove redundant cleanup Michael S. Tsirkin
2022-01-08  1:06 ` [PULL v3 53/55] tests: acpi: prepare for updated TPM related tables Michael S. Tsirkin
2022-01-08  1:06 ` [PULL v3 54/55] acpi: tpm: Add missing device identification objects Michael S. Tsirkin
2022-01-08  1:06 ` [PULL v3 55/55] tests: acpi: Add updated TPM related tables Michael S. Tsirkin
2022-01-08  5:32 ` [PULL v3 00/55] virtio,pci,pc: features,fixes,cleanups Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220108003423.15830-25-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=clg@kaod.org \
    --cc=fbarrat@linux.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).