From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: f4bug@amsat.org
Subject: [PATCH v4 12/12] tcg/mips: Try three insns with shift and add in tcg_out_movi
Date: Fri, 7 Jan 2022 22:36:44 -0800 [thread overview]
Message-ID: <20220108063644.478043-13-richard.henderson@linaro.org> (raw)
In-Reply-To: <20220108063644.478043-1-richard.henderson@linaro.org>
These sequences are inexpensive to test. Maxing out at three insns
results in the same space as a load plus the constant pool entry.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tcg/mips/tcg-target.c.inc | 44 +++++++++++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/tcg/mips/tcg-target.c.inc b/tcg/mips/tcg-target.c.inc
index a128c70154..185241da17 100644
--- a/tcg/mips/tcg-target.c.inc
+++ b/tcg/mips/tcg-target.c.inc
@@ -583,6 +583,7 @@ static void tcg_out_movi_int(TCGContext *s, TCGType type, TCGReg ret,
tcg_target_long arg, TCGReg tbreg)
{
tcg_target_long tmp;
+ int sh, lo;
if (TCG_TARGET_REG_BITS == 64 && type == TCG_TYPE_I32) {
arg = (int32_t)arg;
@@ -605,6 +606,49 @@ static void tcg_out_movi_int(TCGContext *s, TCGType type, TCGReg ret,
return;
}
+ /*
+ * Load bitmasks with a right-shift. This is good for things
+ * like 0x0fff_ffff_ffff_fff0: ADDUI r,0xff00 + DSRL r,r,4.
+ * or similarly using LUI. For this to work, bit 31 must be set.
+ */
+ if (arg > 0 && (int32_t)arg < 0) {
+ sh = clz64(arg);
+ if (tcg_out_movi_one(s, ret, arg << sh)) {
+ tcg_out_dsrl(s, ret, ret, sh);
+ return;
+ }
+ }
+
+ /*
+ * Load slightly larger constants using left-shift.
+ * Limit this sequence to 3 insns to avoid too much expansion.
+ */
+ sh = ctz64(arg);
+ if (sh && tcg_out_movi_two(s, ret, arg >> sh)) {
+ tcg_out_dsll(s, ret, ret, sh);
+ return;
+ }
+
+ /*
+ * Load slightly larger constants using left-shift and add/or.
+ * Prefer addi with a negative immediate when that would produce
+ * a larger shift. For this to work, bits 15 and 16 must be set.
+ */
+ lo = arg & 0xffff;
+ if (lo) {
+ if ((arg & 0x18000) == 0x18000) {
+ lo = (int16_t)arg;
+ }
+ tmp = arg - lo;
+ sh = ctz64(tmp);
+ tmp >>= sh;
+ if (tcg_out_movi_one(s, ret, tmp)) {
+ tcg_out_dsll(s, ret, ret, sh);
+ tcg_out_opc_imm(s, lo < 0 ? OPC_DADDIU : OPC_ORI, ret, ret, lo);
+ return;
+ }
+ }
+
/* Otherwise, put 64-bit constants into the constant pool. */
tcg_out_movi_pool(s, ret, arg, tbreg);
}
--
2.25.1
prev parent reply other threads:[~2022-01-08 7:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-08 6:36 [PATCH v4 00/12] tcg/mips: Unaligned access and other cleanup Richard Henderson
2022-01-08 6:36 ` [PATCH v4 01/12] tcg/mips: Support unaligned access for user-only Richard Henderson
2022-01-08 6:36 ` [PATCH v4 02/12] tcg/mips: Support unaligned access for softmmu Richard Henderson
2022-01-08 6:36 ` [PATCH v4 03/12] tcg/mips: Move TCG_AREG0 to S8 Richard Henderson
2022-01-08 6:36 ` [PATCH v4 04/12] tcg/mips: Move TCG_GUEST_BASE_REG to S7 Richard Henderson
2022-01-08 6:36 ` [PATCH v4 05/12] tcg/mips: Unify TCG_GUEST_BASE_REG tests Richard Henderson
2022-01-08 9:20 ` Philippe Mathieu-Daudé
2022-01-08 6:36 ` [PATCH v4 06/12] tcg/mips: Create and use TCG_REG_TB Richard Henderson
2022-01-08 6:36 ` [PATCH v4 07/12] tcg/mips: Split out tcg_out_movi_one Richard Henderson
2022-01-08 6:36 ` [PATCH v4 08/12] tcg/mips: Split out tcg_out_movi_two Richard Henderson
2022-01-08 6:36 ` [PATCH v4 09/12] tcg/mips: Use the constant pool for 64-bit constants Richard Henderson
2022-01-08 6:36 ` [PATCH v4 10/12] tcg/mips: Aggressively use the constant pool for n64 calls Richard Henderson
2022-01-08 6:36 ` [PATCH v4 11/12] tcg/mips: Try tb-relative addresses in tcg_out_movi Richard Henderson
2022-01-08 6:36 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220108063644.478043-13-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).