From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: qemu-devel@nongnu.org
Cc: Daniel Henrique Barboza <danielhb413@gmail.com>,
qemu-ppc@nongnu.org, clg@kaod.org, david@gibson.dropbear.id.au
Subject: [PATCH v4 0/5] user creatable pnv-phb4 devices
Date: Mon, 10 Jan 2022 21:55:53 -0300 [thread overview]
Message-ID: <20220111005558.549685-1-danielhb413@gmail.com> (raw)
Hi,
This new version contains the remaining v3 patches that weren't accepted
yet, which is the case of patches 10, 2 and 3.
There are fewer patches this time due to 2 design changes made: move the
phb property setup to stk_realize() and all XSCOM initialization to
phb4_realize().
As a note/TODO, at the end of this work it became clear that it would be
interesting to rethink what we expect about the PnvPhb4Stack object
in the overall design. The object ended up with no init() and its realize
is used as a glorified setup for its phb, being a no-op if the user runs
with -nodefaults. There might be an opportunity for further cleanups and
simplifications.
changes from v3:
- patches 2, 3, and 10 from v3: accepted
- patch 1:
* do not create a function to set the properties
* set all properties in stk_realize()
* remove the 'phb-id' link during this process instead of using a separated
patch
- patch 2:
* move all XSCOM init to phb4_realize()
- patch 4:
* review changes proposed by Cedric in v3
- patch 5 (new):
* a trivial cleanup following patch 2
- v3 link: https://lists.gnu.org/archive/html/qemu-devel/2022-01/msg01931.html
Daniel Henrique Barboza (5):
ppc/pnv: set phb4 properties in stk_realize()
ppc/pnv: move PHB4 XSCOM init to phb4_realize()
ppc/pnv: turn 'phb' into a pointer in struct PnvPhb4PecStack
ppc/pnv: Introduce user creatable pnv-phb4 devices
ppc/pnv: turn pnv_phb4_update_regions() into static
hw/pci-host/pnv_phb4.c | 431 ++++++++++++++++++++++++++++++---
hw/pci-host/pnv_phb4_pec.c | 317 +-----------------------
hw/ppc/pnv.c | 2 +
include/hw/pci-host/pnv_phb4.h | 8 +-
4 files changed, 422 insertions(+), 336 deletions(-)
--
2.33.1
next reply other threads:[~2022-01-11 1:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 0:55 Daniel Henrique Barboza [this message]
2022-01-11 0:55 ` [PATCH v4 1/5] ppc/pnv: set phb4 properties in stk_realize() Daniel Henrique Barboza
2022-01-11 9:34 ` Cédric Le Goater
2022-01-11 0:55 ` [PATCH v4 2/5] ppc/pnv: move PHB4 XSCOM init to phb4_realize() Daniel Henrique Barboza
2022-01-11 9:39 ` Cédric Le Goater
2022-01-11 0:55 ` [PATCH v4 3/5] ppc/pnv: turn 'phb' into a pointer in struct PnvPhb4PecStack Daniel Henrique Barboza
2022-01-11 9:40 ` Cédric Le Goater
2022-01-11 0:55 ` [PATCH v4 4/5] ppc/pnv: Introduce user creatable pnv-phb4 devices Daniel Henrique Barboza
2022-01-11 9:56 ` Cédric Le Goater
2022-01-11 10:28 ` Daniel Henrique Barboza
2022-01-11 0:55 ` [PATCH v4 5/5] ppc/pnv: turn pnv_phb4_update_regions() into static Daniel Henrique Barboza
2022-01-11 9:57 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220111005558.549685-1-danielhb413@gmail.com \
--to=danielhb413@gmail.com \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).