From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD77CC433EF for ; Tue, 11 Jan 2022 02:51:15 +0000 (UTC) Received: from localhost ([::1]:59802 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n77Fi-0001ss-RH for qemu-devel@archiver.kernel.org; Mon, 10 Jan 2022 21:51:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50964) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n772Z-0005LW-Q8 for qemu-devel@nongnu.org; Mon, 10 Jan 2022 21:37:40 -0500 Received: from mga17.intel.com ([192.55.52.151]:19369) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n772W-0001qo-KV for qemu-devel@nongnu.org; Mon, 10 Jan 2022 21:37:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641868656; x=1673404656; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=eBGROLJx8EcFEYWz4FTwmtiAfHMr3cYmKWQfmj+uxYw=; b=DWNT74/bNy9LjeJ+I12DtxBWHV0UB02qKRY70/iV1qR6S1QQ3gKE+tku Sia4BO40QgLT5jB1U3RPAt/w+PGDF14nYwFAVsCsnrabtTEM+BCR+VVwq 0NA6co9BFEI9pmHyvAsyp3EYGN1rdqMPAx5xEePKOTR/2oarGr6J2DCp/ CSgF4n25NPBeyudnluQztek13D3X+3UDMb0OJCS/jCkgu2rli7rCso72X eJVYNq7Kx40xZi9JBSCF2gcy+bZ4OCcgDHmJX02XHx116s+KwJLA4dytF cECheV9mI9vg43TOZy30X6ZsRYjl/BaO5YnnxBQk/kWcKVrNNoYe7SDTd Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10223"; a="224080863" X-IronPort-AV: E=Sophos;i="5.88,278,1635231600"; d="scan'208";a="224080863" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2022 18:37:33 -0800 X-IronPort-AV: E=Sophos;i="5.88,278,1635231600"; d="scan'208";a="474354301" Received: from yangzhon-virtual.bj.intel.com (HELO yangzhon-Virtual) ([10.238.145.56]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA256; 10 Jan 2022 18:37:31 -0800 Date: Tue, 11 Jan 2022 10:22:18 +0800 From: Yang Zhong To: "Tian, Kevin" Subject: Re: [RFC PATCH 1/7] x86: Fix the 64-byte boundary enumeration for extended state Message-ID: <20220111022218.GA10706@yangzhon-Virtual> References: <20220107093134.136441-1-yang.zhong@intel.com> <20220107093134.136441-2-yang.zhong@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Received-SPF: pass client-ip=192.55.52.151; envelope-from=yang.zhong@intel.com; helo=mga17.intel.com X-Spam_score_int: -49 X-Spam_score: -5.0 X-Spam_bar: ----- X-Spam_report: (-5.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.597, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yang.zhong@intel.com, "Christopherson, , Sean" , "jing2.liu@linux.intel.com" , "qemu-devel@nongnu.org" , "Wang, Wei W" , "Zeng, Guang" , "pbonzini@redhat.com" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Jan 10, 2022 at 04:20:41PM +0800, Tian, Kevin wrote: > > From: Zhong, Yang > > Sent: Friday, January 7, 2022 5:31 PM > > > > From: Jing Liu > > > > The extended state subleaves (EAX=0Dh, ECX=n, n>1).ECX[1] > > are all zero, while spec actually introduces that bit 01 > > should indicate if the extended state component locates > > on the next 64-byte boundary following the preceding state > > component when the compacted format of an XSAVE area is > > used. > > Above would read clearer if you revise to: > > "The extended state subleaves (EAX=0Dh, ECX=n, n>1).ECX[1] > indicate whether the extended state component locates > on the next 64-byte boundary following the preceding state > component when the compacted format of an XSAVE area is > used. > > But ECX[1] is always cleared in current implementation." Thanks Kevin, I will update this in next version. Yang