qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: "Shashi Mallela" <shashi.mallela@linaro.org>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH v2 00/13] arm gicv3 ITS: Various bug fixes and refactorings
Date: Tue, 11 Jan 2022 17:10:35 +0000	[thread overview]
Message-ID: <20220111171048.3545974-1-peter.maydell@linaro.org> (raw)

I've been working on the ITS to add support for the GICv4 functionality.
In the course of that I found a handful of bugs in it and also some
places where the code benefited from refactoring to make it a better
base to put in the GICv4 parts. This patchset is just the bugfixes
and cleanups, because there are enough patches here that I figured it
made sense to send them out now rather than holding on to them.

Most of these patches were in v1 and have been reviewed already.

Changes from v1:
 * first half of the series is now upstream
 * patch 1 now has the '1ULL' and uint64_t fixes that were
   partly split across two patches in the old series and partly missing
 * new patches 12 and 13

NB: I left the returns of -1 in patch 11.

Patches still needing review: 1, 12, 13

thanks
-- PMM

Peter Maydell (13):
  hw/intc/arm_gicv3_its: Fix event ID bounds checks
  hw/intc/arm_gicv3_its: Convert int ID check to num_intids convention
  hw/intc/arm_gicv3_its: Fix handling of process_its_cmd() return value
  hw/intc/arm_gicv3_its: Don't use data if reading command failed
  hw/intc/arm_gicv3_its: Use enum for return value of process_*
    functions
  hw/intc/arm_gicv3_its: Fix return codes in process_its_cmd()
  hw/intc/arm_gicv3_its: Refactor process_its_cmd() to reduce nesting
  hw/intc/arm_gicv3_its: Fix return codes in process_mapti()
  hw/intc/arm_gicv3_its: Fix return codes in process_mapc()
  hw/intc/arm_gicv3_its: Fix return codes in process_mapd()
  hw/intc/arm_gicv3_its: Factor out "find address of table entry" code
  hw/intc/arm_gicv3_its: Check indexes before use, not after
  hw/intc/arm_gicv3_its: Range-check ICID before indexing into
    collection table

 hw/intc/arm_gicv3_its.c | 492 ++++++++++++++++++----------------------
 1 file changed, 225 insertions(+), 267 deletions(-)

-- 
2.25.1


             reply	other threads:[~2022-01-11 17:16 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-11 17:10 Peter Maydell [this message]
2022-01-11 17:10 ` [PATCH v2 01/13] hw/intc/arm_gicv3_its: Fix event ID bounds checks Peter Maydell
2022-01-18 17:13   ` Alex Bennée
2022-01-28  1:33   ` Richard Henderson
2022-01-28 10:50     ` Peter Maydell
2022-01-11 17:10 ` [PATCH v2 02/13] hw/intc/arm_gicv3_its: Convert int ID check to num_intids convention Peter Maydell
2022-01-28  1:35   ` Richard Henderson
2022-01-28 10:51     ` Peter Maydell
2022-01-11 17:10 ` [PATCH v2 03/13] hw/intc/arm_gicv3_its: Fix handling of process_its_cmd() return value Peter Maydell
2022-01-11 17:10 ` [PATCH v2 04/13] hw/intc/arm_gicv3_its: Don't use data if reading command failed Peter Maydell
2022-01-11 17:10 ` [PATCH v2 05/13] hw/intc/arm_gicv3_its: Use enum for return value of process_* functions Peter Maydell
2022-01-11 17:10 ` [PATCH v2 06/13] hw/intc/arm_gicv3_its: Fix return codes in process_its_cmd() Peter Maydell
2022-01-11 17:10 ` [PATCH v2 07/13] hw/intc/arm_gicv3_its: Refactor process_its_cmd() to reduce nesting Peter Maydell
2022-01-11 17:10 ` [PATCH v2 08/13] hw/intc/arm_gicv3_its: Fix return codes in process_mapti() Peter Maydell
2022-01-11 17:10 ` [PATCH v2 09/13] hw/intc/arm_gicv3_its: Fix return codes in process_mapc() Peter Maydell
2022-01-11 17:10 ` [PATCH v2 10/13] hw/intc/arm_gicv3_its: Fix return codes in process_mapd() Peter Maydell
2022-01-11 17:10 ` [PATCH v2 11/13] hw/intc/arm_gicv3_its: Factor out "find address of table entry" code Peter Maydell
2022-01-18 17:31   ` Alex Bennée
2022-01-11 17:10 ` [PATCH v2 12/13] hw/intc/arm_gicv3_its: Check indexes before use, not after Peter Maydell
2022-01-18 17:32   ` Alex Bennée
2022-01-28  1:42   ` Richard Henderson
2022-01-11 17:10 ` [PATCH v2 13/13] hw/intc/arm_gicv3_its: Range-check ICID before indexing into collection table Peter Maydell
2022-01-18 17:37   ` Alex Bennée
2022-01-28  1:44   ` Richard Henderson
2022-01-18 17:37 ` [PATCH v2 00/13] arm gicv3 ITS: Various bug fixes and refactorings Alex Bennée
2022-01-18 19:41   ` Peter Maydell
2022-01-18 23:29     ` Andre Przywara
2022-01-19 10:15       ` Peter Maydell
2022-01-19 21:15         ` Andre Przywara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220111171048.3545974-1-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=shashi.mallela@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).