qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Richard Henderson <richard.henderson@linaro.org>,
	Laurent Vivier <laurent@vivier.eu>
Subject: [PULL 11/30] linux-user/m68k: Use force_sig_fault
Date: Tue, 11 Jan 2022 20:52:28 +0100	[thread overview]
Message-ID: <20220111195247.1737641-12-laurent@vivier.eu> (raw)
In-Reply-To: <20220111195247.1737641-1-laurent@vivier.eu>

From: Richard Henderson <richard.henderson@linaro.org>

Use the new function instead of setting up a target_siginfo_t
and calling queue_signal. Fill in the missing PC for SIGTRAP.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220107213243.212806-12-richard.henderson@linaro.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 linux-user/m68k/cpu_loop.c | 24 ++++--------------------
 1 file changed, 4 insertions(+), 20 deletions(-)

diff --git a/linux-user/m68k/cpu_loop.c b/linux-user/m68k/cpu_loop.c
index 318159441440..928a18e3cf05 100644
--- a/linux-user/m68k/cpu_loop.c
+++ b/linux-user/m68k/cpu_loop.c
@@ -29,7 +29,6 @@ void cpu_loop(CPUM68KState *env)
     CPUState *cs = env_cpu(env);
     int trapnr;
     unsigned int n;
-    target_siginfo_t info;
 
     for(;;) {
         cpu_exec_start(cs);
@@ -46,25 +45,13 @@ void cpu_loop(CPUM68KState *env)
         case EXCP_ILLEGAL:
         case EXCP_LINEA:
         case EXCP_LINEF:
-            info.si_signo = TARGET_SIGILL;
-            info.si_errno = 0;
-            info.si_code = TARGET_ILL_ILLOPN;
-            info._sifields._sigfault._addr = env->pc;
-            queue_signal(env, info.si_signo, QEMU_SI_FAULT, &info);
+            force_sig_fault(TARGET_SIGILL, TARGET_ILL_ILLOPN, env->pc);
             break;
         case EXCP_CHK:
-            info.si_signo = TARGET_SIGFPE;
-            info.si_errno = 0;
-            info.si_code = TARGET_FPE_INTOVF;
-            info._sifields._sigfault._addr = env->pc;
-            queue_signal(env, info.si_signo, QEMU_SI_FAULT, &info);
+            force_sig_fault(TARGET_SIGFPE, TARGET_FPE_INTOVF, env->pc);
             break;
         case EXCP_DIV0:
-            info.si_signo = TARGET_SIGFPE;
-            info.si_errno = 0;
-            info.si_code = TARGET_FPE_INTDIV;
-            info._sifields._sigfault._addr = env->pc;
-            queue_signal(env, info.si_signo, QEMU_SI_FAULT, &info);
+            force_sig_fault(TARGET_SIGFPE, TARGET_FPE_INTDIV, env->pc);
             break;
         case EXCP_TRAP0:
             {
@@ -91,10 +78,7 @@ void cpu_loop(CPUM68KState *env)
             /* just indicate that signals should be handled asap */
             break;
         case EXCP_DEBUG:
-            info.si_signo = TARGET_SIGTRAP;
-            info.si_errno = 0;
-            info.si_code = TARGET_TRAP_BRKPT;
-            queue_signal(env, info.si_signo, QEMU_SI_FAULT, &info);
+            force_sig_fault(TARGET_SIGTRAP, TARGET_TRAP_BRKPT, env->pc);
             break;
         case EXCP_ATOMIC:
             cpu_exec_step_atomic(cs);
-- 
2.33.1



  parent reply	other threads:[~2022-01-11 20:02 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-11 19:52 [PULL 00/30] Linux user for 7.0 patches Laurent Vivier
2022-01-11 19:52 ` [PULL 01/30] linux-user/alpha: Set TRAP_UNK for bugchk and unknown gentrap Laurent Vivier
2022-01-11 19:52 ` [PULL 02/30] linux-user/alpha: Set FPE_FLTUNK for gentrap ROPRAND Laurent Vivier
2022-01-11 19:52 ` [PULL 03/30] linux-user/alpha: Use force_sig_fault Laurent Vivier
2022-01-11 19:52 ` [PULL 04/30] linux-user/cris: " Laurent Vivier
2022-01-11 19:52 ` [PULL 05/30] linux-user/hppa: " Laurent Vivier
2022-01-11 19:52 ` [PULL 06/30] linux-user/hppa: Use the proper si_code for PRIV_OPR, PRIV_REG, OVERFLOW Laurent Vivier
2022-01-11 19:52 ` [PULL 07/30] linux-user: Remove TARGET_NSIGFPE Laurent Vivier
2022-01-11 19:52 ` [PULL 08/30] linux-user/hppa: Set FPE_CONDTRAP for COND Laurent Vivier
2022-01-11 19:52 ` [PULL 09/30] linux-user/i386: Split out maybe_handle_vm86_trap Laurent Vivier
2022-01-11 19:52 ` [PULL 10/30] linux-user/i386: Use force_sig, force_sig_fault Laurent Vivier
2022-01-11 19:52 ` Laurent Vivier [this message]
2022-01-11 19:52 ` [PULL 12/30] linux-user/microblaze: Use force_sig_fault Laurent Vivier
2022-01-11 19:52 ` [PULL 13/30] linux-user/microblaze: Fix SIGFPE si_codes Laurent Vivier
2022-01-11 19:52 ` [PULL 14/30] linux-user/mips: Improve do_break Laurent Vivier
2022-01-11 19:52 ` [PULL 15/30] linux-user/mips: Use force_sig_fault Laurent Vivier
2022-01-11 19:52 ` [PULL 16/30] target/mips: Extract break code into env->error_code Laurent Vivier
2022-01-11 19:52 ` [PULL 17/30] target/mips: Extract trap " Laurent Vivier
2022-01-11 19:52 ` [PULL 18/30] linux-user/openrisc: Use force_sig_fault Laurent Vivier
2022-01-11 19:52 ` [PULL 19/30] linux-user/ppc: " Laurent Vivier
2022-01-11 19:52 ` [PULL 20/30] linux-user/riscv: " Laurent Vivier
2022-01-11 19:52 ` [PULL 21/30] linux-user/s390x: " Laurent Vivier
2022-01-11 19:52 ` [PULL 22/30] linux-user/sh4: " Laurent Vivier
2022-01-11 19:52 ` [PULL 23/30] linux-user/sparc: " Laurent Vivier
2022-01-11 19:52 ` [PULL 24/30] linux-user/xtensa: " Laurent Vivier
2022-01-11 19:52 ` [PULL 25/30] linux-user/arm: Move target_oabi_flock64 out of target_structs.h Laurent Vivier
2022-01-11 19:52 ` [PULL 26/30] linux-user: Move target_struct.h generic definitions to generic/ Laurent Vivier
2022-01-11 19:52 ` [PULL 27/30] linux-user: Do not special-case NULL for PR_GET_PDEATHSIG Laurent Vivier
2022-01-11 19:52 ` [PULL 28/30] linux-user: Map signal number in PR_GET_PDEATHSIG Laurent Vivier
2022-01-11 19:52 ` [PULL 29/30] linux-user: Implement PR_SET_PDEATHSIG Laurent Vivier
2022-01-11 19:52 ` [PULL 30/30] linux-user: Implement capability prctls Laurent Vivier
2022-01-12 16:03 ` [PULL 00/30] Linux user for 7.0 patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220111195247.1737641-12-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).