qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: Ani Sinha <ani@anisinha.ca>, Marian Postevca <posteuca@mutex.one>,
	"Michael S . Tsirkin" <mst@redhat.com>
Subject: [PATCH 0/4] acpi: fix short OEM [Table] ID padding
Date: Wed, 12 Jan 2022 08:03:28 -0500	[thread overview]
Message-ID: <20220112130332.1648664-1-imammedo@redhat.com> (raw)

Since 6.0 the commit:
  602b458201 ("acpi: Permit OEM ID and OEM table ID fields to be changed")
regressed values of OEM [Table] ID fields in ACPI tables
by padding them with whitespace is a value is shorter then
max possible. That depending on vendor broke OEM [Table] ID patching
with SLIC table values and as result licensing of Windows guests.

First reported here https://gitlab.com/qemu-project/qemu/-/issues/707

CC: Marian Postevca <posteuca@mutex.one>
CC: Michael S. Tsirkin <mst@redhat.com>
CC: Ani Sinha <ani@anisinha.ca>

Igor Mammedov (4):
  tests: acpi: manually pad OEM_ID/OEM_TABLE_ID for test_oem_fields()
    test
  tests: acpi: whitelist nvdimm's SSDT and FACP.slic expected blobs
  acpi: fix OEM ID/OEM Table ID padding
  tests: acpi: update expected blobs

 hw/acpi/aml-build.c              |   4 ++--
 tests/data/acpi/pc/SSDT.dimmpxm  | Bin 734 -> 734 bytes
 tests/data/acpi/q35/FACP.slic    | Bin 244 -> 244 bytes
 tests/data/acpi/q35/SSDT.dimmpxm | Bin 734 -> 734 bytes
 tests/data/acpi/virt/SSDT.memhp  | Bin 736 -> 736 bytes
 tests/qtest/bios-tables-test.c   |  15 ++++++---------
 6 files changed, 8 insertions(+), 11 deletions(-)

-- 
2.31.1



             reply	other threads:[~2022-01-12 14:22 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-12 13:03 Igor Mammedov [this message]
2022-01-12 13:03 ` [PATCH 1/4] tests: acpi: manually pad OEM_ID/OEM_TABLE_ID for test_oem_fields() test Igor Mammedov
2022-01-12 13:44   ` Michael S. Tsirkin
2022-01-14 11:48     ` Igor Mammedov
2022-01-14 13:09       ` Michael S. Tsirkin
2022-01-12 13:03 ` [PATCH 2/4] tests: acpi: whitelist nvdimm's SSDT and FACP.slic expected blobs Igor Mammedov
2022-01-12 13:03 ` [PATCH 3/4] acpi: fix OEM ID/OEM Table ID padding Igor Mammedov
2022-01-12 13:39   ` Michael S. Tsirkin
2022-01-12 15:16     ` Ani Sinha
2022-01-12 15:28       ` Michael S. Tsirkin
2022-01-12 15:19   ` Ani Sinha
2022-01-13  9:53   ` Dmitry V. Orekhov
2022-01-13 10:22     ` Ani Sinha
2022-01-13 13:19       ` Dmitry V. Orekhov
2022-01-31  6:17   ` Ani Sinha
2022-01-31 13:20     ` Igor Mammedov
2022-01-31 13:28       ` Ani Sinha
2022-01-31 14:10         ` Igor Mammedov
2022-01-31 14:21           ` Ani Sinha
2022-02-01  7:39             ` Igor Mammedov
2022-02-01  7:55               ` Ani Sinha
2022-02-01  9:14                 ` Igor Mammedov
2022-01-12 13:03 ` [PATCH 4/4] tests: acpi: update expected blobs Igor Mammedov
2022-01-12 15:13   ` Ani Sinha
2022-01-14 14:26 ` [PATCH 5/4] tests: acpi: test short OEM_ID/OEM_TABLE_ID values in test_oem_fields() Igor Mammedov
2022-01-14 14:53   ` Ani Sinha
2022-01-31 13:21 ` [PATCH 0/4] acpi: fix short OEM [Table] ID padding Igor Mammedov
2022-01-31 13:37   ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220112130332.1648664-1-imammedo@redhat.com \
    --to=imammedo@redhat.com \
    --cc=ani@anisinha.ca \
    --cc=mst@redhat.com \
    --cc=posteuca@mutex.one \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).