From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3715BC433EF for ; Wed, 12 Jan 2022 16:59:45 +0000 (UTC) Received: from localhost ([::1]:59890 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7gyO-0007KW-3v for qemu-devel@archiver.kernel.org; Wed, 12 Jan 2022 11:59:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7gpn-0004oG-Pw; Wed, 12 Jan 2022 11:50:51 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:64878 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7gpa-00018t-Aa; Wed, 12 Jan 2022 11:50:41 -0500 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 20CEpdE9025168; Wed, 12 Jan 2022 16:50:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : content-transfer-encoding : mime-version; s=pp1; bh=uhxbTlNWaCtInRWWT982pP5fpblptr31pVKi+8I3cR0=; b=rcaTGdJqgBxImPDmz7s7rYxYPAcFjx1bZiYDOdIqQgcQVDDrOLHiMhcZXhfuR4oKCo0b DHXVwEv0/dmC8GfkZ2XFIQNTHQbdCA0Aq/uu9TLXWVNU7LW4o++bqVc61H7Tq3GD+I7i L2602Jo5+wmEbX8WJNqjlIdPGbtlMmr0JlSzziSFIfy6F5TROWm3oGufZWs+WJJ2kMYm 3uRs7CYkUClyd/5czFf0MoZ3ITknsdfFloncJ2zlIWHJadQPp1EcasGwePtUlwin/DAM CKvAdPfeqjw+D1vKTePl74EOokq+IIea5PJOOA9MC9pRGz7rSFSejgM9We/pn/W7dl9J Aw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 3dj0awbuee-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 12 Jan 2022 16:50:24 +0000 Received: from m0098419.ppops.net (m0098419.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 20CGJpQw007235; Wed, 12 Jan 2022 16:50:23 GMT Received: from ppma04fra.de.ibm.com (6a.4a.5195.ip4.static.sl-reverse.com [149.81.74.106]) by mx0b-001b2d01.pphosted.com with ESMTP id 3dj0awbue1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 12 Jan 2022 16:50:23 +0000 Received: from pps.filterd (ppma04fra.de.ibm.com [127.0.0.1]) by ppma04fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 20CGmJ73019590; Wed, 12 Jan 2022 16:50:22 GMT Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by ppma04fra.de.ibm.com with ESMTP id 3df289v0yx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 12 Jan 2022 16:50:21 +0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 20CGoITS28508576 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 12 Jan 2022 16:50:18 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 95B66AE058; Wed, 12 Jan 2022 16:50:18 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2AFFEAE061; Wed, 12 Jan 2022 16:50:18 +0000 (GMT) Received: from vm.lan (unknown [9.171.78.41]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 12 Jan 2022 16:50:18 +0000 (GMT) From: Ilya Leoshkevich To: Richard Henderson , David Hildenbrand , Cornelia Huck , Thomas Huth Subject: [PATCH v4 0/5] target/s390x: Fix shift instructions Date: Wed, 12 Jan 2022 17:50:11 +0100 Message-Id: <20220112165016.226996-1-iii@linux.ibm.com> X-Mailer: git-send-email 2.31.1 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: ukdILbN8Z7Qgk8dqD6QXfb2aGg9ZZiqM X-Proofpoint-GUID: pQB3vpVkgCIGP5zDC00MSyI2Hcdri4OR Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-12_04,2022-01-11_01,2021-12-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 lowpriorityscore=0 spamscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 adultscore=0 impostorscore=0 mlxscore=0 clxscore=1015 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2201120104 Received-SPF: pass client-ip=148.163.158.5; envelope-from=iii@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christian Borntraeger , qemu-s390x@nongnu.org, qemu-devel@nongnu.org, Ilya Leoshkevich Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" v3: https://lists.nongnu.org/archive/html/qemu-devel/2022-01/msg02680.html v3 -> v4: Simplify cc_calc_sla(). Free temporaries. v2: https://lists.nongnu.org/archive/html/qemu-devel/2022-01/msg02488.html v2 -> v3: Unify CC_OP_SLA_32 and CC_OP_SLA_64. Add underscores to test macro parameters. Shift CC in test asm. Add a second SLAG test. Add tags to commit messages. v1: https://lists.nongnu.org/archive/html/qemu-devel/2022-01/msg02035.html v1 -> v2: Fix cc_calc_sla_32(). Fix cc_calc_sla_64(). Fix SLDA sign bit index. Inline help_l2_shift(). Fix wout_r1_D32(). Add all shift instructions to the test. Split the series. Ilya Leoshkevich (5): target/s390x: Fix SLDA sign bit index target/s390x: Fix SRDA CC calculation target/s390x: Fix cc_calc_sla_64() missing overflows target/s390x: Fix shifting 32-bit values for more than 31 bits tests/tcg/s390x: Test shift instructions target/s390x/cpu-dump.c | 3 +- target/s390x/s390x-internal.h | 3 +- target/s390x/tcg/cc_helper.c | 38 +---- target/s390x/tcg/insn-data.def | 36 ++--- target/s390x/tcg/translate.c | 53 +++---- tests/tcg/s390x/Makefile.target | 1 + tests/tcg/s390x/shift.c | 270 ++++++++++++++++++++++++++++++++ 7 files changed, 321 insertions(+), 83 deletions(-) create mode 100644 tests/tcg/s390x/shift.c -- 2.31.1