qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Hasler <sebastian.hasler@stuvus.uni-stuttgart.de>
To: qemu-devel@nongnu.org
Cc: virtio-fs@redhat.com,
	Sebastian Hasler <sebastian.hasler@stuvus.uni-stuttgart.de>
Subject: [PATCH v2] virtiofsd: Do not support blocking flock
Date: Thu, 13 Jan 2022 16:32:49 +0100	[thread overview]
Message-ID: <20220113153249.710216-1-sebastian.hasler@stuvus.uni-stuttgart.de> (raw)

With the current implementation, blocking flock can lead to
deadlock. Thus, it's better to return EOPNOTSUPP if a user attempts
to perform a blocking flock request.

Signed-off-by: Sebastian Hasler <sebastian.hasler@stuvus.uni-stuttgart.de>
---
 tools/virtiofsd/passthrough_ll.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
index 64b5b4fbb1..faa62278c5 100644
--- a/tools/virtiofsd/passthrough_ll.c
+++ b/tools/virtiofsd/passthrough_ll.c
@@ -2442,6 +2442,15 @@ static void lo_flock(fuse_req_t req, fuse_ino_t ino, struct fuse_file_info *fi,
     int res;
     (void)ino;
 
+    if (!(op & LOCK_NB)) {
+        /*
+         * Blocking flock can deadlock as there is only one thread
+         * serving the queue.
+         */
+        fuse_reply_err(req, EOPNOTSUPP);
+        return;
+    }
+
     res = flock(lo_fi_fd(req, fi), op);
 
     fuse_reply_err(req, res == -1 ? errno : 0);
-- 
2.33.1



             reply	other threads:[~2022-01-13 15:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-13 15:32 Sebastian Hasler [this message]
2022-01-14 18:20 ` [Virtio-fs] [PATCH v2] virtiofsd: Do not support blocking flock Vivek Goyal
2022-01-17 17:08 ` Greg Kurz
2022-02-15 19:56 ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220113153249.710216-1-sebastian.hasler@stuvus.uni-stuttgart.de \
    --to=sebastian.hasler@stuvus.uni-stuttgart.de \
    --cc=qemu-devel@nongnu.org \
    --cc=virtio-fs@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).