From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B911C433F5 for ; Thu, 13 Jan 2022 17:32:14 +0000 (UTC) Received: from localhost ([::1]:54400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n83xN-0000hR-03 for qemu-devel@archiver.kernel.org; Thu, 13 Jan 2022 12:32:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55154) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n83oW-00084j-Di for qemu-devel@nongnu.org; Thu, 13 Jan 2022 12:23:05 -0500 Received: from [2a00:1450:4864:20::12a] (port=34765 helo=mail-lf1-x12a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n83oS-0000rl-7m for qemu-devel@nongnu.org; Thu, 13 Jan 2022 12:23:01 -0500 Received: by mail-lf1-x12a.google.com with SMTP id p27so10316418lfa.1 for ; Thu, 13 Jan 2022 09:22:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xdZaAA/zuFzYQdl3SdJx/bdQ9qYH+3gDPeoL6r0v1JU=; b=RbX17T9yGgyeC25v+6EFmr9cSKXOWs26dXLMRCHLn2IRuYMFA3W+RaEOXUnsDfh0Ir 36xtra36aEgYnpyztmagvtZhMR4MgBW5rGM6Ki29AQWIKjwLfiYKMx2HV4VrPPwsvQb5 HLBPH+nhUswPIkBij+qeRvrkP8xJocAUI9BxSNpz09ojEKKIj4zAlZZgeykzvnO07C56 0bjnWtEKfMDdn4vMHQq+4DZJ5MK9b+xWpBX7D+Jqu8dQ9Rl0mys9mC5Ftm6wfGg4v5P6 qYz1IwQtwM1hIN+PjCbvujkWmNf7+xpXbrSzxzPd+0Vox2xrNdtAmyaxTbSDxvjsWIbx 3icw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xdZaAA/zuFzYQdl3SdJx/bdQ9qYH+3gDPeoL6r0v1JU=; b=HXj5Xvwvax/TI4cAjGJLUGRGAfSe8e6oa5A9r2FKx+XsoOWO8jQV5cClbuWXTP6MNf A5vZys5i64J5m1ReOiyfLnZ2ua7zAiCNumGSXSo+7Yt35jE5I9xMW2BnZLLlDzN+WlDJ fk4/f+gq8xn5VhNUVfX1+VkDmZM9WHmW72L/xl59KZnNgnYRLsxWXhlet3cqAVSY1fcs LPukrEJf9zVUzNz6T/HV6ArpCj9+04ofS+MHwgeGTwr5zu0D1lIxhqbFzBMXINqF1DxZ 45RQKma8CY14FqTBkmO1iQSMGydEAlt9GRwm6qJ625ParesSc5xxYqiw5IcJ+iTQ5oCE V6/A== X-Gm-Message-State: AOAM533OT1+1vZ0bPx3RnIpH1F1wR0ONNdqybDaDEI8otPGFePrAC1oV lH05ZAfewcCBJonOe4DpB0mbRJP8Y2xMuAb3 X-Google-Smtp-Source: ABdhPJyvJO1p2BEgmI5oeOYa0EHRAEO7BVbpuZKJ7zDKRmUXrPdlx4o7139Sby87qi5FDPqnN+sKsw== X-Received: by 2002:a2e:979a:: with SMTP id y26mr545340lji.144.1642094578528; Thu, 13 Jan 2022 09:22:58 -0800 (PST) Received: from UNIT-808.labs.intellij.net ([91.132.204.19]) by smtp.gmail.com with ESMTPSA id h17sm323410ljk.41.2022.01.13.09.22.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Jan 2022 09:22:58 -0800 (PST) From: Vladislav Yaroshchuk To: qemu-devel@nongnu.org Subject: [PATCH v13 5/7] net/vmnet: implement bridged mode (vmnet-bridged) Date: Thu, 13 Jan 2022 20:22:17 +0300 Message-Id: <20220113172219.66372-6-yaroshchuk2000@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20220113172219.66372-1-yaroshchuk2000@gmail.com> References: <20220113172219.66372-1-yaroshchuk2000@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::12a (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::12a; envelope-from=yaroshchuk2000@gmail.com; helo=mail-lf1-x12a.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Vladislav Yaroshchuk , alex.bennee@linaro.org, jasowang@redhat.com, phillip.ennen@gmail.com, armbru@redhat.com, dirty@apple.com, f4bug@amsat.org, roman@roolebo.dev, r.bolshakov@yadro.com, agraf@csgraf.de, phillip@axleos.com, akihiko.odaki@gmail.com, hsp.cat7@gmail.com, hello@adns.io, qemu_oss@crudebyte.com, eblake@redhat.com, kraxel@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Vladislav Yaroshchuk --- net/vmnet-bridged.m | 105 +++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 100 insertions(+), 5 deletions(-) diff --git a/net/vmnet-bridged.m b/net/vmnet-bridged.m index 4e42a90391..bc499c6195 100644 --- a/net/vmnet-bridged.m +++ b/net/vmnet-bridged.m @@ -10,16 +10,111 @@ #include "qemu/osdep.h" #include "qapi/qapi-types-net.h" -#include "vmnet_int.h" -#include "clients.h" -#include "qemu/error-report.h" #include "qapi/error.h" +#include "clients.h" +#include "vmnet_int.h" #include +typedef struct VmnetBridgedState { + VmnetCommonState cs; +} VmnetBridgedState; + +static bool validate_ifname(const char *ifname) +{ + xpc_object_t shared_if_list = vmnet_copy_shared_interface_list(); + __block bool match = false; + + xpc_array_apply( + shared_if_list, + ^bool(size_t index, xpc_object_t value) { + if (strcmp(xpc_string_get_string_ptr(value), ifname) == 0) { + match = true; + return false; + } + return true; + }); + + return match; +} + +static const char *get_valid_ifnames(void) +{ + xpc_object_t shared_if_list = vmnet_copy_shared_interface_list(); + __block char *if_list = NULL; + + xpc_array_apply( + shared_if_list, + ^bool(size_t index, xpc_object_t value) { + if_list = g_strconcat(xpc_string_get_string_ptr(value), + " ", + if_list, + NULL); + return true; + }); + + if (if_list) { + return if_list; + } + return "[no interfaces]"; +} + +static xpc_object_t create_if_desc(const Netdev *netdev, Error **errp) +{ + const NetdevVmnetBridgedOptions *options = &(netdev->u.vmnet_bridged); + xpc_object_t if_desc = xpc_dictionary_create(NULL, NULL, 0); + + xpc_dictionary_set_uint64( + if_desc, + vmnet_operation_mode_key, + VMNET_BRIDGED_MODE + ); + +#if defined(MAC_OS_VERSION_11_0) && \ + MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_VERSION_11_0 + xpc_dictionary_set_bool( + if_desc, + vmnet_enable_isolation_key, + options->isolated + ); +#else + if (options->has_isolated) { + error_setg(errp, + "vmnet-bridged.isolated feature is " + "unavailable: outdated vmnet.framework API"); + } +#endif + + if (validate_ifname(options->ifname)) { + xpc_dictionary_set_string(if_desc, + vmnet_shared_interface_name_key, + options->ifname); + } else { + return NULL; + } + return if_desc; +} + +static NetClientInfo net_vmnet_bridged_info = { + .type = NET_CLIENT_DRIVER_VMNET_BRIDGED, + .size = sizeof(VmnetBridgedState), + .receive = vmnet_receive_common, + .cleanup = vmnet_cleanup_common, +}; + int net_init_vmnet_bridged(const Netdev *netdev, const char *name, NetClientState *peer, Error **errp) { - error_setg(errp, "vmnet-bridged is not implemented yet"); - return -1; + NetClientState *nc = qemu_new_net_client(&net_vmnet_bridged_info, + peer, "vmnet-bridged", name); + xpc_object_t if_desc = create_if_desc(netdev, errp);; + + if (!if_desc) { + error_setg(errp, + "unsupported ifname, should be one of: %s", + get_valid_ifnames()); + return -1; + } + + return vmnet_if_create(nc, if_desc, errp, NULL); } -- 2.23.0