From: Warner Losh <imp@bsdimp.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
richard.henderson@linaro.org, f4bug@amsat.org,
Warner Losh <imp@bsdimp.com>, Laurent Vivier <laurent@vivier.eu>
Subject: [PATCH 2/2] linxu-user: Change return type of queue_signal to void
Date: Sun, 16 Jan 2022 13:44:23 -0700 [thread overview]
Message-ID: <20220116204423.16133-3-imp@bsdimp.com> (raw)
In-Reply-To: <20220116204423.16133-1-imp@bsdimp.com>
queue_signal always returns 1, and nobody checks it. This is better
expressed as a void function return type.
Signed-off-by: Warner Losh <imp@bsdimp.com>
---
linux-user/signal-common.h | 4 ++--
linux-user/signal.c | 5 ++---
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/linux-user/signal-common.h b/linux-user/signal-common.h
index 42aa479080b..2113165a758 100644
--- a/linux-user/signal-common.h
+++ b/linux-user/signal-common.h
@@ -59,8 +59,8 @@ void setup_rt_frame(int sig, struct target_sigaction *ka,
void process_pending_signals(CPUArchState *cpu_env);
void signal_init(void);
-int queue_signal(CPUArchState *env, int sig, int si_type,
- target_siginfo_t *info);
+void queue_signal(CPUArchState *env, int sig, int si_type,
+ target_siginfo_t *info);
void host_to_target_siginfo(target_siginfo_t *tinfo, const siginfo_t *info);
void target_to_host_siginfo(siginfo_t *info, const target_siginfo_t *tinfo);
int target_to_host_signal(int sig);
diff --git a/linux-user/signal.c b/linux-user/signal.c
index f813b4f18e4..eddc95e87df 100644
--- a/linux-user/signal.c
+++ b/linux-user/signal.c
@@ -780,8 +780,8 @@ static void QEMU_NORETURN dump_core_and_abort(int target_sig)
/* queue a signal so that it will be send to the virtual CPU as soon
as possible */
-int queue_signal(CPUArchState *env, int sig, int si_type,
- target_siginfo_t *info)
+void queue_signal(CPUArchState *env, int sig, int si_type,
+ target_siginfo_t *info)
{
CPUState *cpu = env_cpu(env);
TaskState *ts = cpu->opaque;
@@ -794,7 +794,6 @@ int queue_signal(CPUArchState *env, int sig, int si_type,
ts->sync_signal.pending = sig;
/* signal that a new signal is pending */
qatomic_set(&ts->signal_pending, 1);
- return 1; /* indicates that the signal was queued */
}
--
2.33.1
next prev parent reply other threads:[~2022-01-16 20:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-16 20:44 [PATCH 0/2] linux-user: Two minor patches Warner Losh
2022-01-16 20:44 ` [PATCH 1/2] linx-user: Remove MAX_SIGQUEUE_SIZE Warner Losh
2022-01-16 21:16 ` Philippe Mathieu-Daudé via
2022-01-16 21:45 ` Peter Maydell
2022-01-18 11:45 ` Laurent Vivier
2022-01-16 20:44 ` Warner Losh [this message]
2022-01-16 21:44 ` [PATCH 2/2] linxu-user: Change return type of queue_signal to void Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220116204423.16133-3-imp@bsdimp.com \
--to=imp@bsdimp.com \
--cc=f4bug@amsat.org \
--cc=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).